Page MenuHomePhabricator

[scudo][standalone] Potential fix for missing sized delete
ClosedPublic

Authored by cryptoad on Jul 2 2019, 9:58 AM.

Details

Summary

In some setups, using -fsized-deallocation would end up not finding
a sized delete operator at link time. For now, avoid using the flag
and declare the sized delete operator in the cpp test only.

This is a tentative fix as I do not have the failing setup.

Diff Detail

Repository
rL LLVM

Event Timeline

cryptoad created this revision.Jul 2 2019, 9:58 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 2 2019, 9:58 AM
Herald added subscribers: Restricted Project, delcypher, mgorny. · View Herald Transcript
cryptoad updated this revision to Diff 207586.Jul 2 2019, 10:11 AM

s/kostya/kostyak/

hctim accepted this revision.Jul 2 2019, 10:26 AM
This revision is now accepted and ready to land.Jul 2 2019, 10:26 AM
rnk accepted this revision.Jul 2 2019, 1:13 PM

lgtm

I see. But won't there still be link errors for the cpp test? Anyway, I'll try to reproduce the build our Chromium bot uses. I filed https://crbug.com/980389 to track it.

rnk added a comment.Jul 2 2019, 1:14 PM
In D64086#1567106, @rnk wrote:

I see. But won't there still be link errors for the cpp test? Anyway, I'll try to reproduce the build our Chromium bot uses. I filed https://crbug.com/980389 to track it.

I see your answers to these questions in https://crbug.com/980389#c1. Sounds good.

This revision was automatically updated to reflect the committed changes.