This is an archive of the discontinued LLVM Phabricator instance.

Differential D63416

[RISCV] Use DW_EH_PE_udata4 for call site encoding in .gcc_except_table
AbandonedPublic

Authored by edward-jones on Jun 17 2019, 4:49 AM.

Details

Reviewers
asb
lewis-revill

Diff Detail

Event Timeline

edward-jones created this revision.Jun 17 2019, 4:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2019, 4:49 AM
Herald added subscribers: llvm-commits, benna, psnobl and 4 others. · View Herald Transcript
edward-jones added a parent revision: D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.Jun 17 2019, 4:55 AM
edward-jones updated this revision to Diff 205548.Jun 19 2019, 4:26 AM
edward-jones retitled this revision from [WIP][RISCV] Use DW_EH_PE_udata4 for call site encoding in .gcc_except_table to [RISCV] Use DW_EH_PE_udata4 for call site encoding in .gcc_except_table.

Added tests, rebased

Herald added subscribers: Jim, jocewei, PkmX and 10 others. · View Herald TranscriptJun 19 2019, 4:26 AM
HsiangKai mentioned this in D63409: [RISCV] Specify various encodings for DWARF exception handling.Jun 24 2019, 8:46 PM
asb mentioned this in D63415: [AsmPrinter] Make the encoding of call sites in .gcc_except_table configurable.Jul 2 2019, 3:15 AM
edward-jones abandoned this revision.Jul 3 2019, 5:39 AM

Changes from this revision have been merged into D63415

Revision Contents

PathSize
lib/
CodeGen/
1 line
test/
CodeGen/
RISCV/
21 lines

Diff 205548

lib/CodeGen/TargetLoweringObjectFileImpl.cpp

Show First 20 Lines • Show All 219 Lines • ▼ Show 20 Lines if (isPositionIndependent()) {
LSDAEncoding = dwarf::DW_EH_PE_udata4; LSDAEncoding = dwarf::DW_EH_PE_udata4;
TTypeEncoding = dwarf::DW_EH_PE_udata4; TTypeEncoding = dwarf::DW_EH_PE_udata4;
} else { } else {
assert(CM == CodeModel::Medium); assert(CM == CodeModel::Medium);
PersonalityEncoding = dwarf::DW_EH_PE_indirect | dwarf::DW_EH_PE_absptr; PersonalityEncoding = dwarf::DW_EH_PE_indirect | dwarf::DW_EH_PE_absptr;
LSDAEncoding = dwarf::DW_EH_PE_absptr; LSDAEncoding = dwarf::DW_EH_PE_absptr;
TTypeEncoding = dwarf::DW_EH_PE_absptr; TTypeEncoding = dwarf::DW_EH_PE_absptr;
} }
CallSiteEncoding = dwarf::DW_EH_PE_udata4;
break; break;
case Triple::sparcel: case Triple::sparcel:
case Triple::sparc: case Triple::sparc:
if (isPositionIndependent()) { if (isPositionIndependent()) {
LSDAEncoding = dwarf::DW_EH_PE_pcrel | dwarf::DW_EH_PE_sdata4; LSDAEncoding = dwarf::DW_EH_PE_pcrel | dwarf::DW_EH_PE_sdata4;
PersonalityEncoding = dwarf::DW_EH_PE_indirect | dwarf::DW_EH_PE_pcrel | PersonalityEncoding = dwarf::DW_EH_PE_indirect | dwarf::DW_EH_PE_pcrel |
dwarf::DW_EH_PE_sdata4; dwarf::DW_EH_PE_sdata4;
TTypeEncoding = dwarf::DW_EH_PE_indirect | dwarf::DW_EH_PE_pcrel | TTypeEncoding = dwarf::DW_EH_PE_indirect | dwarf::DW_EH_PE_pcrel |
▲ Show 20 Lines • Show All 1,599 Lines • Show Last 20 Lines

test/CodeGen/RISCV/exception.ll

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Lines
; MED-NEXT: .byte 0 ; MED-NEXT: .byte 0
; ^-- Type table encoding: DW_EH_PE_absptr ; ^-- Type table encoding: DW_EH_PE_absptr
; PIC-NEXT: .byte 155 ; PIC-NEXT: .byte 155
; ^-- Type table encoding: DW_EH_PE_indirect | ; ^-- Type table encoding: DW_EH_PE_indirect |
; DW_EH_PE_pcrel | ; DW_EH_PE_pcrel |
; DW_EH_PE_sdata4 ; DW_EH_PE_sdata4
; # Call site encoding # ; # Call site encoding #
; CHECK: .Lttbaseref0: ; CHECK: .Lttbaseref0:
; CHECK-NEXT: .byte 3
; ^-- Call site encoding: DW_EH_PE_udata4
; # Call sites #
; Unlike most other targets these are encoded as DW_EH_PE_udata4 instead
; of DW_EH_PE_uleb128, as we can't emit relocation for a difference between
; uleb128 encoded values.
;
; CHECK: .Lcst_begin0:
; CHECK-NEXT: .word .Lfunc_begin0-.Lfunc_begin0
; CHECK-NEXT: .word .Ltmp0-.Lfunc_begin0
; CHECK-NEXT: .word 0
; CHECK-NEXT: .byte 0
; CHECK-NEXT: .word .Ltmp0-.Lfunc_begin0
; CHECK-NEXT: .word .Ltmp1-.Ltmp0
; CHECK-NEXT: .word .Ltmp2-.Lfunc_begin0
; CHECK-NEXT: .byte 1 ; CHECK-NEXT: .byte 1
; ^-- Call site encoding: DW_EH_PE_uleb128 ; CHECK-NEXT: .word .Ltmp1-.Lfunc_begin0
; CHECK-NEXT: .word .Lfunc_end0-.Ltmp1
; CHECK-NEXT: .word 0
; CHECK-NEXT: .byte 0
; CHECK-NEXT: .Lcst_end0: