Page MenuHomePhabricator

[PlistSupport] Produce a newline to end plist output files
ClosedPublic

Authored by hubert.reinterpretcast on Jun 7 2019, 7:37 PM.

Details

Summary

As suggested in the review of D62949, this patch updates the plist output to have a newline at the end of the file. This makes it so that the plist output file qualifies as a POSIX text file, which increases the consumability of the generated plist file in relation to various tools.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2019, 7:37 PM
Herald added a subscriber: jsji. · View Herald Transcript
xingxue accepted this revision.Jun 10 2019, 10:18 AM

LGTM.

This revision is now accepted and ready to land.Jun 10 2019, 10:18 AM
NoQ accepted this revision.Jun 10 2019, 1:01 PM

Thanks!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2019, 3:28 PM