Page MenuHomePhabricator

[ELF] Delete GotEntrySize and GotPltEntrySize
ClosedPublic

Authored by MaskRay on May 31 2019, 3:06 AM.

Details

Summary

GotEntrySize and GotPltEntrySize were added in D22288. Later, with
the introduction of wordsize() (then Config->Wordsize), they become
redundant, because there is no target that sets GotEntrySize or
GotPltEntrySize to a number different from Config->Wordsize.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.May 31 2019, 3:06 AM
grimar accepted this revision.May 31 2019, 3:14 AM

This is probably LGTM, but please hold on for a while to see if other have opinions/objectios.

This revision is now accepted and ready to land.May 31 2019, 3:14 AM
ruiu accepted this revision.May 31 2019, 3:25 AM

LGTM

GOT entry size is naturally the pointer size, and Config->Wordsize is intended to be the same as the pointer size. If we should support an exotic target that uses odd size GOT entries, we'd have to get this back, but we don't have to worry too much about it now.

This revision was automatically updated to reflect the committed changes.

CHERI, and thus Arm's Morello, *are* such targets where pointers are bigger than a machine word, as they contain more than just the address. Whilst we can re-add such fields downstream, it would be nicer if upstream kept them.