[ASTImporter] Added visibility context check for CXXRecordDecl.

[balazske]

Summary

ASTImporter makes now difference between classes with same name in different
translation units if these are not visible outside. These classes are not linked
into one decl chain.

[shafik]

Minor comments, I am going to run check-lldb now.

unittests/AST/ASTImporterVisibilityTest.cpp

34

GetCXXRecordPattern feels more consistent.

49

const? It is not consistent w/ the previous declarations.

50

const? It is not consistent w/ the previous declarations.

[shafik]

LGTM

[balazske]

Thanks for reviewing.

Similar additions are planned to follow with function and variable template, enum, scoped enum, typedef, type alias.

unittests/AST/ASTImporterVisibilityTest.cpp

34

The exact decl name is not repeated in these variable names like "FunPattern" for functions. Using "class" instead of "CXXRecord" can be acceptable. I do not like ImportCXXRecordsVisibilityChain (GetRecPattern and ImportRecordsVisibilityChain may be good too, but we do not say "C++ record" for thing that is a class).

[balazske]

• Changed type of string constants to const.