This is an archive of the discontinued LLVM Phabricator instance.

Differential D62051

[ELF][test] Reorganize some R_*_NONE tests
ClosedPublic

Authored by MaskRay on May 16 2019, 8:50 PM.

Details

Reviewers
ruiu
• espindola
grimar
pcc
peter.smith
Commits
rZORGc82178353095: [ELF][test] Reorganize some R_*_NONE tests
rGc82178353095: [ELF][test] Reorganize some R_*_NONE tests
rGef9b8e03fd03: [ELF][test] Reorganize some R_*_NONE tests
rLLD361013: [ELF][test] Reorganize some R_*_NONE tests
rL361013: [ELF][test] Reorganize some R_*_NONE tests
Summary

Change R_{386,AARCH64}_NONE yaml2obj tests/icf10.test to use assembly

Add relocation-none-{arm,x86_64}.s.

Check the referenced section survives under --gc-sections.
Check -r copies R_X86_64_NONE R_AARCH64_NONE. (Elf*_Rel arches currently have a bug)
Delete the dtrace tests as they are covered by the R_X86_64_NONE test.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.May 16 2019, 8:50 PM
Herald added a reviewer: • espindola. · View Herald TranscriptMay 16 2019, 8:50 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, kristof.beyls, arichardson and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B32043: Diff 199973.May 16 2019, 8:52 PM
MaskRay updated this revision to Diff 199975.May 16 2019, 9:38 PM
MaskRay retitled this revision from [ELF][test] Add relocation-none*.s to [ELF][test] Reorganize some R_*_NONE tests.
MaskRay edited the summary of this revision. (Show Details)
MaskRay added reviewers: grimar, pcc.

Update description and convert icf10.test

Harbormaster completed remote builds in B32044: Diff 199975.May 16 2019, 9:41 PM
MaskRay updated this revision to Diff 199976.May 16 2019, 9:50 PM
MaskRay edited the summary of this revision. (Show Details)
MaskRay added a reviewer: peter.smith.

Update description

Harbormaster completed remote builds in B32045: Diff 199976.May 16 2019, 9:50 PM
MaskRay added a child revision: D62052: [ELF] -r: fix R_*_NONE to section symbols on Elf*_Rel targets.May 16 2019, 11:21 PM
peter.smith added a comment.May 17 2019, 1:48 AM

I've no objections to making this change.

ruiu accepted this revision.May 17 2019, 3:31 AM

LGTM

This revision is now accepted and ready to land.May 17 2019, 3:31 AM
Closed by commit rL361013: [ELF][test] Reorganize some R_*_NONE tests (authored by MaskRay). · Explain WhyMay 17 2019, 3:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 200011

lld/trunk/test/ELF/Inputs/dtrace-r.o

  • This is a binary file.

lld/trunk/test/ELF/dtrace-r.test

RUN: ld.lld -r -o %t.o %p/Inputs/dtrace-r.o
RUN: llvm-readobj -r %t.o | FileCheck %s
CHECK: Relocations [
CHECK-NEXT: Section ({{.*}}) .rela.text {
CHECK-NEXT: 0x0 R_X86_64_NONE - 0x0
CHECK-NEXT: }
CHECK-NEXT: ]

lld/trunk/test/ELF/icf10.s

# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-freebsd %s -o %t.o
# RUN: ld.lld --icf=all %t.o -o /dev/null --print-icf-sections 2>&1 | FileCheck %s
# Checks that ICF does not merge 2 sections the offset of
# the relocations of which differ.
# CHECK-NOT: selected
.section .text.foo,"ax"
.quad -1
.reloc 0, R_X86_64_NONE, 0
.section .text.bar,"ax"
.quad -1
.reloc 1, R_X86_64_NONE, 0

lld/trunk/test/ELF/icf10.test

# RUN: yaml2obj %s -o %t.o
# RUN: ld.lld --icf=all %t.o -o /dev/null --print-icf-sections 2>&1 | FileCheck %s
# Checks that ICF does not merge 2 sections the offset of
# the relocations of which differ.
# CHECK-NOT: selected
!ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
OSABI: ELFOSABI_FREEBSD
Type: ET_REL
Machine: EM_X86_64
Sections:
- Name: .text.foo
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_EXECINSTR]
Content: "FFFFFFFFFFFFFFFF"
- Name: .text.bar
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_EXECINSTR]
Content: "FFFFFFFFFFFFFFFF"
- Name: .rela.text.foo
Type: SHT_RELA
Link: .symtab
Info: .text.foo
Relocations:
- Offset: 0x0000000000000000
Type: R_X86_64_NONE
- Name: .rela.text.bar
Type: SHT_RELA
Link: .symtab
Info: .text.bar
Relocations:
- Offset: 0x0000000000000001
Type: R_X86_64_NONE

lld/trunk/test/ELF/relocation-dtrace.test

# RUN: yaml2obj %s -o %t.o
# RUN: ld.lld -shared %t.o -o /dev/null
# Test that we can handle R_X86_64_NONE as produced by dtrace.
!ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
OSABI: ELFOSABI_FREEBSD
Type: ET_REL
Machine: EM_X86_64
Sections:
- Name: .text
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC ]
- Name: .rela.text
Type: SHT_RELA
Link: .symtab
Info: .text
Relocations:
- Offset: 0x0000000000000000
Type: R_X86_64_NONE

lld/trunk/test/ELF/relocation-none-aarch64.s

# RUN: llvm-mc -filetype=obj -triple=aarch64-linux-musl %s -o %t.o
# RUN: ld.lld --gc-sections %t.o -o %t
# RUN: llvm-readelf -S -r %t | FileCheck %s
# Test that we discard R_AARCH64_NONE, but respect the references it creates
# among sections.
# CHECK: .data
# CHECK: There are no relocations in this file.
# RUN: ld.lld -r %t.o -o %t
# RUN: llvm-readobj -r %t | FileCheck --check-prefix=RELOC %s
# RELOC: Section ({{.*}}) .rela.text {
# RELOC-NEXT: 0x0 R_AARCH64_NONE .data 0x0
# RELOC-NEXT: }
.globl _start
_start:
ret
.reloc 0, R_AARCH64_NONE, .data
.data
.long 0

lld/trunk/test/ELF/relocation-none-aarch64.test

# REQUIRES: aarch64
# RUN: yaml2obj %s -o %t.o
# RUN: ld.lld %t.o -o /dev/null
!ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_AARCH64
Sections:
- Type: SHT_PROGBITS
Name: .text
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
Content: "00000000"
- Type: SHT_RELA
Name: .rela.text
Link: .symtab
Info: .text
Relocations:
- Offset: 0
Type: R_AARCH64_NONE

lld/trunk/test/ELF/relocation-none-arm.s

# RUN: llvm-mc -filetype=obj -triple=armv7-linux-musl %s -o %t.o
# RUN: ld.lld --gc-sections %t.o -o %t
# RUN: llvm-readelf -S -r %t | FileCheck %s
# Test that we discard R_ARM_NONE, but respect the references it creates among
# sections.
# CHECK: .data
# CHECK: There are no relocations in this file.
.globl _start
_start:
nop
.reloc 0, R_ARM_NONE, .data
.data
.long 0

lld/trunk/test/ELF/relocation-none-i386.s

# RUN: llvm-mc -filetype=obj -triple=i386-linux-musl %s -o %t.o
# RUN: ld.lld --gc-sections %t.o -o %t
# RUN: llvm-readelf -S -r %t | FileCheck %s
# Test that we discard R_386_NONE, but respect the
# references it creates among sections.
# CHECK: .data
# CHECK: There are no relocations in this file.
.globl _start
_start:
ret
.reloc 0, R_386_NONE, .data
.data
.long 0

lld/trunk/test/ELF/relocation-none-i686.test

# RUN: yaml2obj %s -o %t.o
# RUN: ld.lld %t.o -o /dev/null
# Test that we can handle R_386_NONE.
!ELF
FileHeader:
Class: ELFCLASS32
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_386
Sections:
- Name: .text
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC ]
- Name: .rel.text
Type: SHT_RELA
Link: .symtab
Info: .text
Relocations:
- Offset: 0x0000000000000000
Type: R_386_NONE

lld/trunk/test/ELF/relocation-none-x86-64.s

# RUN: llvm-mc -filetype=obj -triple=x86_64-linux-musl %s -o %t.o
# RUN: ld.lld --gc-sections %t.o -o %t
# RUN: llvm-readelf -S -r %t | FileCheck %s
# Test that we discard R_X86_64_NONE, but respect the
# references it creates among sections.
# CHECK: .data
# CHECK: There are no relocations in this file.
# RUN: ld.lld -r %t.o -o %t
# RUN: llvm-readobj -r %t | FileCheck --check-prefix=RELOC %s
# RELOC: Section ({{.*}}) .rela.text {
# RELOC-NEXT: 0x0 R_X86_64_NONE .data 0x0
# RELOC-NEXT: }
.globl _start
_start:
ret
.reloc 0, R_X86_64_NONE, .data
.data
.long 0
lld/trunk/test/ELF/relocation-none-arm.s