Page MenuHomePhabricator

[ELF][test] Reorganize some R_*_NONE tests
ClosedPublic

Authored by MaskRay on May 16 2019, 8:50 PM.

Details

Summary

Change R_{386,AARCH64}_NONE yaml2obj tests/icf10.test to use assembly

Add relocation-none-{arm,x86_64}.s.

Check the referenced section survives under --gc-sections.
Check -r copies R_X86_64_NONE R_AARCH64_NONE. (Elf*_Rel arches currently have a bug)
Delete the dtrace tests as they are covered by the R_X86_64_NONE test.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.May 16 2019, 8:50 PM
MaskRay updated this revision to Diff 199975.May 16 2019, 9:38 PM
MaskRay retitled this revision from [ELF][test] Add relocation-none*.s to [ELF][test] Reorganize some R_*_NONE tests.
MaskRay edited the summary of this revision. (Show Details)
MaskRay added reviewers: grimar, pcc.

Update description and convert icf10.test

MaskRay updated this revision to Diff 199976.May 16 2019, 9:50 PM
MaskRay edited the summary of this revision. (Show Details)
MaskRay added a reviewer: peter.smith.

Update description

I've no objections to making this change.

ruiu accepted this revision.May 17 2019, 3:31 AM

LGTM

This revision is now accepted and ready to land.May 17 2019, 3:31 AM
This revision was automatically updated to reflect the committed changes.