[Analysis] Only run plugins tests if plugins are actually enabled

[phosek]

Summary

When plugins aren't enabled, don't try to run plugins tests. Don't
enable plugins unconditionally based on the platform, instead check
if LLVM shared library is actually being built which may not be the
case for every host configuration, even if the host itself supports
plugins.

This addresses test failures introduced by r360891/D59464.

[Szelethus]

Thank you so much! :)

[hintonda]

llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

930 ↗

(On Diff #199977)

This is a breaking patch. What's the rational for unilaterally disabling LLVM_ENABLE_PLUGINS.

It gives the following errors:
-- PrintFunctionNames ignored -- Loadable modules not supported on this platform.
-- AnnotateFunctions ignored -- Loadable modules not supported on this platform.
-- SampleAnalyzerPlugin ignored -- Loadable modules not supported on this platform.
-- CheckerDependencyHandlingAnalyzerPlugin ignored -- Loadable modules not supported on this platform.
-- CheckerOptionHandlingAnalyzerPlugin ignored -- Loadable modules not supported on this platform.
-- BugpointPasses ignored -- Loadable modules not supported on this platform.
-- TestPlugin ignored -- Loadable modules not supported on this platform.

[hintonda]

llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

930 ↗

(On Diff #199977)

Btw, the change essentially turns off testing of plugins, and bugpoint, etc., in all the buildbots, but since it isn't reported as an error, they don't report that these tests are no longer run.,

[vitalybuka]

This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory)

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/21622/steps/check-cfi-and-supported%20in%20gcc%20build/logs/stdio

100%] Running the cfi regression tests
llvm-lit: /b/sanitizer-x86_64-linux/build/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '/b/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/cfi/lit.cfg', traceback: Traceback (most recent call last):
  File "/b/sanitizer-x86_64-linux/build/llvm/utils/lit/lit/TestingConfig.py", line 89, in load_from_path
    exec(compile(data, path, 'exec'), cfg_globals, None)
  File "/b/sanitizer-x86_64-linux/build/llvm/projects/compiler-rt/test/cfi/lit.cfg", line 46, in <module>
    raise BaseException("Tests unsupported")
BaseException: Tests unsupported

projects/compiler-rt/test/cfi/CMakeFiles/check-cfi-and-supported.dir/build.make:57: recipe for target 'projects/compiler-rt/test/cfi/CMakeFiles/check-cfi-and-supported' failed
make[3]: *** [projects/compiler-rt/test/cfi/CMakeFiles/check-cfi-and-supported] Error 2
CMakeFiles/Makefile2:37638: recipe for target 'projects/compiler-rt/test/cfi/CMakeFiles/check-cfi-and-supported.dir/all' failed
make[2]: *** [projects/compiler-rt/test/cfi/CMakeFiles/check-cfi-and-supported.dir/all] Error 2
CMakeFiles/Makefile2:37645: recipe for target 'projects/compiler-rt/test/cfi/CMakeFiles/check-cfi-and-supported.dir/rule' failed
make[1]: *** [projects/compiler-rt/test/cfi/CMakeFiles/check-cfi-and-supported.dir/rule] Error 2
Makefile:12157: recipe for target 'check-cfi-and-supported' failed
make: *** [check-cfi-and-supported] Error 2
+ echo @@@STEP_FAILURE@@@
+ check_in_gcc 1 dfsan
@@@STEP_FAILURE@@@
+ CONDITION=1
+ SANITIZER=dfsan
+ '[' 1 == 1 ']'
+ echo @@@BUILD_STEP check-dfsan in gcc build@@@

[vitalybuka]

In D62050#1509384, @vitalybuka wrote:

This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory)

I've fixed this with DLLVM_BUILD_LLVM_DYLIB=ON but not sure if this is the right approach long-term.

[hintonda]

In D62050#1509400, @vitalybuka wrote:

In D62050#1509384, @vitalybuka wrote:

This also breaks "ninja check-cfi-and-supported" on clean build (run cmake in empty directory)

I've fixed this with DLLVM_BUILD_LLVM_DYLIB=ON but not sure if this is the right approach long-term.

I have a patch that only reverts the changes to HandleLLVMOptions.cmake, D62154, and restores previous behavior.

clang/test/Analysis/checker-plugins.c

+// REQUIRES: plugins
+
 // RUN: %clang_analyze_cc1 -verify %s \
 // RUN:   -load %llvmshlibdir/SampleAnalyzerPlugin%pluginext \
 // RUN:   -analyzer-checker='example.MainCallChecker'
 
-// REQUIRES: plugins
-
 // Test that the MainCallChecker example analyzer plugin loads and runs.
 
 int main();
 
 void caller() {
   main(); // expected-warning {{call to main}}
 }
 

clang/test/CMakeLists.txt

 endif()
 
 llvm_canonicalize_cmake_booleans(
   CLANG_BUILD_EXAMPLES
   CLANG_ENABLE_ARCMT
   CLANG_ENABLE_STATIC_ANALYZER
   ENABLE_BACKTRACES
   HAVE_LIBZ
-  LLVM_ENABLE_PER_TARGET_RUNTIME_DIR)
+  LLVM_ENABLE_PER_TARGET_RUNTIME_DIR
+  LLVM_ENABLE_PLUGINS)
 
 configure_lit_site_cfg(
   ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in
   ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py
   MAIN_CONFIG
   ${CMAKE_CURRENT_SOURCE_DIR}/lit.cfg.py
   )
 

clang/test/lit.cfg.py

 
 llvm_config.add_tool_substitutions(tools, tool_dirs)
 
 config.substitutions.append(
     ('%hmaptool', "'%s' %s" % (config.python_executable,
                              os.path.join(config.clang_tools_dir, 'hmaptool'))))
 
 # Plugins (loadable modules)
-# TODO: This should be supplied by Makefile or autoconf.
-if sys.platform in ['win32', 'cygwin']:
-    has_plugins = config.enable_shared
-else:
-    has_plugins = True
-
-if has_plugins and config.llvm_plugin_ext:
+if config.has_plugins and config.llvm_plugin_ext:
     config.available_features.add('plugins')
 
 # Set available features we allow tests to conditionalize on.
 #
 if config.clang_default_cxx_stdlib != '':
     config.available_features.add('default-cxx-stdlib-set')
 
 # As of 2011.08, crash-recovery tests still do not pass on FreeBSD.

clang/test/lit.site.cfg.py.in

 config.clang_staticanalyzer = @CLANG_ENABLE_STATIC_ANALYZER@
 config.clang_staticanalyzer_z3 = "@LLVM_WITH_Z3@"
 config.clang_examples = @CLANG_BUILD_EXAMPLES@
 config.enable_shared = @ENABLE_SHARED@
 config.enable_backtrace = @ENABLE_BACKTRACES@
 config.host_arch = "@HOST_ARCH@"
 config.python_executable = "@PYTHON_EXECUTABLE@"
 config.use_z3_solver = lit_config.params.get('USE_Z3_SOLVER', "@USE_Z3_SOLVER@")
+config.has_plugins = @LLVM_ENABLE_PLUGINS@
 
 # Support substitution of the tools and libs dirs with user parameters. This is
 # used when we can't determine the tool dir at configuration time.
 try:
     config.clang_tools_dir = config.clang_tools_dir % lit_config.params
     config.llvm_tools_dir = config.llvm_tools_dir % lit_config.params
     config.llvm_shlib_dir = config.llvm_shlib_dir % lit_config.params
     config.llvm_libs_dir = config.llvm_libs_dir % lit_config.params

llvm/cmake/modules/HandleLLVMOptions.cmake

if(BUILD_SHARED_LIBS AND LLVM_EXPORT_SYMBOLS_FOR_PLUGINS)
   message(FATAL_ERROR "BUILD_SHARED_LIBS not compatible with LLVM_EXPORT_SYMBOLS_FOR_PLUGINS")
 endif()
 if(LLVM_LINK_LLVM_DYLIB AND LLVM_EXPORT_SYMBOLS_FOR_PLUGINS)
   message(FATAL_ERROR "LLVM_LINK_LLVM_DYLIB not compatible with LLVM_EXPORT_SYMBOLS_FOR_PLUGINS")
 endif()
 
 # Plugin support
 # FIXME: Make this configurable.
-if(WIN32 OR CYGWIN)
-  if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB)
-    set(LLVM_ENABLE_PLUGINS ON)
-  else()
-    set(LLVM_ENABLE_PLUGINS OFF)
-  endif()
-else()
-  set(LLVM_ENABLE_PLUGINS ON)
-endif()
 
 # By default we should enable LLVM_ENABLE_IDE only for multi-configuration
 # generators. This option disables optional build system features that make IDEs
 # less usable.
 set(LLVM_ENABLE_IDE_default OFF)
 if (CMAKE_CONFIGURATION_TYPES)
   set(LLVM_ENABLE_IDE_default ON)
 endif()