Page MenuHomePhabricator

[GWP-ASan] Add missing dependency on C++ headers
AbandonedPublic

Authored by phosek on May 16 2019, 3:32 PM.

Details

Summary

GWP-ASan implementation uses standard C++ headers. When C++ library
is being built as part of the toolchain rather than relying on the
host one, we need to make sure that headers are in place before we
start building GWP-ASan otherwise the build will fail. This is the
same solution that's already used by other runtimes: ASan, HWASan,
libFuzzer and XRay.

Diff Detail

Event Timeline

phosek created this revision.May 16 2019, 3:32 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 16 2019, 3:32 PM
Herald added subscribers: llvm-commits, Restricted Project, mgorny, kubamracek. · View Herald Transcript

Seems reasonable to me if we're fine with using libc++. Mitch, did you intend to introduce the libc++ dependency include <ctime> here?

hctim added a comment.May 16 2019, 5:46 PM

I've filed D62048 which should resolve the build order discrepancy. Would prefer to do that rather than this as GWP-ASan shouldn't need to clash swords with c++ standard library, as it shouldn't be using it in the first place :)

phosek abandoned this revision.May 18 2019, 2:38 PM

No longer needed since D62048 has landed.