Page MenuHomePhabricator

[GWP-ASan] Fixed issue with c++ standard library dependency.
ClosedPublic

Authored by hctim on May 16 2019, 5:44 PM.

Details

Summary

Removed dependency on c++ standard library. Some supporting allocators (namely Scudo on Fuchsia, and shortly, scudo standalone) has a hard requirement of no c++stdlib.

This patch updates the build system so that we don't have any c++ stdlib dependencies. It also will conveniently fix a racy build-order bug discrepency between GWP-ASan and libc++.

Diff Detail

Event Timeline

hctim created this revision.May 16 2019, 5:44 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 16 2019, 5:44 PM
Herald added subscribers: llvm-commits, Restricted Project, cryptoad and 2 others. · View Herald Transcript
morehouse accepted this revision.May 16 2019, 5:57 PM
morehouse added inline comments.
compiler-rt/lib/gwp_asan/CMakeLists.txt
13 ↗(On Diff #199948)

"transient" - So Scudo's no-C++ library requirement will go away at some point?

This revision is now accepted and ready to land.May 16 2019, 5:57 PM
phosek accepted this revision.May 16 2019, 7:17 PM

LGTM, would it be possible to land this?

hctim added a comment.May 16 2019, 7:23 PM

LGTM, would it be possible to land this?

Will do sometime in the next couple of hours when I can reach a laptop.

hctim updated this revision to Diff 199966.May 16 2019, 8:13 PM
hctim marked 2 inline comments as done.
  • /s/transient/delegated
compiler-rt/lib/gwp_asan/CMakeLists.txt
13 ↗(On Diff #199948)

TIL I've been using this word wrong. /s/transient/delegated.

hctim updated this revision to Diff 199968.May 16 2019, 8:16 PM
  • Merge branch 'master' into gwp_asan/fix-c++stdlib
This revision was automatically updated to reflect the committed changes.