This is an archive of the discontinued LLVM Phabricator instance.

[CommandLine] Enable Grouping for short options by default. Part 4 of 5
ClosedPublic

Authored by hintonda on Apr 29 2019, 10:31 AM.

Event Timeline

hintonda created this revision.Apr 29 2019, 10:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2019, 10:31 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
hintonda retitled this revision from [CommandLine] Enable Grouping for short options by default. to [CommandLine] Enable Grouping for short options by default. Part 4 of 5.Apr 29 2019, 10:41 AM
hintonda updated this revision to Diff 197220.Apr 29 2019, 4:42 PM
  • Fix test error message.

Thank you for the patch series!

This is consistent with GNU getopt behavior.

This is not GNU specific :) It is POSIX Utility Syntax Guidelines 5 http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html

hintonda updated this revision to Diff 197271.Apr 30 2019, 1:38 AM
  • Fix test.
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2019, 1:38 AM
hintonda updated this revision to Diff 197272.Apr 30 2019, 1:41 AM

Minimize diff.

Harbormaster completed remote builds in B31144: Diff 197272.

Thank you for the patch series!

This is consistent with GNU getopt behavior.

This is not GNU specific :) It is POSIX Utility Syntax Guidelines 5 http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html

Thanks for pointing that out.

While not mentioned here, this series of patches also deals with long options which I believe is a GNU thing -- at least I think that's true. In any case, the ultimate goal of these patches is to allow GNU compatibility.

MaskRay accepted this revision.Apr 30 2019, 11:05 PM
This revision is now accepted and ready to land.Apr 30 2019, 11:05 PM
This revision was automatically updated to reflect the committed changes.