Details
- Reviewers
ruiu rupprecht • espindola grimar jhenderson - Commits
- rG5387c2cd17b2: [llvm-objdump] Print newlines before and after "Disassembly of section ...:"
rL359668: [llvm-objdump] Print newlines before and after "Disassembly of section ...:"
rLLD359668: [llvm-objdump] Print newlines before and after "Disassembly of section ...:"
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 31228 Build 31227: arc lint + arc unit
Event Timeline
This is what GNU objdump does. I don't know why llvm-objdump didn't do this in the first place..
5a64: e9 57 be ff ff jmp 18c0 <__cxa_atexit@plt> Disassembly of section .fini: 0000000000005a6c <.fini>:
Does GNU objdump print the blank line even before the first section?
It would be good to have, in one of the llvm-objdump-specific tests, a test for both this point, and more generally the blank lines before and after the section name. As far as I can tell, there is no direct testing for the before-newline in the llvm-objdump tests you've modified, except for where a very specific different feature of llvm-objdump is being tested.
lld/test/ELF/arm-tls-gd32.s | ||
---|---|---|
94 | This doesn't seem like a direct match to what was there before. What's the motivation here? | |
llvm/test/MC/X86/disassemble-zeroes.s | ||
26 | Not that I'm particularly bothered either way, but is there a reason you've removed this? |
lld/test/ELF/arm-tls-gd32.s | ||
---|---|---|
94 | GNU objdump Disassembly of section .fini: 0000000000005a6c <.fini>: 5a6c: 48 83 ec 08 sub rsp,0x8 llvm-objdump Disassembly of section .fini: 0000000000005a6c .fini: 5a6c: 48 83 ec 08 subq $8, %rsp Note that in llvm-objdump, there are two lines matching .fini:. I have to prepend the address to make the check line match the second line. Since I'm changing it, using CHECK-LABEL: improves error messages in case the address changes. | |
llvm/test/MC/X86/disassemble-zeroes.s | ||
26 | I think the .text section was not intended to check in this test. |
Add dedicated test test/tools/llvm-objdump/X86/disassemble-section-name.s
GNU objdump prints the blank line even before the first section.
This doesn't seem like a direct match to what was there before. What's the motivation here?