This is an archive of the discontinued LLVM Phabricator instance.

Differential D60158

[libc++abi] Actually set POSITION_INDEPENDENT_CODE when building shared library
ClosedPublic

Authored by sbc100 on Apr 2 2019, 3:15 PM.

Details

Reviewers
EricWF
brzycki
phosek
ldionne
Commits
rCXXA357550: [libc++abi] Actually set POSITION_INDEPENDENT_CODE when building shared library
rG1e6c93184406: [libc++abi] Actually set POSITION_INDEPENDENT_CODE when building shared library
rL357550: [libc++abi] Actually set POSITION_INDEPENDENT_CODE when building shared library
Summary

This is a bug fix from https://reviews.llvm.org/D60005.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Apr 2 2019, 3:15 PM
Herald added a reviewer: EricWF. · View Herald TranscriptApr 2 2019, 3:15 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, christof, aheejin, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B29969: Diff 193375.Apr 2 2019, 3:17 PM
sbc100 added reviewers: brzycki, phosek.Apr 2 2019, 3:17 PM
brzycki accepted this revision.Apr 2 2019, 3:51 PM

Thank you @sbc100 for the fast fix. I've verified my internal compiler builds succeed with tip + this patch.

This revision is now accepted and ready to land.Apr 2 2019, 3:51 PM
sbc100 added a reviewer: ldionne.Apr 2 2019, 5:13 PM
Herald added a subscriber: dexonsmith. · View Herald TranscriptApr 2 2019, 5:13 PM
Closed by commit rL357550: [libc++abi] Actually set POSITION_INDEPENDENT_CODE when building shared library (authored by sbc). · Explain WhyApr 2 2019, 5:27 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 2 2019, 5:27 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
libcxxabi/
trunk/
src/
4 lines

Diff 193400

libcxxabi/trunk/src/CMakeLists.txt

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines cxxabi_object_library(cxxabi_static_objects
DEFINES DEFINES
_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS
_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS
FLAGS ${CXXABI_STATIC_OBJECTS_FLAGS}) FLAGS ${CXXABI_STATIC_OBJECTS_FLAGS})
else() else()
cxxabi_object_library(cxxabi_static_objects) cxxabi_object_library(cxxabi_static_objects)
endif() endif()
cxxabi_object_library(cxxabi_shared_objects POSITION_INDEPENDENT_CODE ON) cxxabi_object_library(cxxabi_shared_objects)
set_target_properties(cxxabi_shared_objects PROPERTIES POSITION_INDEPENDENT_CODE ON)
set(cxxabi_static_sources $<TARGET_OBJECTS:cxxabi_static_objects>) set(cxxabi_static_sources $<TARGET_OBJECTS:cxxabi_static_objects>)
set(cxxabi_shared_sources $<TARGET_OBJECTS:cxxabi_shared_objects>) set(cxxabi_shared_sources $<TARGET_OBJECTS:cxxabi_shared_objects>)
# Build the shared library. # Build the shared library.
if (LIBCXXABI_ENABLE_SHARED) if (LIBCXXABI_ENABLE_SHARED)
add_library(cxxabi_shared SHARED ${cxxabi_shared_sources}) add_library(cxxabi_shared SHARED ${cxxabi_shared_sources})
if(COMMAND llvm_setup_rpath) if(COMMAND llvm_setup_rpath)
llvm_setup_rpath(cxxabi_shared) llvm_setup_rpath(cxxabi_shared)
▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines