[libc++abi] Don't set POSITION_INDEPENDENT_CODE when building static library

[sbc100]

Summary

With the current WebAssembly backend, objects build with -fPIC are not
compatible with static linking. libc++abi was (mistakenly?) adding
-fPIC to the objects it was including in a static library.

IIUC this change should also mean the static build can be more efficient
on all platforms.

[phosek]

@ldionne recently addressed this for libc++ in D59248. I already mentioned in the review that we should make the same change for libc++abi and libunwind. This would address your problem but also make libc++abi and libunwind build more aligned. I'm happy to prepare that change unless you want to do it?

[sbc100]

In D60005#1448211, @phosek wrote:

@ldionne recently addressed this for libc++ in D59248. I already mentioned in the review that we should make the same change for libc++abi and libunwind. This would address your problem but also make libc++abi and libunwind build more aligned. I'm happy to prepare that change unless you want to do it?

Sure thing please go ahead. Is there something you would different to this change? If not, any reason to land this first/now?

[phosek]

LGTM, I think it's fine to land this one in the meantime,

[pcc]

It's quite common to statically link libc++abi.a into a PIE or shared object. Doesn't this change break that scenario?

[sbc100]

In D60005#1448534, @pcc wrote:

It's quite common to statically link libc++abi.a into a PIE or shared object. Doesn't this change break that scenario?

Oh. I see. Is that true of libc++abi.a more than it is true for other libraries? Presumably that already doesn't work for libc++?

[pcc]

It applies to libc++ as well. Many Android apps contain shared objects that statically link libc++ and libc++abi, for example.

That said, I don't know how Android builds libc++ for NDK users. Maybe they aren't using CMake? @danalbert would probably know.

[danalbert]

Android maintains its own build scripts, so this won't harm us, but I think the problem in general remains. Seems like it would be better for the webasm target to opt out of the behavior than for all targets to do it (or maybe just provide an option so maintainers can choose what they want for their platform).

[jiangyi]

After this patch, libcxx failed to compile when -DLLVM_ENABLE_PIC=OFF and -DLIBCXX_ENABLE_STATIC_ABI_LIBRARY=ON.

Maybe we should add an option to set PIC of libcxxabi. Something like

option(LIBCXXABI_ENABLE_PIC "Build Position-Independent Code, which is required if LIBCXX_ENABLE_STATIC_ABI_LIBRARY is set in libcxx" ON)

and add some checks in libcxx CMakeLists.txt to fail in cmake configure step if condition does not meet.

[sbc100]

In D60005#1448955, @jiangyi wrote:

After this patch, libcxx failed to compile when -DLLVM_ENABLE_PIC=OFF and -DLIBCXX_ENABLE_STATIC_ABI_LIBRARY=ON.

Maybe we should add an option to set PIC of libcxxabi. Something like

option(LIBCXXABI_ENABLE_PIC "Build Position-Independent Code, which is required if LIBCXX_ENABLE_STATIC_ABI_LIBRARY is set in libcxx" ON)

and add some checks in libcxx CMakeLists.txt to fail in cmake configure step if condition does not meet.

That sounds like a reasonable approach: https://reviews.llvm.org/D60049

libcxxabi/trunk/src/CMakeLists.txt

set_target_properties(${name}
                         PROPERTIES
                           CXX_EXTENSIONS
                             OFF
                           CXX_STANDARD
                             11
                           CXX_STANDARD_REQUIRED
                             ON
                           COMPILE_FLAGS
-                            "${LIBCXXABI_COMPILE_FLAGS}"
-                          POSITION_INDEPENDENT_CODE
-                            ON)
+                            "${LIBCXXABI_COMPILE_FLAGS}")
 
   if(ARGS_DEFINES)
     target_compile_definitions(${name} PRIVATE ${ARGS_DEFINES})
   endif()
 
   if(ARGS_FLAGS)
     target_compile_options(${name} PRIVATE ${ARGS_FLAGS})
   endif()
 endmacro()
 
 if(LIBCXXABI_HERMETIC_STATIC_LIBRARY)
   append_flags_if_supported(CXXABI_STATIC_OBJECTS_FLAGS -fvisibility=hidden)
   append_flags_if_supported(CXXABI_STATIC_OBJECTS_FLAGS -fvisibility-global-new-delete-hidden)
   cxxabi_object_library(cxxabi_static_objects
     DEFINES
       _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS
       _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS
     FLAGS ${CXXABI_STATIC_OBJECTS_FLAGS})
-  cxxabi_object_library(cxxabi_shared_objects)
-  set(cxxabi_static_sources $<TARGET_OBJECTS:cxxabi_static_objects>)
-  set(cxxabi_shared_sources $<TARGET_OBJECTS:cxxabi_shared_objects>)
 else()
-  cxxabi_object_library(cxxabi_objects)
-  set(cxxabi_static_sources $<TARGET_OBJECTS:cxxabi_objects>)
-  set(cxxabi_shared_sources $<TARGET_OBJECTS:cxxabi_objects>)
+  cxxabi_object_library(cxxabi_static_objects)
 endif()
 
+cxxabi_object_library(cxxabi_shared_objects POSITION_INDEPENDENT_CODE ON)
+set(cxxabi_static_sources $<TARGET_OBJECTS:cxxabi_static_objects>)
+set(cxxabi_shared_sources $<TARGET_OBJECTS:cxxabi_shared_objects>)
+
 # Build the shared library.
 if (LIBCXXABI_ENABLE_SHARED)
   add_library(cxxabi_shared SHARED ${cxxabi_shared_sources})
   if(COMMAND llvm_setup_rpath)
     llvm_setup_rpath(cxxabi_shared)
   endif()
   target_link_libraries(cxxabi_shared PRIVATE ${LIBCXXABI_SHARED_LIBRARIES} ${LIBCXXABI_LIBRARIES})
   set_target_properties(cxxabi_shared
set_target_properties(cxxabi_static
                             OFF
                           CXX_STANDARD
                             11
                           CXX_STANDARD_REQUIRED
                             ON
                           LINK_FLAGS
                             "${LIBCXXABI_LINK_FLAGS}"
                           OUTPUT_NAME
-                            "c++abi"
-                          POSITION_INDEPENDENT_CODE
-                            ON)
+                            "c++abi")
   list(APPEND LIBCXXABI_BUILD_TARGETS "cxxabi_static")
   if (LIBCXXABI_INSTALL_STATIC_LIBRARY)
     list(APPEND LIBCXXABI_INSTALL_TARGETS "cxxabi_static")
   endif()
 endif()
 
 # Add a meta-target for both libraries.
 add_custom_target(cxxabi DEPENDS ${LIBCXXABI_BUILD_TARGETS})