This is an archive of the discontinued LLVM Phabricator instance.

[MC] Minor cleanup to MCFixup::Kind handling. NFC.
ClosedPublic

Authored by sbc100 on Mar 27 2019, 9:54 AM.

Details

Summary

Prefer MCFixupKind where possible and add getTargetKind() to
convert to unsigned when needed rather than scatterin cast
operators around the place.

Diff Detail

Event Timeline

sbc100 created this revision.Mar 27 2019, 9:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2019, 9:54 AM
sbc100 retitled this revision from [MC] Cleanup MCFixup::getKind to [MC] Minor cleanup to MCFixup::Kind handling. NFC..Mar 27 2019, 9:55 AM
sbc100 added a reviewer: grosbach.
sbc100 updated this revision to Diff 192464.Mar 27 2019, 9:56 AM
  • revert
sbc100 updated this revision to Diff 192467.Mar 27 2019, 9:58 AM
  • revert more
sbc100 updated this revision to Diff 192558.Mar 27 2019, 7:12 PM
  • rebase
sbc100 updated this revision to Diff 193746.Apr 4 2019, 10:44 AM
  • rebase
sbc100 updated this revision to Diff 199693.May 15 2019, 3:54 PM
  • rebase

@grosbach do you have time to take quick look? Should be fairly straight forward.

sbc100 updated this revision to Diff 216485.Aug 21 2019, 2:37 PM
  • rebase
sbc100 edited reviewers, added: dschuff; removed: grosbach.Aug 21 2019, 2:38 PM
dschuff accepted this revision.Aug 22 2019, 2:46 PM

Nice.

This revision is now accepted and ready to land.Aug 22 2019, 2:46 PM
This revision was automatically updated to reflect the committed changes.