This is an archive of the discontinued LLVM Phabricator instance.

Differential D59735

Fix gettid warnings on FreeBSD
ClosedPublic

Authored by dim on Mar 23 2019, 7:40 AM.

Details

Reviewers
emaste
jlpeyton
krytarowski
mgorny
protze.joachim
Commits
rGdab9ed87c6c5: Fix gettid warnings on FreeBSD
rL356934: Fix gettid warnings on FreeBSD
rOMP356934: Fix gettid warnings on FreeBSD
Summary

[Split off from D59451 to get this fix in separately]

While building the 8.0 releases on FreeBSD, I encountered the following
warnings in openmp quite a few times:

In file included from projects/openmp/runtime/src/kmp_settings.cpp:27:
projects/openmp/runtime/src/kmp_wrapper_getpid.h:35:2: warning: #warning is a language extension [-Wpedantic]
#warning No gettid found, use getpid instead
 ^
projects/openmp/runtime/src/kmp_wrapper_getpid.h:35:2: warning: No gettid found, use getpid instead [-W#warnings]
2 warnings generated.

I added a gettid wrapper that uses FreeBSD's pthread_getthreadid_np(3)
function for this.

Diff Detail

Repository
rOMP OpenMP

Event Timeline

dim created this revision.Mar 23 2019, 7:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2019, 7:40 AM
Herald added subscribers: jdoerfert, jfb. · View Herald Transcript
Harbormaster completed remote builds in B29532: Diff 191995.Mar 23 2019, 7:40 AM
dim mentioned this in D59451: Fix gettid warnings and one test on FreeBSD.Mar 23 2019, 7:45 AM
jlpeyton accepted this revision.Mar 25 2019, 10:32 AM

LGTM

This revision is now accepted and ready to land.Mar 25 2019, 10:32 AM
Closed by commit rOMP356934: Fix gettid warnings on FreeBSD (authored by dim). · Explain WhyMar 25 2019, 11:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
runtime/
src/
3 lines

Diff 192169

runtime/src/kmp_wrapper_getpid.h

Show All 17 Lines
// On Unix-like systems (Linux* OS and OS X*) getpid() is declared in standard // On Unix-like systems (Linux* OS and OS X*) getpid() is declared in standard
// headers. // headers.
#include <sys/syscall.h> #include <sys/syscall.h>
#include <sys/types.h> #include <sys/types.h>
#include <unistd.h> #include <unistd.h>
#if KMP_OS_DARWIN #if KMP_OS_DARWIN
// OS X // OS X
#define __kmp_gettid() syscall(SYS_thread_selfid) #define __kmp_gettid() syscall(SYS_thread_selfid)
#elif KMP_OS_FREEBSD
#include <pthread_np.h>
#define __kmp_gettid() pthread_getthreadid_np()
#elif KMP_OS_NETBSD #elif KMP_OS_NETBSD
#include <lwp.h> #include <lwp.h>
#define __kmp_gettid() _lwp_self() #define __kmp_gettid() _lwp_self()
#elif defined(SYS_gettid) #elif defined(SYS_gettid)
// Hopefully other Unix systems define SYS_gettid syscall for getting os thread // Hopefully other Unix systems define SYS_gettid syscall for getting os thread
// id // id
#define __kmp_gettid() syscall(SYS_gettid) #define __kmp_gettid() syscall(SYS_gettid)
#else #else
Show All 39 Lines