This is an archive of the discontinued LLVM Phabricator instance.

Differential D59674

This test assumes that -rtlib defaults to libgcc. But that isn't true in the face of -DCLANG_DEFAULT_RTLIB=compiler-rt.
ClosedPublic

Authored by saugustine on Mar 21 2019, 4:13 PM.

Details

Reviewers
rdhindsa
Commits
rG7642289780b3: This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
rC356724: This test assumes that -rtlib defaults to libgcc. But that isn't true in the…
rL356724: This test assumes that -rtlib defaults to libgcc. But that isn't true in the…

Diff Detail

Repository
rL LLVM

Event Timeline

saugustine created this revision.Mar 21 2019, 4:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2019, 4:13 PM
Herald added subscribers: llvm-commits, jdoerfert, dberris. · View Herald Transcript
Harbormaster completed remote builds in B29461: Diff 191793.Mar 21 2019, 4:14 PM
saugustine added a reviewer: rdhindsa.Mar 21 2019, 4:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2019, 4:29 PM
Closed by commit rL356724: This test assumes that -rtlib defaults to libgcc. But that isn't true in the… (authored by saugustine). · Explain Why
This revision was automatically updated to reflect the committed changes.
lebedev.ri added a subscriber: lebedev.ri.Mar 22 2019, 12:07 AM

Was this reviewed?

phosek added a subscriber: phosek.Mar 22 2019, 1:47 AM

Thanks a lot for the fix! Everything is back to green now.

In D59674#1438992, @lebedev.ri wrote:

Was this reviewed?

This is addressing an issue introduced by D59109 so I think it's fine to land this without a review (I'd have LGTM'ed this).

MaskRay added a subscriber: MaskRay.Mar 22 2019, 1:50 AM

It looks Phabricator doesn't have a good diff algorithm... // RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \

Revision Contents

PathSize
cfe/
trunk/
test/
Driver/
7 lines

Diff 191797

cfe/trunk/test/Driver/compiler-rt-unwind.c

// General tests that the driver handles combinations of --rtlib=XXX and // General tests that the driver handles combinations of --rtlib=XXX and
// --unwindlib=XXX properly. // --unwindlib=XXX properly.
// //
// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ // RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
// RUN: --target=x86_64-unknown-linux \
// RUN: --gcc-toolchain="" \
// RUN: | FileCheck --check-prefix=RTLIB-EMPTY %s
// RTLIB-EMPTY: "{{.*}}lgcc"
// RTLIB-EMPTY: "{{.*}}-lgcc_s"
//
// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
// RUN: --target=x86_64-unknown-linux -rtlib=libgcc \ // RUN: --target=x86_64-unknown-linux -rtlib=libgcc \
// RUN: --gcc-toolchain="" \ // RUN: --gcc-toolchain="" \
// RUN: | FileCheck --check-prefix=RTLIB-GCC %s // RUN: | FileCheck --check-prefix=RTLIB-GCC %s
// RTLIB-GCC: "{{.*}}lgcc" // RTLIB-GCC: "{{.*}}lgcc"
// RTLIB-GCC: "{{.*}}lgcc_s" // RTLIB-GCC: "{{.*}}lgcc_s"
// //
// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \ // RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
// RUN: --target=x86_64-unknown-linux -rtlib=libgcc --unwindlib=libunwind \ // RUN: --target=x86_64-unknown-linux -rtlib=libgcc --unwindlib=libunwind \
Show All 30 Lines