Page MenuHomePhabricator

rdhindsa (Rumeet Dhindsa)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2018, 1:50 PM (226 w, 5 d)

Recent Activity

Jan 4 2022

rdhindsa added a reverting change for rGdd72ae3dcc68: [clang][ObjC] Add fix it for missing methods in impl: rG37be74885946: Revert "[clang][ObjC] Add fix it for missing methods in impl".
Jan 4 2022, 4:44 PM
rdhindsa committed rG37be74885946: Revert "[clang][ObjC] Add fix it for missing methods in impl" (authored by rdhindsa).
Revert "[clang][ObjC] Add fix it for missing methods in impl"
Jan 4 2022, 4:44 PM
rdhindsa added a reverting change for D116417: [clang][ObjC] Add fix it for missing methods in impl: rG37be74885946: Revert "[clang][ObjC] Add fix it for missing methods in impl".
Jan 4 2022, 4:44 PM · Restricted Project
rdhindsa added a comment to rGdd72ae3dcc68: [clang][ObjC] Add fix it for missing methods in impl.

This patch is causing a test to fail internally. I have provided the details to the author.

Jan 4 2022, 4:13 PM

Sep 10 2021

rdhindsa added a comment to D108061: [lldb] Add support for shared library load when executable called through ld..

With this patch, it looks like the test added in this patch fails for lldb-arm-ubuntu:
https://lab.llvm.org/buildbot/#/builders/17/builds/10498

Sep 10 2021, 12:26 PM · Restricted Project
rdhindsa updated subscribers of D108061: [lldb] Add support for shared library load when executable called through ld..
Sep 10 2021, 12:16 PM · Restricted Project
rdhindsa committed rG03df97101287: [lldb] Add support for debugging via the dynamic linker. (authored by rdhindsa).
[lldb] Add support for debugging via the dynamic linker.
Sep 10 2021, 11:00 AM
rdhindsa closed D108061: [lldb] Add support for shared library load when executable called through ld..
Sep 10 2021, 11:00 AM · Restricted Project
rdhindsa added a comment to D108061: [lldb] Add support for shared library load when executable called through ld..

@teemperor: I believe I have addressed your comments. If there is any other concern, I can address it post-commit.

Sep 10 2021, 10:36 AM · Restricted Project

Sep 9 2021

rdhindsa updated the diff for D108061: [lldb] Add support for shared library load when executable called through ld..

Thanks Pavel for investigating and figuring out that the upstream failing test had libxml support disabled. I was able to reproduce the failure locally by adding -DLLDB_ENABLE_LIBXML2=False to cmake.
Updated UpdateFileSpecIfNecessary function to only update filename if the region.GetName().AsCString() is not empty, which checks for both null and empty.

Sep 9 2021, 10:19 AM · Restricted Project

Sep 8 2021

rdhindsa updated the diff for D108061: [lldb] Add support for shared library load when executable called through ld..
Sep 8 2021, 12:59 PM · Restricted Project

Sep 3 2021

rdhindsa updated the diff for D109249: [lldb] Add Getdescription function for SBInstruction..

Added LLDB_REGISTER_METHOD for GetDescription.

Sep 3 2021, 1:11 PM · Restricted Project
rdhindsa requested review of D109249: [lldb] Add Getdescription function for SBInstruction..
Sep 3 2021, 10:43 AM · Restricted Project

Sep 2 2021

rdhindsa added a comment to D108061: [lldb] Add support for shared library load when executable called through ld..

Thank you for suggestion to try!
After adding the assertions in memory region info trick, 3 testcases from only one test failed because of assertion : lldb/test/API/functionalities/load_unload/TestLoadUnload.py

Sep 2 2021, 5:09 PM · Restricted Project

Sep 1 2021

rdhindsa added a comment to D108061: [lldb] Add support for shared library load when executable called through ld..

Thank you for giving it a try! It passes for me for both Release and RelWithDebInfo along with asserts enabled in each case. I can give it a try by recommitting and checking the status, this patch is in Needs Review status presently. Hence, requesting for a review.

Sep 1 2021, 3:09 PM · Restricted Project

Aug 30 2021

rdhindsa added a comment to D108061: [lldb] Add support for shared library load when executable called through ld..

For me, this test passes every time. I have tried multiple times with instructions from failing bot, but haven't been able to reproduce the failure locally yet.

Aug 30 2021, 5:07 PM · Restricted Project

Aug 27 2021

rdhindsa updated subscribers of D108061: [lldb] Add support for shared library load when executable called through ld..
Aug 27 2021, 1:28 PM · Restricted Project

Aug 26 2021

rdhindsa added a comment to D108061: [lldb] Add support for shared library load when executable called through ld..

This patch caused a test failure when it was submitted two days ago, so I reverted it that day. However, I have not been able to reproduce the failure locally even using the cmake config from bot.

Aug 26 2021, 4:44 PM · Restricted Project
rdhindsa updated the diff for D108061: [lldb] Add support for shared library load when executable called through ld..
Aug 26 2021, 2:41 PM · Restricted Project

Aug 24 2021

rdhindsa added a reverting change for rG1cbdc07ec015: [lldb] Add support for debugging via the dynamic linker.: rG120d97b1a7a8: Revert "[lldb] Add support for debugging via the dynamic linker.".
Aug 24 2021, 3:32 PM
rdhindsa committed rG120d97b1a7a8: Revert "[lldb] Add support for debugging via the dynamic linker." (authored by rdhindsa).
Revert "[lldb] Add support for debugging via the dynamic linker."
Aug 24 2021, 3:32 PM
rdhindsa added a reverting change for D108061: [lldb] Add support for shared library load when executable called through ld.: rG120d97b1a7a8: Revert "[lldb] Add support for debugging via the dynamic linker.".
Aug 24 2021, 3:32 PM · Restricted Project
rdhindsa committed rG1cbdc07ec015: [lldb] Add support for debugging via the dynamic linker. (authored by rdhindsa).
[lldb] Add support for debugging via the dynamic linker.
Aug 24 2021, 1:42 PM
rdhindsa closed D108061: [lldb] Add support for shared library load when executable called through ld..
Aug 24 2021, 1:41 PM · Restricted Project
rdhindsa added a comment to D108061: [lldb] Add support for shared library load when executable called through ld..

Thank you for the review and suggestion to check memory region.

Aug 24 2021, 10:18 AM · Restricted Project

Aug 19 2021

rdhindsa updated the diff for D108061: [lldb] Add support for shared library load when executable called through ld..

Updated to extract executable file name using GetMemoryRegionInfo since ld.so returns empty file name for executable file name.

Aug 19 2021, 10:31 PM · Restricted Project
rdhindsa committed rGd9c5613e856c: Update logic to close inherited file descriptors. (authored by rdhindsa).
Update logic to close inherited file descriptors.
Aug 19 2021, 2:43 PM
rdhindsa closed D105732: [lldb] Update logic to close inherited file descriptors..
Aug 19 2021, 2:42 PM · Restricted Project
rdhindsa added a comment to D108061: [lldb] Add support for shared library load when executable called through ld..

Looking further as to why executable symbols are not loaded, it looks like when we read the link_map in lldb, AddSOEntries() is called for all the entries in link_map read from ld.so. The first entry's name(which corresponds to executable) is empty, which seems to be set by ld.so here (https://github.com/bminor/glibc/blob/master/elf/rtld.c#L1389). main_map at this location has the entry for respective executable, but its name is removed, hence lldb while going through entries can't read entry about main executable.

Aug 19 2021, 1:22 PM · Restricted Project

Aug 18 2021

rdhindsa updated the diff for D105732: [lldb] Update logic to close inherited file descriptors..

Updated comments as suggested.

Aug 18 2021, 12:52 PM · Restricted Project
rdhindsa added a comment to D108061: [lldb] Add support for shared library load when executable called through ld..

I checked the status with both gdb and lldb using test case added here. It looks like breakpoint on main doesn't get hit even for gdb when called through ld.so. However, breakpoint on shared library functions is supported by gdb. With this patch, we are now able to set breakpoint on functions in shared libraries as supported by gdb.

Aug 18 2021, 12:00 PM · Restricted Project
rdhindsa updated the diff for D105732: [lldb] Update logic to close inherited file descriptors..
Aug 18 2021, 11:42 AM · Restricted Project

Aug 17 2021

rdhindsa updated the diff for D105732: [lldb] Update logic to close inherited file descriptors..

Updated it to use llvm's filesystem.

Aug 17 2021, 5:19 PM · Restricted Project
rdhindsa added a comment to D108061: [lldb] Add support for shared library load when executable called through ld..

Updated the test to check for the respective function name from the shared library in the frames.
I didn't add run_to_source_breakpoint since we can't set a breakpoint on main initially before running the program. Hence it would need to be run first and then we can check later to see if the function name is available. Please let me know if you think there is any concern with this way.

Aug 17 2021, 4:03 PM · Restricted Project
rdhindsa updated the diff for D108061: [lldb] Add support for shared library load when executable called through ld..

Updated the test to check for the respective function name from the shared library in the frames.

Aug 17 2021, 4:02 PM · Restricted Project

Aug 16 2021

rdhindsa updated the diff for D108061: [lldb] Add support for shared library load when executable called through ld..

Reverted code changes from ObjectFileELF as suggested and added directly to DYLDRendezvous.cpp.

Aug 16 2021, 11:53 AM · Restricted Project

Aug 13 2021

rdhindsa requested review of D108061: [lldb] Add support for shared library load when executable called through ld..
Aug 13 2021, 4:29 PM · Restricted Project

Aug 12 2021

rdhindsa added a comment to D105732: [lldb] Update logic to close inherited file descriptors..

fork is being called in LaunchProcess function in this file(ProcessLauncherPosixFork.cpp) itself.

Aug 12 2021, 2:54 PM · Restricted Project

Aug 11 2021

rdhindsa added reviewers for D105732: [lldb] Update logic to close inherited file descriptors.: clayborg, eugene.
Aug 11 2021, 2:12 PM · Restricted Project

Jul 21 2021

rdhindsa added a comment to D105732: [lldb] Update logic to close inherited file descriptors..

Ping.

Jul 21 2021, 11:59 AM · Restricted Project

Jul 13 2021

rdhindsa updated the diff for D105732: [lldb] Update logic to close inherited file descriptors..
Jul 13 2021, 2:37 PM · Restricted Project
rdhindsa updated subscribers of D105732: [lldb] Update logic to close inherited file descriptors..
Jul 13 2021, 2:08 PM · Restricted Project

Jul 9 2021

rdhindsa requested review of D105732: [lldb] Update logic to close inherited file descriptors..
Jul 9 2021, 1:56 PM · Restricted Project

Apr 8 2021

rdhindsa abandoned D100068: [llvm-dwarfdump] Fix slowdown in dwarfdump statistics..

This change is causing a difference in 2 dwarfdump statistics for a large binary with fission=yes.

Apr 8 2021, 3:56 PM · Restricted Project
rdhindsa added a comment to D96045: [llvm-dwarfdump][locstats] Unify handling of inlined vars with no loc.

After moving the variable InlinedFnsToBeProcessed to inside the for loop, I noticed a difference in two dwarfdump statistics for a quite large binary with fission=yes:

Apr 8 2021, 3:51 PM · debug-info, Restricted Project

Apr 7 2021

rdhindsa requested review of D100068: [llvm-dwarfdump] Fix slowdown in dwarfdump statistics..
Apr 7 2021, 2:01 PM · Restricted Project

Apr 6 2021

rdhindsa added a comment to D96045: [llvm-dwarfdump][locstats] Unify handling of inlined vars with no loc.

This patch seems to be causing a slowdown while running dwarfdump --statistics. It looks like more than 50% of the time is spent in collectZeroCovInlinedVars function.

Apr 6 2021, 4:46 PM · debug-info, Restricted Project

Feb 9 2021

rdhindsa updated the diff for D96370: Pass enviroment variables to python scripts..
Feb 9 2021, 2:47 PM · Restricted Project
rdhindsa requested review of D96370: Pass enviroment variables to python scripts..
Feb 9 2021, 2:05 PM · Restricted Project

Apr 20 2020

rdhindsa committed rG9b2ab41037f4: Revert "[MS] Fix assert handling enum forward decls in hasVisibleDefinition" (authored by rdhindsa).
Revert "[MS] Fix assert handling enum forward decls in hasVisibleDefinition"
Apr 20 2020, 10:49 AM
rdhindsa added a reverting change for rGe62dc1f6252c: [MS] Fix assert handling enum forward decls in hasVisibleDefinition: rG9b2ab41037f4: Revert "[MS] Fix assert handling enum forward decls in hasVisibleDefinition".
Apr 20 2020, 10:49 AM

Mar 10 2020

rdhindsa committed rG57a2eaf3c1aa: Revert "[modules] Do not cache invalid state for modules that we attempted to… (authored by rdhindsa).
Revert "[modules] Do not cache invalid state for modules that we attempted to…
Mar 10 2020, 11:27 AM
rdhindsa added a reverting change for rG83f4c3af021c: [modules] Do not cache invalid state for modules that we attempted to load.: rG57a2eaf3c1aa: Revert "[modules] Do not cache invalid state for modules that we attempted to….
Mar 10 2020, 11:27 AM

Dec 18 2019

rdhindsa accepted D71670: Support powerpc when builing without init_array..

LGTM

Dec 18 2019, 11:36 AM · Restricted Project, Restricted Project

Dec 11 2019

rdhindsa added a reviewer for D71364: Fix no-assert ununsed variable.: echristo.
Dec 11 2019, 9:45 AM · Restricted Project
rdhindsa created D71364: Fix no-assert ununsed variable..
Dec 11 2019, 9:45 AM · Restricted Project

Dec 9 2019

rdhindsa accepted D71222: Include Stmt.h where it seems to be necessary for modules builds.

LGTM

Dec 9 2019, 1:12 PM · Restricted Project

Sep 23 2019

rdhindsa committed rG1605eb1c1cfc: Fix int to bool errors exposed due to r372612. (authored by rdhindsa).
Fix int to bool errors exposed due to r372612.
Sep 23 2019, 7:58 PM
rdhindsa committed rL372684.
Sep 23 2019, 7:58 PM
rdhindsa closed D67937: Fix int to bool errors exposed due to r372612.
Sep 23 2019, 7:58 PM · Restricted Project
rdhindsa updated the diff for D67937: Fix int to bool errors exposed due to r372612.

Removed the extra parenthesis.

Sep 23 2019, 5:01 PM · Restricted Project
rdhindsa created D67937: Fix int to bool errors exposed due to r372612.
Sep 23 2019, 3:33 PM · Restricted Project

Jun 28 2019

rdhindsa added a comment to D63905: Fix ASAN error caused by commit r364512.

@rovka : There is one more instance of similar code in function translateInvoke around line 1670. I think you will need to update that as well.

Jun 28 2019, 9:05 AM · Restricted Project

Jun 27 2019

rdhindsa committed rGddc2804e1a54: Fix ASAN error caused by commit r364512. (authored by rdhindsa).
Fix ASAN error caused by commit r364512.
Jun 27 2019, 4:38 PM
rdhindsa committed rL364611: Fix ASAN error caused by commit r364512..
Fix ASAN error caused by commit r364512.
Jun 27 2019, 4:38 PM
rdhindsa closed D63905: Fix ASAN error caused by commit r364512.
Jun 27 2019, 4:38 PM · Restricted Project
rdhindsa created D63905: Fix ASAN error caused by commit r364512.
Jun 27 2019, 4:17 PM · Restricted Project

Jun 25 2019

rdhindsa committed rG4ee933c76bf2: Revert [llvm-objcopy][NFC] Refactor output target parsing (authored by rdhindsa).
Revert [llvm-objcopy][NFC] Refactor output target parsing
Jun 25 2019, 8:03 PM
rdhindsa committed rL364379: Revert [llvm-objcopy][NFC] Refactor output target parsing.
Revert [llvm-objcopy][NFC] Refactor output target parsing
Jun 25 2019, 8:03 PM
rdhindsa committed rG4e3f00e99987: Revert [llvm-objcopy][NFCI] Fix build failure with GCC (authored by rdhindsa).
Revert [llvm-objcopy][NFCI] Fix build failure with GCC
Jun 25 2019, 7:59 PM
rdhindsa committed rL364378: Revert [llvm-objcopy][NFCI] Fix build failure with GCC.
Revert [llvm-objcopy][NFCI] Fix build failure with GCC
Jun 25 2019, 7:59 PM
rdhindsa committed rGa1d688dfdd02: Revert Devirtualize destructor of final class. (authored by rdhindsa).
Revert Devirtualize destructor of final class.
Jun 25 2019, 3:59 PM
rdhindsa committed rL364359: Revert Devirtualize destructor of final class..
Revert Devirtualize destructor of final class.
Jun 25 2019, 3:59 PM

Mar 28 2019

rdhindsa committed rGda063e64ebc9: Update lit config for ld.lld command to match "ld\.lld" instead of trying to… (authored by rdhindsa).
Update lit config for ld.lld command to match "ld\.lld" instead of trying to…
Mar 28 2019, 3:26 PM
rdhindsa committed rL357218: Update lit config for ld.lld command to match "ld\.lld" instead of trying to….
Update lit config for ld.lld command to match "ld\.lld" instead of trying to…
Mar 28 2019, 3:25 PM
rdhindsa committed rG45bd9b2567db: Fixed the lld test using ld-lld command to use ld.lld instead. (authored by rdhindsa).
Fixed the lld test using ld-lld command to use ld.lld instead.
Mar 28 2019, 3:15 PM
rdhindsa committed rLLD357216: Fixed the lld test using ld-lld command to use ld.lld instead..
Fixed the lld test using ld-lld command to use ld.lld instead.
Mar 28 2019, 3:15 PM
rdhindsa committed rL357216: Fixed the lld test using ld-lld command to use ld.lld instead..
Fixed the lld test using ld-lld command to use ld.lld instead.
Mar 28 2019, 3:15 PM
rdhindsa closed D59962: Update lit config for ld.lld command.
Mar 28 2019, 3:15 PM · Restricted Project
rdhindsa added a comment to D59962: Update lit config for ld.lld command.

Thanks for the review! I will check them in as two separate commits.

Mar 28 2019, 3:01 PM · Restricted Project
rdhindsa created D59962: Update lit config for ld.lld command.
Mar 28 2019, 2:50 PM · Restricted Project

Oct 3 2018

rdhindsa added inline comments to D49795: [PPC64] Position-independent long-branch thunks..
Oct 3 2018, 12:09 PM

Sep 19 2018

rdhindsa added a comment to rL342597: [New PM] Introducing PassInstrumentation framework.

Confirmed that reverting the change locally fixes the test. Could you please take a look.

Sep 19 2018, 5:14 PM
rdhindsa added a comment to rL342597: [New PM] Introducing PassInstrumentation framework.

It seems that following test is broken with this change: llvm/unittests/IR/PassBuilderCallbacksTest.cpp

Sep 19 2018, 4:49 PM
rdhindsa added a comment to rL342576: Copy utilities updated and added for MI flags.

Thanks for the fix!

Sep 19 2018, 4:01 PM
rdhindsa added a comment to rL342576: Copy utilities updated and added for MI flags.

It seems that following test is broken with this change: DebugInfo/WebAssembly/dbg-value-live-interval.ll
Confirmed that reverting the change locally fixes the tests. Could you please take a look.

Sep 19 2018, 2:29 PM
rdhindsa added a comment to D52006: Copy utilities updated and added for MI flags.

It seems that following test is broken with this change: DebugInfo/WebAssembly/dbg-value-live-interval.ll
Confirmed that reverting the change locally fixes the tests. Could you please take a look.

Sep 19 2018, 1:25 PM

Sep 18 2018

rdhindsa added a comment to D52191: Fix logic around determining use of frame pointer with -pg..

It seems that following tests are broken with this change:

Sep 18 2018, 1:01 PM

Jul 31 2018

rdhindsa committed rL338445: Allow oformat to accept format starting with elf as acceptable format..
Allow oformat to accept format starting with elf as acceptable format.
Jul 31 2018, 2:59 PM
rdhindsa committed rLLD338445: Allow oformat to accept format starting with elf as acceptable format..
Allow oformat to accept format starting with elf as acceptable format.
Jul 31 2018, 2:59 PM
rdhindsa closed D50105: Allow oformat option to accept elf format.
Jul 31 2018, 2:58 PM
rdhindsa updated the diff for D50105: Allow oformat option to accept elf format.
Jul 31 2018, 2:44 PM
rdhindsa created D50105: Allow oformat option to accept elf format.
Jul 31 2018, 2:34 PM

Jun 19 2018

rdhindsa added a comment to rL335063: [Darwin] Add a warning for missing include path for libstdc++.

I just saw that the change is reverted already. Thanks!

Jun 19 2018, 1:47 PM
rdhindsa added a comment to rL335063: [Darwin] Add a warning for missing include path for libstdc++.

It seems that this change causes two clang tests to fail since they didn't expect this warning.

Jun 19 2018, 1:41 PM

Jun 14 2018

rdhindsa accepted D48153: Add TARGET(foo) linker script directive..

LGTM

Jun 14 2018, 11:15 AM

Jun 13 2018

rdhindsa added inline comments to D48153: Add TARGET(foo) linker script directive..
Jun 13 2018, 2:54 PM

Jun 8 2018

rdhindsa added a comment to D44909: [DAGCombine] (float)((int) f) --> ftrunc (PR36617).

What is the expected behavior for casting float values in range (-1.0 , 0.0) from float->int->float? If the expected value is -0.0 (instead of 0.0), what is the reason for that?

Jun 8 2018, 3:06 PM

May 24 2018

rdhindsa accepted D47324: Add llvm-bcanalyzer as an LLD test dependency.

LGTM

May 24 2018, 10:58 AM · Restricted Project

May 16 2018

rdhindsa committed rLLD332527: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
Add support for ThinLTO plugin option thinlto-object-suffix-replace
May 16 2018, 2:09 PM