User Details
User Details
- User Since
- Feb 28 2018, 1:50 PM (133 w, 3 d)
Apr 20 2020
Apr 20 2020
rdhindsa committed rG9b2ab41037f4: Revert "[MS] Fix assert handling enum forward decls in hasVisibleDefinition" (authored by rdhindsa).
Revert "[MS] Fix assert handling enum forward decls in hasVisibleDefinition"
Mar 10 2020
Mar 10 2020
rdhindsa committed rG57a2eaf3c1aa: Revert "[modules] Do not cache invalid state for modules that we attempted to… (authored by rdhindsa).
Revert "[modules] Do not cache invalid state for modules that we attempted to…
Dec 18 2019
Dec 18 2019
LGTM
Dec 11 2019
Dec 11 2019
Dec 11 2019, 9:45 AM · Restricted Project
Dec 11 2019, 9:45 AM · Restricted Project
Dec 9 2019
Dec 9 2019
LGTM
Dec 9 2019, 1:12 PM · Restricted Project
Sep 23 2019
Sep 23 2019
rdhindsa committed rG1605eb1c1cfc: Fix int to bool errors exposed due to r372612. (authored by rdhindsa).
Fix int to bool errors exposed due to r372612.
Sep 23 2019, 7:58 PM · Restricted Project
rdhindsa updated the diff for D67937: Fix int to bool errors exposed due to r372612.
Removed the extra parenthesis.
Sep 23 2019, 5:01 PM · Restricted Project
Sep 23 2019, 3:33 PM · Restricted Project
Jun 28 2019
Jun 28 2019
rdhindsa added a comment to D63905: Fix ASAN error caused by commit r364512.
@rovka : There is one more instance of similar code in function translateInvoke around line 1670. I think you will need to update that as well.
Jun 28 2019, 9:05 AM · Restricted Project
Jun 27 2019
Jun 27 2019
Fix ASAN error caused by commit r364512.
Fix ASAN error caused by commit r364512.
Jun 27 2019, 4:38 PM · Restricted Project
Jun 27 2019, 4:17 PM · Restricted Project
Jun 25 2019
Jun 25 2019
rdhindsa committed rG4ee933c76bf2: Revert [llvm-objcopy][NFC] Refactor output target parsing (authored by rdhindsa).
Revert [llvm-objcopy][NFC] Refactor output target parsing
Revert [llvm-objcopy][NFC] Refactor output target parsing
rdhindsa committed rG4e3f00e99987: Revert [llvm-objcopy][NFCI] Fix build failure with GCC (authored by rdhindsa).
Revert [llvm-objcopy][NFCI] Fix build failure with GCC
Revert [llvm-objcopy][NFCI] Fix build failure with GCC
rdhindsa committed rGa1d688dfdd02: Revert Devirtualize destructor of final class. (authored by rdhindsa).
Revert Devirtualize destructor of final class.
Revert Devirtualize destructor of final class.
Mar 28 2019
Mar 28 2019
rdhindsa committed rGda063e64ebc9: Update lit config for ld.lld command to match "ld\.lld" instead of trying to… (authored by rdhindsa).
Update lit config for ld.lld command to match "ld\.lld" instead of trying to…
rdhindsa committed rL357218: Update lit config for ld.lld command to match "ld\.lld" instead of trying to….
Update lit config for ld.lld command to match "ld\.lld" instead of trying to…
rdhindsa committed rG45bd9b2567db: Fixed the lld test using ld-lld command to use ld.lld instead. (authored by rdhindsa).
Fixed the lld test using ld-lld command to use ld.lld instead.
Fixed the lld test using ld-lld command to use ld.lld instead.
Fixed the lld test using ld-lld command to use ld.lld instead.
Mar 28 2019, 3:15 PM · Restricted Project
rdhindsa added a comment to D59962: Update lit config for ld.lld command.
Thanks for the review! I will check them in as two separate commits.
Mar 28 2019, 3:01 PM · Restricted Project
Mar 28 2019, 2:50 PM · Restricted Project
Oct 3 2018
Oct 3 2018
rdhindsa added inline comments to D49795: [PPC64] Position-independent long-branch thunks..
Sep 19 2018
Sep 19 2018
rdhindsa added a comment to rL342597: [New PM] Introducing PassInstrumentation framework.
Confirmed that reverting the change locally fixes the test. Could you please take a look.
rdhindsa added a comment to rL342597: [New PM] Introducing PassInstrumentation framework.
It seems that following test is broken with this change: llvm/unittests/IR/PassBuilderCallbacksTest.cpp
rdhindsa added a comment to rL342576: Copy utilities updated and added for MI flags.
Thanks for the fix!
rdhindsa added a comment to rL342576: Copy utilities updated and added for MI flags.
It seems that following test is broken with this change: DebugInfo/WebAssembly/dbg-value-live-interval.ll
Confirmed that reverting the change locally fixes the tests. Could you please take a look.
rdhindsa added a comment to D52006: Copy utilities updated and added for MI flags.
It seems that following test is broken with this change: DebugInfo/WebAssembly/dbg-value-live-interval.ll
Confirmed that reverting the change locally fixes the tests. Could you please take a look.
Sep 18 2018
Sep 18 2018
rdhindsa added a comment to D52191: Fix logic around determining use of frame pointer with -pg..
It seems that following tests are broken with this change:
Jul 31 2018
Jul 31 2018
rdhindsa committed rL338445: Allow oformat to accept format starting with elf as acceptable format..
Allow oformat to accept format starting with elf as acceptable format.
rdhindsa committed rLLD338445: Allow oformat to accept format starting with elf as acceptable format..
Allow oformat to accept format starting with elf as acceptable format.
rdhindsa updated the diff for D50105: Allow oformat option to accept elf format.
Jun 19 2018
Jun 19 2018
rdhindsa added a comment to rL335063: [Darwin] Add a warning for missing include path for libstdc++.
I just saw that the change is reverted already. Thanks!
rdhindsa added a comment to rL335063: [Darwin] Add a warning for missing include path for libstdc++.
It seems that this change causes two clang tests to fail since they didn't expect this warning.
Jun 14 2018
Jun 14 2018
Jun 13 2018
Jun 13 2018
rdhindsa added inline comments to D48153: Add TARGET(foo) linker script directive..
Jun 8 2018
Jun 8 2018
rdhindsa added a comment to D44909: [DAGCombine] (float)((int) f) --> ftrunc (PR36617).
What is the expected behavior for casting float values in range (-1.0 , 0.0) from float->int->float? If the expected value is -0.0 (instead of 0.0), what is the reason for that?
May 24 2018
May 24 2018
LGTM
May 24 2018, 10:58 AM · Restricted Project
May 16 2018
May 16 2018
Add support for ThinLTO plugin option thinlto-object-suffix-replace
Add support for ThinLTO plugin option thinlto-object-suffix-replace
rdhindsa added inline comments to D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
rdhindsa updated the diff for D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
May 11 2018
May 11 2018
rdhindsa updated the diff for D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
rdhindsa committed rL332139: Update input file in test.
Update input file in test
rdhindsa committed rLLD332139: Update input file in test.
Update input file in test
Update test to not check for output file
Update test to not check for output file
Splitting thinlto.ll test file and renaming other test files.
Splitting thinlto.ll test file and renaming other test files.
rdhindsa updated the diff for D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
rdhindsa updated the diff for D46731: Splitting thinlto.ll test file and renaming other test files..
May 10 2018
May 10 2018
rdhindsa updated the diff for D46731: Splitting thinlto.ll test file and renaming other test files..
May 9 2018
May 9 2018
rdhindsa added inline comments to D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
rdhindsa updated the diff for D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
rdhindsa updated the diff for D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
Updated the summary for option description.
May 8 2018
May 8 2018
Add support for LTO plugin option obj-path
Add support for LTO plugin option obj-path
rdhindsa updated the diff for D46598: Add support for LTO plugin option obj-path.
Removed the test which ensured that regular LTO file was written with index only option. It needs to have obj-path option to write that file.
rdhindsa added inline comments to D46598: Add support for LTO plugin option obj-path.
rdhindsa updated the diff for D46598: Add support for LTO plugin option obj-path.
Update ThinLTO Indexing logic
rdhindsa committed rL331803: Update ThinLTO Indexing logic.
Update ThinLTO Indexing logic
rdhindsa updated the diff for D46480: Update ThinLTO Indexing logic.
May 7 2018
May 7 2018
rdhindsa added a comment to D46559: Do not instantiate ObjectFiles when we exit immediately..
This change is already in https://reviews.llvm.org/D46480. I am rebasing it.
LGTM
rdhindsa committed rL331696: Add support for thinlto option ( thinlto-emit-imports-files) to emit import….
Add support for thinlto option ( thinlto-emit-imports-files) to emit import…
rdhindsa committed rLLD331696: Add support for thinlto option ( thinlto-emit-imports-files) to emit import….
Add support for thinlto option ( thinlto-emit-imports-files) to emit import…
rdhindsa updated the diff for D46400: Add support for thinlto option to emit import files for thinlink.
rdhindsa updated the diff for D46400: Add support for thinlto option to emit import files for thinlink.
Rebased the diff
LGTM
rdhindsa updated the diff for D46400: Add support for thinlto option to emit import files for thinlink.
Rebased diff
rdhindsa committed rL331671: Add test to ensure lld writes linked files to linked objects file for ThinLTO….
Add test to ensure lld writes linked files to linked objects file for ThinLTO…
rdhindsa committed rLLD331671: Add test to ensure lld writes linked files to linked objects file for ThinLTO….
Add test to ensure lld writes linked files to linked objects file for ThinLTO…