Page MenuHomePhabricator

rdhindsa (Rumeet Dhindsa)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2018, 1:50 PM (80 w, 6 d)

Recent Activity

Jun 28 2019

rdhindsa added a comment to D63905: Fix ASAN error caused by commit r364512.

@rovka : There is one more instance of similar code in function translateInvoke around line 1670. I think you will need to update that as well.

Jun 28 2019, 9:05 AM · Restricted Project

Jun 27 2019

rdhindsa committed rGddc2804e1a54: Fix ASAN error caused by commit r364512. (authored by rdhindsa).
Fix ASAN error caused by commit r364512.
Jun 27 2019, 4:38 PM
rdhindsa committed rL364611: Fix ASAN error caused by commit r364512..
Fix ASAN error caused by commit r364512.
Jun 27 2019, 4:38 PM
rdhindsa closed D63905: Fix ASAN error caused by commit r364512.
Jun 27 2019, 4:38 PM · Restricted Project
rdhindsa created D63905: Fix ASAN error caused by commit r364512.
Jun 27 2019, 4:17 PM · Restricted Project

Jun 25 2019

rdhindsa committed rG4ee933c76bf2: Revert [llvm-objcopy][NFC] Refactor output target parsing (authored by rdhindsa).
Revert [llvm-objcopy][NFC] Refactor output target parsing
Jun 25 2019, 8:03 PM
rdhindsa committed rL364379: Revert [llvm-objcopy][NFC] Refactor output target parsing.
Revert [llvm-objcopy][NFC] Refactor output target parsing
Jun 25 2019, 8:03 PM
rdhindsa committed rG4e3f00e99987: Revert [llvm-objcopy][NFCI] Fix build failure with GCC (authored by rdhindsa).
Revert [llvm-objcopy][NFCI] Fix build failure with GCC
Jun 25 2019, 7:59 PM
rdhindsa committed rL364378: Revert [llvm-objcopy][NFCI] Fix build failure with GCC.
Revert [llvm-objcopy][NFCI] Fix build failure with GCC
Jun 25 2019, 7:59 PM
rdhindsa committed rGa1d688dfdd02: Revert Devirtualize destructor of final class. (authored by rdhindsa).
Revert Devirtualize destructor of final class.
Jun 25 2019, 3:59 PM
rdhindsa committed rL364359: Revert Devirtualize destructor of final class..
Revert Devirtualize destructor of final class.
Jun 25 2019, 3:59 PM

Mar 28 2019

rdhindsa committed rGda063e64ebc9: Update lit config for ld.lld command to match "ld\.lld" instead of trying to… (authored by rdhindsa).
Update lit config for ld.lld command to match "ld\.lld" instead of trying to…
Mar 28 2019, 3:26 PM
rdhindsa committed rL357218: Update lit config for ld.lld command to match "ld\.lld" instead of trying to….
Update lit config for ld.lld command to match "ld\.lld" instead of trying to…
Mar 28 2019, 3:25 PM
rdhindsa committed rG45bd9b2567db: Fixed the lld test using ld-lld command to use ld.lld instead. (authored by rdhindsa).
Fixed the lld test using ld-lld command to use ld.lld instead.
Mar 28 2019, 3:15 PM
rdhindsa committed rLLD357216: Fixed the lld test using ld-lld command to use ld.lld instead..
Fixed the lld test using ld-lld command to use ld.lld instead.
Mar 28 2019, 3:15 PM
rdhindsa committed rL357216: Fixed the lld test using ld-lld command to use ld.lld instead..
Fixed the lld test using ld-lld command to use ld.lld instead.
Mar 28 2019, 3:15 PM
rdhindsa closed D59962: Update lit config for ld.lld command.
Mar 28 2019, 3:15 PM · Restricted Project
rdhindsa added a comment to D59962: Update lit config for ld.lld command.

Thanks for the review! I will check them in as two separate commits.

Mar 28 2019, 3:01 PM · Restricted Project
rdhindsa created D59962: Update lit config for ld.lld command.
Mar 28 2019, 2:50 PM · Restricted Project

Oct 3 2018

rdhindsa added inline comments to D49795: [PPC64] Position-independent long-branch thunks..
Oct 3 2018, 12:09 PM

Sep 19 2018

rdhindsa added a comment to rL342597: [New PM] Introducing PassInstrumentation framework.

Confirmed that reverting the change locally fixes the test. Could you please take a look.

Sep 19 2018, 5:14 PM
rdhindsa added a comment to rL342597: [New PM] Introducing PassInstrumentation framework.

It seems that following test is broken with this change: llvm/unittests/IR/PassBuilderCallbacksTest.cpp

Sep 19 2018, 4:49 PM
rdhindsa added a comment to rL342576: Copy utilities updated and added for MI flags.

Thanks for the fix!

Sep 19 2018, 4:01 PM
rdhindsa added a comment to rL342576: Copy utilities updated and added for MI flags.

It seems that following test is broken with this change: DebugInfo/WebAssembly/dbg-value-live-interval.ll
Confirmed that reverting the change locally fixes the tests. Could you please take a look.

Sep 19 2018, 2:29 PM
rdhindsa added a comment to D52006: Copy utilities updated and added for MI flags.

It seems that following test is broken with this change: DebugInfo/WebAssembly/dbg-value-live-interval.ll
Confirmed that reverting the change locally fixes the tests. Could you please take a look.

Sep 19 2018, 1:25 PM

Sep 18 2018

rdhindsa added a comment to D52191: Fix logic around determining use of frame pointer with -pg..

It seems that following tests are broken with this change:

Sep 18 2018, 1:01 PM

Jul 31 2018

rdhindsa committed rL338445: Allow oformat to accept format starting with elf as acceptable format..
Allow oformat to accept format starting with elf as acceptable format.
Jul 31 2018, 2:59 PM
rdhindsa committed rLLD338445: Allow oformat to accept format starting with elf as acceptable format..
Allow oformat to accept format starting with elf as acceptable format.
Jul 31 2018, 2:59 PM
rdhindsa closed D50105: Allow oformat option to accept elf format.
Jul 31 2018, 2:58 PM
rdhindsa updated the diff for D50105: Allow oformat option to accept elf format.
Jul 31 2018, 2:44 PM
rdhindsa created D50105: Allow oformat option to accept elf format.
Jul 31 2018, 2:34 PM

Jun 19 2018

rdhindsa added a comment to rL335063: [Darwin] Add a warning for missing include path for libstdc++.

I just saw that the change is reverted already. Thanks!

Jun 19 2018, 1:47 PM
rdhindsa added a comment to rL335063: [Darwin] Add a warning for missing include path for libstdc++.

It seems that this change causes two clang tests to fail since they didn't expect this warning.

Jun 19 2018, 1:41 PM

Jun 14 2018

rdhindsa accepted D48153: Add TARGET(foo) linker script directive..

LGTM

Jun 14 2018, 11:15 AM

Jun 13 2018

rdhindsa added inline comments to D48153: Add TARGET(foo) linker script directive..
Jun 13 2018, 2:54 PM

Jun 8 2018

rdhindsa added a comment to D44909: [DAGCombine] (float)((int) f) --> ftrunc (PR36617).

What is the expected behavior for casting float values in range (-1.0 , 0.0) from float->int->float? If the expected value is -0.0 (instead of 0.0), what is the reason for that?

Jun 8 2018, 3:06 PM

May 24 2018

rdhindsa accepted D47324: Add llvm-bcanalyzer as an LLD test dependency.

LGTM

May 24 2018, 10:58 AM

May 16 2018

rdhindsa committed rLLD332527: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
Add support for ThinLTO plugin option thinlto-object-suffix-replace
May 16 2018, 2:09 PM
rdhindsa committed rL332527: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
Add support for ThinLTO plugin option thinlto-object-suffix-replace
May 16 2018, 2:08 PM
rdhindsa closed D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
May 16 2018, 2:08 PM
rdhindsa added inline comments to D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
May 16 2018, 12:59 PM
rdhindsa updated the diff for D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
May 16 2018, 12:56 PM

May 11 2018

rdhindsa updated the diff for D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
May 11 2018, 2:04 PM
rdhindsa committed rL332139: Update input file in test.
Update input file in test
May 11 2018, 1:54 PM
rdhindsa committed rLLD332139: Update input file in test.
Update input file in test
May 11 2018, 1:54 PM
rdhindsa committed rL332134: Update test to not check for output file.
Update test to not check for output file
May 11 2018, 1:32 PM
rdhindsa committed rLLD332134: Update test to not check for output file.
Update test to not check for output file
May 11 2018, 1:32 PM
rdhindsa closed D46771: Update test to not check for output file.
May 11 2018, 1:32 PM
rdhindsa created D46771: Update test to not check for output file.
May 11 2018, 1:27 PM
rdhindsa committed rL332128: Splitting thinlto.ll test file and renaming other test files..
Splitting thinlto.ll test file and renaming other test files.
May 11 2018, 12:41 PM
rdhindsa committed rLLD332128: Splitting thinlto.ll test file and renaming other test files..
Splitting thinlto.ll test file and renaming other test files.
May 11 2018, 12:40 PM
rdhindsa closed D46731: Splitting thinlto.ll test file and renaming other test files..
May 11 2018, 12:40 PM
rdhindsa updated the diff for D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
May 11 2018, 12:30 PM
rdhindsa updated the diff for D46731: Splitting thinlto.ll test file and renaming other test files..
May 11 2018, 10:32 AM

May 10 2018

rdhindsa updated the diff for D46731: Splitting thinlto.ll test file and renaming other test files..
May 10 2018, 4:07 PM
rdhindsa created D46731: Splitting thinlto.ll test file and renaming other test files..
May 10 2018, 3:44 PM
rdhindsa created D46720: Refactoring BitcodeFile constructor. NFC..
May 10 2018, 1:04 PM

May 9 2018

rdhindsa added inline comments to D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
May 9 2018, 1:32 PM
rdhindsa updated the diff for D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
May 9 2018, 12:35 PM
rdhindsa updated the diff for D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.

Updated the summary for option description.

May 9 2018, 12:34 PM

May 8 2018

rdhindsa committed rL331817: Add support for LTO plugin option obj-path.
Add support for LTO plugin option obj-path
May 8 2018, 3:41 PM
rdhindsa committed rLLD331817: Add support for LTO plugin option obj-path.
Add support for LTO plugin option obj-path
May 8 2018, 3:41 PM
rdhindsa closed D46598: Add support for LTO plugin option obj-path.
May 8 2018, 3:41 PM
rdhindsa created D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace.
May 8 2018, 3:25 PM
rdhindsa updated the diff for D46598: Add support for LTO plugin option obj-path.

Removed the test which ensured that regular LTO file was written with index only option. It needs to have obj-path option to write that file.

May 8 2018, 2:37 PM
rdhindsa added inline comments to D46598: Add support for LTO plugin option obj-path.
May 8 2018, 2:09 PM
rdhindsa updated the diff for D46598: Add support for LTO plugin option obj-path.
May 8 2018, 1:59 PM
rdhindsa created D46598: Add support for LTO plugin option obj-path.
May 8 2018, 1:36 PM
rdhindsa committed rLLD331803: Update ThinLTO Indexing logic.
Update ThinLTO Indexing logic
May 8 2018, 1:15 PM
rdhindsa committed rL331803: Update ThinLTO Indexing logic.
Update ThinLTO Indexing logic
May 8 2018, 1:15 PM
rdhindsa closed D46480: Update ThinLTO Indexing logic.
May 8 2018, 1:15 PM
rdhindsa added a comment to D46480: Update ThinLTO Indexing logic.

Rebased diff.

May 8 2018, 12:04 PM
rdhindsa updated the diff for D46480: Update ThinLTO Indexing logic.
May 8 2018, 12:00 PM

May 7 2018

rdhindsa added a comment to D46559: Do not instantiate ObjectFiles when we exit immediately..

This change is already in https://reviews.llvm.org/D46480. I am rebasing it.

May 7 2018, 4:37 PM
rdhindsa accepted D46554: Split BitcodeCompiler::init() into two functions. NFC..

LGTM

May 7 2018, 4:22 PM
rdhindsa committed rL331696: Add support for thinlto option ( thinlto-emit-imports-files) to emit import….
Add support for thinlto option ( thinlto-emit-imports-files) to emit import…
May 7 2018, 4:17 PM
rdhindsa committed rLLD331696: Add support for thinlto option ( thinlto-emit-imports-files) to emit import….
Add support for thinlto option ( thinlto-emit-imports-files) to emit import…
May 7 2018, 4:17 PM
rdhindsa closed D46400: Add support for thinlto option to emit import files for thinlink.
May 7 2018, 4:17 PM
rdhindsa updated the diff for D46400: Add support for thinlto option to emit import files for thinlink.
May 7 2018, 4:13 PM
rdhindsa updated the diff for D46400: Add support for thinlto option to emit import files for thinlink.

Rebased the diff

May 7 2018, 3:50 PM
rdhindsa accepted D46549: Refactor ThinLTO-related code in BitcodeCompiler.cpp. NFC..

LGTM

May 7 2018, 3:11 PM
rdhindsa updated the diff for D46400: Add support for thinlto option to emit import files for thinlink.

Rebased diff

May 7 2018, 3:01 PM
rdhindsa committed rL331671: Add test to ensure lld writes linked files to linked objects file for ThinLTO….
Add test to ensure lld writes linked files to linked objects file for ThinLTO…
May 7 2018, 1:32 PM
rdhindsa committed rLLD331671: Add test to ensure lld writes linked files to linked objects file for ThinLTO….
Add test to ensure lld writes linked files to linked objects file for ThinLTO…
May 7 2018, 1:32 PM
rdhindsa closed D46542: Add test case for Thinlto Linked Objects file.
May 7 2018, 1:32 PM
rdhindsa closed D46542: Add test case for Thinlto Linked Objects file.
May 7 2018, 1:32 PM
rdhindsa created D46542: Add test case for Thinlto Linked Objects file.
May 7 2018, 12:06 PM
rdhindsa added inline comments to D46480: Update ThinLTO Indexing logic.
May 7 2018, 11:40 AM
rdhindsa updated the diff for D46480: Update ThinLTO Indexing logic.
May 7 2018, 11:38 AM

May 4 2018

rdhindsa created D46480: Update ThinLTO Indexing logic.
May 4 2018, 3:33 PM
rdhindsa added a comment to D46442: Do not call exit() directly from lld..

If we use return (instead of exit) as in this patch, the final params file( Config->ThinLTOIndexOnlyObjectsFile) is not fully generated and few of the last entries are not written(even though respective files are generated) . Here _exit() is called eventually from exitLld function call in elf::link . However, if we replace that with exit(), the file is generated properly. From here, it seems that _exit() is not able to close the file properly.

May 4 2018, 2:03 PM
rdhindsa added a comment to D46400: Add support for thinlto option to emit import files for thinlink.

I will be sending another patch to address tejohnson's concerns. I think, in the meantime, we can add emit-imports option support. Or would you like me to send that patch first?

May 4 2018, 1:25 PM
rdhindsa added a comment to D46034: Support for distributed ThinLTO options.

I will send out a patch to address both concerns. Thank you for reviewing.

May 4 2018, 10:26 AM

May 3 2018

rdhindsa added a comment to D46400: Add support for thinlto option to emit import files for thinlink.

I need to make similar change while creating empty index files, along with updating the description in test for it. I will add that change in next patch if that is okay.

May 3 2018, 2:44 PM
rdhindsa updated the diff for D46400: Add support for thinlto option to emit import files for thinlink.

Added createEmptyFile function to create empty import files. Also updated the test with error description.

May 3 2018, 2:41 PM
rdhindsa updated the diff for D46400: Add support for thinlto option to emit import files for thinlink.

Added test to ensure that lld doesn't generate import files when thinlto-index-only is not enabled

May 3 2018, 1:25 PM
rdhindsa committed rL331478: Added ThinLTO test to verify that index files are not generated if thinlto….
Added ThinLTO test to verify that index files are not generated if thinlto…
May 3 2018, 1:18 PM
rdhindsa committed rLLD331478: Added ThinLTO test to verify that index files are not generated if thinlto….
Added ThinLTO test to verify that index files are not generated if thinlto…
May 3 2018, 1:18 PM
rdhindsa closed D46405: Add thinlto test .
May 3 2018, 1:18 PM
rdhindsa created D46405: Add thinlto test .
May 3 2018, 12:59 PM