Page MenuHomePhabricator

[AMDGPU] Asm/disasm clamp modifier on vop3 int arithmetic
ClosedPublic

Authored by tpr on Mar 12 2019, 10:35 AM.

Details

Summary

Allow the clamp modifier on vop3 int arithmetic instructions in assembly
and disassembly.

This involved adding a clamp operand to the affected instructions in MIR
and MC, and thus having to fix up several places in codegen and MIR
tests.

Change-Id: Ic7775105f02a985b668fa658a0cd7837846a534e

Diff Detail

Repository
rL LLVM

Event Timeline

tpr created this revision.Mar 12 2019, 10:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2019, 10:35 AM
arsenm added inline comments.Mar 12 2019, 10:39 AM
lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
882 ↗(On Diff #190292)

Needs a comment for what this is

960 ↗(On Diff #190292)

Ditto

tpr updated this revision to Diff 190333.Mar 12 2019, 2:03 PM

V2: Addressed review comment: Commented extra clamp bit operands.

tpr marked 2 inline comments as done.Mar 12 2019, 2:05 PM
This revision is now accepted and ready to land.Mar 14 2019, 10:07 AM
This revision was automatically updated to reflect the committed changes.