Page MenuHomePhabricator

Order File Instrumentation: add clang support for -forder-file-instrumentation
ClosedPublic

Authored by manmanren on Feb 27 2019, 5:27 PM.

Details

Summary

When -forder-file-instrumentation is on, we pass llvm flag to enable the order file instrumentation pass.

Diff Detail

Event Timeline

manmanren created this revision.Feb 27 2019, 5:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 27 2019, 5:27 PM
modocache accepted this revision.Mar 4 2019, 10:06 AM
modocache added a subscriber: modocache.

Looks good, thanks for adding a driver option for this!

include/clang/Driver/Options.td
774

Would it make sense to add documentation to the Clang User's Manual for this option? Some other profiling options are mentioned there, but not all.

This revision is now accepted and ready to land.Mar 4 2019, 10:06 AM
smeenai added inline comments.
lib/Driver/ToolChains/Clang.cpp
5312

What about full LTO?

test/Driver/clang_f_opts.c
137

Can you add a test for not passing this for the ThinLTO case?

manmanren marked 3 inline comments as done.Mar 4 2019, 12:30 PM
manmanren added inline comments.
include/clang/Driver/Options.td
774

Will do this in a followup!

manmanren closed this revision.Mar 4 2019, 2:34 PM

r355333