The text was written mostly by Sam McCall, screenshots are mostly made
by me.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Still looking at it, a few quick notes.
Also added ioeric for an extra pair of eyes (it's a large change!).
clang-tools-extra/docs/clangd/Installation.rst | ||
---|---|---|
360 ↗ | (On Diff #188513) | I'd avoid mentioning it at all, we didn't vet it for the 8 release (and I believe we landed critical fixes after the release cut). |
clang-tools-extra/docs/clangd/index.rst | ||
20 ↗ | (On Diff #188513) | The original "clangd is a language server" looked somewhat better. |
clang-tools-extra/docs/clangd/Installation.rst | ||
---|---|---|
360 ↗ | (On Diff #188513) | Removed in this patch (that I plan to cherry-pick into the 8.0 release branch). Will re-add in a separate patch, so that it goes into 9.0. |
clang-tools-extra/docs/clangd/index.rst | ||
20 ↗ | (On Diff #188513) | Reworded to add the phrase "language server". |
clang-tools-extra/docs/clangd/Installation.rst | ||
---|---|---|
360 ↗ | (On Diff #188513) | Reverted back after offline discussion. |
clang-tools-extra/docs/clangd/Features.rst | ||
---|---|---|
41 ↗ | (On Diff #188531) | It feels wrong to have announcements of the 9.0 features in the 8.0 release. |
It feels we have two groups of docs here, do you think it would be useful to split them more explicitly?
Specifically, we have:
- User documentation
- Getting started with clangd
- Features
- Developer documentation
- Protocol extensions
- Compiling clangd
- Contributing to clangd
And the split is somewhat implicit right now
clang-tools-extra/trunk/docs/clangd/Installation.rst | ||
---|---|---|
325 | Isn't the order of the arguments the wrong way round here? |
clang-tools-extra/trunk/docs/clangd/Installation.rst | ||
---|---|---|
325 | yeah that seems to be the case it should rather be $ ln -s ~/myproject-build/compile_commands.json ~/myproject/ sending out a patch, thanks for bringing it up! |
Isn't the order of the arguments the wrong way round here?