(P0433 was adopted into C++17 at Kona 2017.)
This patch incorporates the resolution of LWG 3025.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
Review comments; remove unnecessary _VSTD:: before remove_const; consistent use of typedefs P and PC to match the corresponding unordered_map tests from D58587.
@mclow.lists: I think this one is ready to land, as well as D58617, although they probably deserve some close scrutiny to make sure the tests are testing the things they should be testing.
I wonder if I should switch from using typename remove_const<T>::type to remove_const_t<T>, since all the deduction guides are compiled only in C++17 mode anyway. If we want to do that, I propose to do it as a separate patch, or at least shortly thereafter to submit a separate patch to consistently use remove_const_t in the <set> and <map> deduction guides.
Use _EnableIf and remove_const_t instead of enable_if and remove_const.
Whitespace diffs.
Preemptively add XFAILs on apple-clang, matching the XFAILs that were needed for unordered_set.
@ldionne ping! I believe this is ready to land.
This completes my patch-series on the topic of "CTAD for associative and unordered containers."
Btw, I've verified that the container adaptors are all done (by Marshall, a while ago). The one place libc++ is known to be still missing deduction guides is std::function ( https://bugs.llvm.org/show_bug.cgi?id=39606 ).