Page MenuHomePhabricator

STL_MSFT (Stephan T. Lavavej)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 26 2016, 3:30 PM (173 w, 1 h)

Recent Activity

Apr 2 2019

STL_MSFT added inline comments to D60145: libcxx: Add _LIBCPP_NODISCARD_EXT to 37 more functions.
Apr 2 2019, 3:20 PM

Feb 13 2019

STL_MSFT added a comment to D17444: [MSVC] Recognize "static_assert" keyword in C mode.

@rnk I've forwarded this to the compiler front-end and Universal CRT teams.

Feb 13 2019, 2:18 PM · Restricted Project

Nov 14 2018

STL_MSFT closed D54508: [libcxx] [test] Fix Clang -Wunused-local-typedef, MSVC C4800, missing cassert..

Committed as rCXX346910, rCXX346911, and rCXX346912.

Nov 14 2018, 3:33 PM
STL_MSFT committed rL346912: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings..
[libcxx] [test] Fix Clang -Wunused-local-typedef warnings.
Nov 14 2018, 3:26 PM
STL_MSFT committed rCXX346912: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings..
[libcxx] [test] Fix Clang -Wunused-local-typedef warnings.
Nov 14 2018, 3:26 PM
STL_MSFT committed rL346911: [libcxx] [test] Include <cassert> for assert()..
[libcxx] [test] Include <cassert> for assert().
Nov 14 2018, 3:26 PM
STL_MSFT committed rCXX346911: [libcxx] [test] Include <cassert> for assert()..
[libcxx] [test] Include <cassert> for assert().
Nov 14 2018, 3:26 PM
STL_MSFT committed rCXX346910: [libcxx] [test] Fix MSVC warning C4800..
[libcxx] [test] Fix MSVC warning C4800.
Nov 14 2018, 3:26 PM
STL_MSFT committed rL346910: [libcxx] [test] Fix MSVC warning C4800..
[libcxx] [test] Fix MSVC warning C4800.
Nov 14 2018, 3:26 PM

Nov 13 2018

STL_MSFT created D54508: [libcxx] [test] Fix Clang -Wunused-local-typedef, MSVC C4800, missing cassert..
Nov 13 2018, 7:35 PM
STL_MSFT committed rL346826: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Nov 13 2018, 7:09 PM
STL_MSFT committed rCXX346826: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Nov 13 2018, 7:09 PM

Nov 2 2018

STL_MSFT added a comment to D53912: [Headers] [MS] Add intrin0.h.

Yes, the "real builtin" approach seems to be best. For a recent example, D49606 added __shiftright128 as an inline function in intrin.h, but that didn't work with MSVC's STL when I moved our declaration of __shiftright128 from intrin.h to intrin0.h. This was fixed by D50907 making __shiftright128 a real builtin.

Nov 2 2018, 2:51 PM

Oct 5 2018

STL_MSFT added a comment to D31635: [clang-format] Added ReferenceAlignmentStyle option.

I'd love to have this feature; is there any chance of this year-old patch being accepted?

Oct 5 2018, 4:18 PM · Restricted Project, Restricted Project

Oct 3 2018

STL_MSFT added inline comments to D52843: Update Clang Windows getting started docs.
Oct 3 2018, 3:29 PM

Sep 18 2018

STL_MSFT added inline comments to D51868: [libcxx] Build and test fixes for Windows.
Sep 18 2018, 9:01 PM

Jul 16 2018

STL_MSFT added inline comments to D49338: Implement <span> - P0122R7.
Jul 16 2018, 12:49 PM

Jun 26 2018

STL_MSFT added inline comments to D48616: Implement LWG 2946, 3075 and 3076.
Jun 26 2018, 3:56 PM

Jun 13 2018

STL_MSFT committed rCXX334676: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Jun 13 2018, 5:17 PM
STL_MSFT committed rCXX334675: [libcxx] [test] Update msvc_stdlib_force_include.hpp..
[libcxx] [test] Update msvc_stdlib_force_include.hpp.
Jun 13 2018, 5:17 PM
STL_MSFT committed rL334676: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Jun 13 2018, 5:17 PM
STL_MSFT committed rL334675: [libcxx] [test] Update msvc_stdlib_force_include.hpp..
[libcxx] [test] Update msvc_stdlib_force_include.hpp.
Jun 13 2018, 5:16 PM

May 11 2018

STL_MSFT committed rCXX332159: [libcxx] [test] Update msvc_stdlib_force_include.hpp..
[libcxx] [test] Update msvc_stdlib_force_include.hpp.
May 11 2018, 5:01 PM
STL_MSFT committed rL332159: [libcxx] [test] Update msvc_stdlib_force_include.hpp..
[libcxx] [test] Update msvc_stdlib_force_include.hpp.
May 11 2018, 5:01 PM

May 4 2018

STL_MSFT committed rCXX331576: [libcxx] [test] Fix whitespace, NFC..
[libcxx] [test] Fix whitespace, NFC.
May 4 2018, 6:44 PM
STL_MSFT committed rCXX331575: [libcxx] [test] Fix MSVC x64 truncation warning..
[libcxx] [test] Fix MSVC x64 truncation warning.
May 4 2018, 6:44 PM
STL_MSFT committed rL331576: [libcxx] [test] Fix whitespace, NFC..
[libcxx] [test] Fix whitespace, NFC.
May 4 2018, 6:44 PM
STL_MSFT committed rL331575: [libcxx] [test] Fix MSVC x64 truncation warning..
[libcxx] [test] Fix MSVC x64 truncation warning.
May 4 2018, 6:44 PM

Apr 12 2018

STL_MSFT closed D45595: [libcxx] [test] Fix nodiscard warnings..

Committed with a follow-up to use the requested macro.

Apr 12 2018, 5:13 PM
STL_MSFT committed rCXX329979: [libcxx] [test] Use TEST_IGNORE_NODISCARD..
[libcxx] [test] Use TEST_IGNORE_NODISCARD.
Apr 12 2018, 5:12 PM
STL_MSFT committed rL329979: [libcxx] [test] Use TEST_IGNORE_NODISCARD..
[libcxx] [test] Use TEST_IGNORE_NODISCARD.
Apr 12 2018, 5:12 PM
STL_MSFT closed D45596: [libcxx] [test] Avoid unary_function..
Apr 12 2018, 5:07 PM
STL_MSFT closed D45594: [libcxx] [test] Silence MSVC warning C4146..

Committed, with a follow-up to use the C1XX macro.

Apr 12 2018, 5:07 PM
STL_MSFT accepted D45016: [libcxx] [test] Avoid MSVC truncation warnings..

Approved by Eric.

Apr 12 2018, 5:06 PM
STL_MSFT closed D45016: [libcxx] [test] Avoid MSVC truncation warnings..
Apr 12 2018, 5:06 PM
STL_MSFT committed rCXX329978: [libcxx] [test] Fix whitespace, NFC..
[libcxx] [test] Fix whitespace, NFC.
Apr 12 2018, 5:05 PM
STL_MSFT committed rCXX329977: [libcxx] [test] Use TEST_COMPILER_C1XX..
[libcxx] [test] Use TEST_COMPILER_C1XX.
Apr 12 2018, 5:05 PM
STL_MSFT committed rCXX329976: [libcxx] [test] Silence MSVC warning C4146..
[libcxx] [test] Silence MSVC warning C4146.
Apr 12 2018, 5:05 PM
STL_MSFT committed rCXX329975: [libcxx] [test] Fix nodiscard warnings..
[libcxx] [test] Fix nodiscard warnings.
Apr 12 2018, 5:05 PM
STL_MSFT committed rCXX329974: [libcxx] [test] Avoid unary_function..
[libcxx] [test] Avoid unary_function.
Apr 12 2018, 5:05 PM
STL_MSFT committed rCXX329973: [libcxx] [test] Avoid MSVC truncation warnings..
[libcxx] [test] Avoid MSVC truncation warnings.
Apr 12 2018, 5:05 PM
STL_MSFT committed rL329978: [libcxx] [test] Fix whitespace, NFC..
[libcxx] [test] Fix whitespace, NFC.
Apr 12 2018, 5:01 PM
STL_MSFT committed rL329977: [libcxx] [test] Use TEST_COMPILER_C1XX..
[libcxx] [test] Use TEST_COMPILER_C1XX.
Apr 12 2018, 5:01 PM
STL_MSFT committed rL329975: [libcxx] [test] Fix nodiscard warnings..
[libcxx] [test] Fix nodiscard warnings.
Apr 12 2018, 5:01 PM
STL_MSFT committed rL329976: [libcxx] [test] Silence MSVC warning C4146..
[libcxx] [test] Silence MSVC warning C4146.
Apr 12 2018, 5:01 PM
STL_MSFT committed rL329974: [libcxx] [test] Avoid unary_function..
[libcxx] [test] Avoid unary_function.
Apr 12 2018, 5:01 PM
STL_MSFT committed rL329973: [libcxx] [test] Avoid MSVC truncation warnings..
[libcxx] [test] Avoid MSVC truncation warnings.
Apr 12 2018, 5:01 PM
STL_MSFT created D45596: [libcxx] [test] Avoid unary_function..
Apr 12 2018, 3:20 PM
STL_MSFT created D45595: [libcxx] [test] Fix nodiscard warnings..
Apr 12 2018, 3:16 PM
STL_MSFT created D45594: [libcxx] [test] Silence MSVC warning C4146..
Apr 12 2018, 3:15 PM

Apr 9 2018

STL_MSFT added a comment to D45016: [libcxx] [test] Avoid MSVC truncation warnings..

Ping?

Apr 9 2018, 8:23 PM

Mar 28 2018

STL_MSFT created D45016: [libcxx] [test] Avoid MSVC truncation warnings..
Mar 28 2018, 8:16 PM

Mar 22 2018

STL_MSFT committed rCXX328264: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Mar 22 2018, 4:01 PM
STL_MSFT committed rL328264: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Mar 22 2018, 4:01 PM

Feb 26 2018

STL_MSFT committed rCXX326120: [libcxx] [test] Fix MSVC warnings and errors..
[libcxx] [test] Fix MSVC warnings and errors.
Feb 26 2018, 12:55 PM
STL_MSFT closed D43273: [libcxx] [test] Fix MSVC warnings and errors..
Feb 26 2018, 12:51 PM
STL_MSFT committed rL326120: [libcxx] [test] Fix MSVC warnings and errors..
[libcxx] [test] Fix MSVC warnings and errors.
Feb 26 2018, 12:50 PM

Feb 21 2018

STL_MSFT updated the diff for D43273: [libcxx] [test] Fix MSVC warnings and errors..

Update based on code review feedback.

Feb 21 2018, 6:32 PM

Feb 15 2018

STL_MSFT added a comment to D43273: [libcxx] [test] Fix MSVC warnings and errors..

Would pragmas guarded by _MSC_VER be acceptable for the truncation warnings?

Feb 15 2018, 11:27 AM

Feb 13 2018

STL_MSFT created D43273: [libcxx] [test] Fix MSVC warnings and errors..
Feb 13 2018, 7:34 PM

Feb 12 2018

STL_MSFT committed rCXX324959: [libcxx] [test] Strip trailing whitespace, NFC..
[libcxx] [test] Strip trailing whitespace, NFC.
Feb 12 2018, 2:58 PM
STL_MSFT committed rL324959: [libcxx] [test] Strip trailing whitespace, NFC..
[libcxx] [test] Strip trailing whitespace, NFC.
Feb 12 2018, 2:58 PM

Jan 22 2018

STL_MSFT added a comment to D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'.

Seems reasonable to me.

Jan 22 2018, 10:47 AM

Jan 9 2018

STL_MSFT closed D41213: [libcxx] [test] Improve MSVC portability..

Thanks, I've checked this in as-is. I would support an LWG issue to change the Standardese here.

Jan 9 2018, 4:43 PM
STL_MSFT committed rCXX322144: [libcxx] [test] Improve MSVC portability..
[libcxx] [test] Improve MSVC portability.
Jan 9 2018, 4:42 PM
STL_MSFT committed rL322144: [libcxx] [test] Improve MSVC portability..
[libcxx] [test] Improve MSVC portability.
Jan 9 2018, 4:41 PM
STL_MSFT added a comment to D41213: [libcxx] [test] Improve MSVC portability..

Ping? (And happy Patch Tuesday!)

Jan 9 2018, 12:14 PM

Jan 2 2018

STL_MSFT added a comment to D41213: [libcxx] [test] Improve MSVC portability..

Ping? (And happy new year!)

Jan 2 2018, 12:16 PM

Dec 13 2017

STL_MSFT created D41213: [libcxx] [test] Improve MSVC portability..
Dec 13 2017, 5:20 PM

Dec 12 2017

STL_MSFT closed D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..
Dec 12 2017, 4:54 PM
STL_MSFT accepted D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..

Thanks, I've checked this in without the changes to TODO.TXT. Please let me know if you still want them, otherwise I consider this to be complete.

Dec 12 2017, 4:54 PM
STL_MSFT closed D41030: [libcxx] [test] Fix MSVC warnings, null pointer deref..
Dec 12 2017, 4:53 PM
STL_MSFT committed rCXX320536: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..
[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.
Dec 12 2017, 4:52 PM
STL_MSFT committed rCXX320535: [libcxx] [test] Fix MSVC warnings, null pointer deref..
[libcxx] [test] Fix MSVC warnings, null pointer deref.
Dec 12 2017, 4:52 PM
STL_MSFT committed rL320536: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..
[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.
Dec 12 2017, 4:52 PM
STL_MSFT committed rL320535: [libcxx] [test] Fix MSVC warnings, null pointer deref..
[libcxx] [test] Fix MSVC warnings, null pointer deref.
Dec 12 2017, 4:52 PM

Dec 11 2017

STL_MSFT added a comment to D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..

Would you like me to drop the changes to TODO.TXT?

Dec 11 2017, 11:13 AM

Dec 8 2017

STL_MSFT created D41030: [libcxx] [test] Fix MSVC warnings, null pointer deref..
Dec 8 2017, 12:50 PM

Dec 7 2017

STL_MSFT created D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..
Dec 7 2017, 4:09 PM

Dec 6 2017

STL_MSFT committed rL319994: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Dec 6 2017, 4:51 PM
STL_MSFT committed rCXX319994: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Dec 6 2017, 4:51 PM

Oct 18 2017

STL_MSFT added a comment to D39064: implement __has_unique_object_representations.

Looks good to me modulo comments.

Oct 18 2017, 3:19 PM

Oct 9 2017

STL_MSFT added a comment to D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017.

FYI: 1910 was the value for VS 2017 RTM. 1911 is the value for VS 2017 15.3, the first toolset update. 1912 will be the value for VS 2017 15.5, the second toolset update.

Oct 9 2017, 11:21 AM

Sep 26 2017

STL_MSFT committed rL314259: [libcxx] [test] Fix unused local typedef warnings..
[libcxx] [test] Fix unused local typedef warnings.
Sep 26 2017, 4:10 PM
STL_MSFT committed rL314258: [libcxx] [test] Strip trailing whitespace..
[libcxx] [test] Strip trailing whitespace.
Sep 26 2017, 4:10 PM
STL_MSFT committed rL314257: [libcxx] [test] Silence warning C4324 for MSVC..
[libcxx] [test] Silence warning C4324 for MSVC.
Sep 26 2017, 4:10 PM

Sep 25 2017

STL_MSFT added a comment to D38209: [Sema] Correct nothrow inherited by noexcept.

do you think __declspec(nothrow) calling the terminate handler in Clang is a bug?

Sep 25 2017, 1:34 PM
STL_MSFT added a comment to D38209: [Sema] Correct nothrow inherited by noexcept.

This sounds right to me and the test looks good. (I'll let an actual compiler dev sign off)

Sep 25 2017, 5:02 AM

Aug 31 2017

STL_MSFT closed D37318: [libcxx] [www] Cleanup links to be https..
Aug 31 2017, 11:04 AM
STL_MSFT committed rL312262: [libcxx] [www] Strip trailing whitespace..
[libcxx] [www] Strip trailing whitespace.
Aug 31 2017, 11:03 AM
STL_MSFT committed rL312263: [libcxx] [www] Change an absolute link to cxx1z_status.html to be relative..
[libcxx] [www] Change an absolute link to cxx1z_status.html to be relative.
Aug 31 2017, 11:03 AM
STL_MSFT committed rL312260: [libcxx] [www] Manually change http links to https..
[libcxx] [www] Manually change http links to https.
Aug 31 2017, 11:03 AM
STL_MSFT committed rL312261: [libcxx] [www] Fix broken link for LLVM Bugzilla..
[libcxx] [www] Fix broken link for LLVM Bugzilla.
Aug 31 2017, 11:03 AM
STL_MSFT committed rL312259: [libcxx] [www] Semi-manually change http://www.open-std.org and http://isocpp..
[libcxx] [www] Semi-manually change http://www.open-std.org and http://isocpp.
Aug 31 2017, 11:03 AM
STL_MSFT committed rL312258: [libcxx] [www] Change http://cplusplus.github.io/LWG/lwg-defects.html# to https….
[libcxx] [www] Change http://cplusplus.github.io/LWG/lwg-defects.html# to https…
Aug 31 2017, 11:03 AM
STL_MSFT committed rL312257: [libcxx] [www] Change http://wg21.link to https://wg21.link ..
[libcxx] [www] Change http://wg21.link to https://wg21.link .
Aug 31 2017, 11:03 AM

Aug 30 2017

STL_MSFT created D37318: [libcxx] [www] Cleanup links to be https..
Aug 30 2017, 3:40 PM

Aug 24 2017

STL_MSFT closed D36503: [libcxx] [test] Update for C++17 feature removals..
Aug 24 2017, 2:44 PM
STL_MSFT committed rL311705: [libcxx] [test] Update for C++17 feature removals..
[libcxx] [test] Update for C++17 feature removals.
Aug 24 2017, 2:25 PM
STL_MSFT accepted D36503: [libcxx] [test] Update for C++17 feature removals..

Looks good to myself.

Aug 24 2017, 2:24 PM