Page MenuHomePhabricator

STL_MSFT (Stephan T. Lavavej)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 26 2016, 3:30 PM (189 w, 17 h)

Recent Activity

Wed, Dec 4

STL_MSFT added a comment to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.

Certainly, we could use the test cases.

Wed, Dec 4, 7:59 PM · Restricted Project
STL_MSFT added a comment to D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage.

I would like to revive D66394 to get it disabled by default soon.

Wed, Dec 4, 7:10 PM

Mon, Nov 25

STL_MSFT updated the diff for D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.

First round of changes addressing code review comments.

Mon, Nov 25, 6:08 PM · Restricted Project
STL_MSFT added inline comments to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.
Mon, Nov 25, 6:01 PM · Restricted Project

Fri, Nov 22

STL_MSFT created D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.
Fri, Nov 22, 8:24 PM · Restricted Project

Thu, Nov 14

STL_MSFT added a comment to D19031: [clang-format] Flexible line endings.

MSVC's STL currently uses CRLF (DOS) line endings, not LF (Unix). I wrote a validator, https://github.com/microsoft/STL/blob/58bb49d63d92e7a0346a05af29816aeea6b4cf0f/tools/validate/validate.cpp , to detect LF files, mixed line endings (LF and CRLF in the same file), damaged endings (CR only), and enforcing one newline at the end of every file, because clang-format doesn't currently handle those whitespace issues.

Thu, Nov 14, 3:04 PM · Restricted Project, Restricted Project

Nov 8 2019

STL_MSFT closed D69981: [www] More HTTPS and outdated link fixes..
Nov 8 2019, 2:43 PM · Restricted Project, Restricted Project
STL_MSFT accepted D69981: [www] More HTTPS and outdated link fixes..

Committed: https://github.com/llvm/llvm-project/commit/3a7a22445e806c08f80cf6d83d1760f7ff732ed0

Nov 8 2019, 2:43 PM · Restricted Project, Restricted Project
STL_MSFT committed rG3a7a22445e80: [www] More HTTPS and outdated link fixes. (authored by STL_MSFT).
[www] More HTTPS and outdated link fixes.
Nov 8 2019, 2:43 PM

Nov 7 2019

STL_MSFT created D69981: [www] More HTTPS and outdated link fixes..
Nov 7 2019, 6:18 PM · Restricted Project, Restricted Project

Oct 24 2019

STL_MSFT committed rG2e4f1e112dfe: [www] Change URLs to HTTPS. (authored by STL_MSFT).
[www] Change URLs to HTTPS.
Oct 24 2019, 1:38 PM
STL_MSFT closed D69363: [www] Change URLs to HTTPS..

Committed: https://github.com/llvm/llvm-project/commit/2e4f1e112dfee1d16c138d42f2bc7ee639f9ae05

Oct 24 2019, 1:38 PM · Restricted Project, Restricted Project

Oct 23 2019

STL_MSFT added inline comments to D69363: [www] Change URLs to HTTPS..
Oct 23 2019, 9:01 PM · Restricted Project, Restricted Project
Herald added a reviewer for D69363: [www] Change URLs to HTTPS.: bollu.
Oct 23 2019, 7:47 PM · Restricted Project, Restricted Project
STL_MSFT committed rG7c9844b66e5e: [libcxx][NFC] Strip trailing whitespace, fix typo. (authored by STL_MSFT).
[libcxx][NFC] Strip trailing whitespace, fix typo.
Oct 23 2019, 11:55 AM

Oct 22 2019

STL_MSFT committed rG437e0e5191ca: [libcxx][test][NFC] Fix comment typos. (authored by STL_MSFT).
[libcxx][test][NFC] Fix comment typos.
Oct 22 2019, 3:54 PM

Oct 11 2019

STL_MSFT committed rL374618: Request commit access for stl_msft.
Request commit access for stl_msft
Oct 11 2019, 5:28 PM

Aug 26 2019

STL_MSFT added a comment to D66770: Move EH spec mismatches under -fms-compatibility.

This will definitely help us clean up our code, since we run the MSVC STL test suite with -fno-ms-compatibility -fno-delayed-template-parsing.

Aug 26 2019, 4:18 PM · Restricted Project

Apr 2 2019

STL_MSFT added inline comments to D60145: libcxx: Add _LIBCPP_NODISCARD_EXT to 37 more functions.
Apr 2 2019, 3:20 PM

Feb 13 2019

STL_MSFT added a comment to D17444: [MSVC] Recognize "static_assert" keyword in C mode.

@rnk I've forwarded this to the compiler front-end and Universal CRT teams.

Feb 13 2019, 2:18 PM · Restricted Project

Nov 14 2018

STL_MSFT closed D54508: [libcxx] [test] Fix Clang -Wunused-local-typedef, MSVC C4800, missing cassert..

Committed as rCXX346910, rCXX346911, and rCXX346912.

Nov 14 2018, 3:33 PM
STL_MSFT committed rL346912: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings..
[libcxx] [test] Fix Clang -Wunused-local-typedef warnings.
Nov 14 2018, 3:26 PM
STL_MSFT committed rCXX346912: [libcxx] [test] Fix Clang -Wunused-local-typedef warnings..
[libcxx] [test] Fix Clang -Wunused-local-typedef warnings.
Nov 14 2018, 3:26 PM
STL_MSFT committed rL346911: [libcxx] [test] Include <cassert> for assert()..
[libcxx] [test] Include <cassert> for assert().
Nov 14 2018, 3:26 PM
STL_MSFT committed rCXX346911: [libcxx] [test] Include <cassert> for assert()..
[libcxx] [test] Include <cassert> for assert().
Nov 14 2018, 3:26 PM
STL_MSFT committed rCXX346910: [libcxx] [test] Fix MSVC warning C4800..
[libcxx] [test] Fix MSVC warning C4800.
Nov 14 2018, 3:26 PM
STL_MSFT committed rL346910: [libcxx] [test] Fix MSVC warning C4800..
[libcxx] [test] Fix MSVC warning C4800.
Nov 14 2018, 3:26 PM

Nov 13 2018

STL_MSFT created D54508: [libcxx] [test] Fix Clang -Wunused-local-typedef, MSVC C4800, missing cassert..
Nov 13 2018, 7:35 PM
STL_MSFT committed rL346826: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Nov 13 2018, 7:09 PM
STL_MSFT committed rCXX346826: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Nov 13 2018, 7:09 PM

Nov 2 2018

STL_MSFT added a comment to D53912: [Headers] [MS] Add intrin0.h.

Yes, the "real builtin" approach seems to be best. For a recent example, D49606 added __shiftright128 as an inline function in intrin.h, but that didn't work with MSVC's STL when I moved our declaration of __shiftright128 from intrin.h to intrin0.h. This was fixed by D50907 making __shiftright128 a real builtin.

Nov 2 2018, 2:51 PM

Oct 5 2018

STL_MSFT added a comment to D31635: [clang-format] Added ReferenceAlignmentStyle option.

I'd love to have this feature; is there any chance of this year-old patch being accepted?

Oct 5 2018, 4:18 PM · Restricted Project, Restricted Project, Restricted Project

Oct 3 2018

STL_MSFT added inline comments to D52843: Update Clang Windows getting started docs.
Oct 3 2018, 3:29 PM

Sep 18 2018

STL_MSFT added inline comments to D51868: [libcxx] Build and test fixes for Windows.
Sep 18 2018, 9:01 PM

Jul 16 2018

STL_MSFT added inline comments to D49338: Implement <span> - P0122R7.
Jul 16 2018, 12:49 PM

Jun 26 2018

STL_MSFT added inline comments to D48616: Implement LWG 2946, 3075 and 3076.
Jun 26 2018, 3:56 PM

Jun 13 2018

STL_MSFT committed rCXX334676: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Jun 13 2018, 5:17 PM
STL_MSFT committed rCXX334675: [libcxx] [test] Update msvc_stdlib_force_include.hpp..
[libcxx] [test] Update msvc_stdlib_force_include.hpp.
Jun 13 2018, 5:17 PM
STL_MSFT committed rL334676: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Jun 13 2018, 5:17 PM
STL_MSFT committed rL334675: [libcxx] [test] Update msvc_stdlib_force_include.hpp..
[libcxx] [test] Update msvc_stdlib_force_include.hpp.
Jun 13 2018, 5:16 PM

May 11 2018

STL_MSFT committed rCXX332159: [libcxx] [test] Update msvc_stdlib_force_include.hpp..
[libcxx] [test] Update msvc_stdlib_force_include.hpp.
May 11 2018, 5:01 PM
STL_MSFT committed rL332159: [libcxx] [test] Update msvc_stdlib_force_include.hpp..
[libcxx] [test] Update msvc_stdlib_force_include.hpp.
May 11 2018, 5:01 PM

May 4 2018

STL_MSFT committed rCXX331576: [libcxx] [test] Fix whitespace, NFC..
[libcxx] [test] Fix whitespace, NFC.
May 4 2018, 6:44 PM
STL_MSFT committed rCXX331575: [libcxx] [test] Fix MSVC x64 truncation warning..
[libcxx] [test] Fix MSVC x64 truncation warning.
May 4 2018, 6:44 PM
STL_MSFT committed rL331576: [libcxx] [test] Fix whitespace, NFC..
[libcxx] [test] Fix whitespace, NFC.
May 4 2018, 6:44 PM
STL_MSFT committed rL331575: [libcxx] [test] Fix MSVC x64 truncation warning..
[libcxx] [test] Fix MSVC x64 truncation warning.
May 4 2018, 6:44 PM

Apr 12 2018

STL_MSFT closed D45595: [libcxx] [test] Fix nodiscard warnings..

Committed with a follow-up to use the requested macro.

Apr 12 2018, 5:13 PM
STL_MSFT committed rCXX329979: [libcxx] [test] Use TEST_IGNORE_NODISCARD..
[libcxx] [test] Use TEST_IGNORE_NODISCARD.
Apr 12 2018, 5:12 PM
STL_MSFT committed rL329979: [libcxx] [test] Use TEST_IGNORE_NODISCARD..
[libcxx] [test] Use TEST_IGNORE_NODISCARD.
Apr 12 2018, 5:12 PM
STL_MSFT closed D45596: [libcxx] [test] Avoid unary_function..
Apr 12 2018, 5:07 PM
STL_MSFT closed D45594: [libcxx] [test] Silence MSVC warning C4146..

Committed, with a follow-up to use the C1XX macro.

Apr 12 2018, 5:07 PM
STL_MSFT accepted D45016: [libcxx] [test] Avoid MSVC truncation warnings..

Approved by Eric.

Apr 12 2018, 5:06 PM
STL_MSFT closed D45016: [libcxx] [test] Avoid MSVC truncation warnings..
Apr 12 2018, 5:06 PM
STL_MSFT committed rCXX329978: [libcxx] [test] Fix whitespace, NFC..
[libcxx] [test] Fix whitespace, NFC.
Apr 12 2018, 5:05 PM
STL_MSFT committed rCXX329977: [libcxx] [test] Use TEST_COMPILER_C1XX..
[libcxx] [test] Use TEST_COMPILER_C1XX.
Apr 12 2018, 5:05 PM
STL_MSFT committed rCXX329976: [libcxx] [test] Silence MSVC warning C4146..
[libcxx] [test] Silence MSVC warning C4146.
Apr 12 2018, 5:05 PM
STL_MSFT committed rCXX329975: [libcxx] [test] Fix nodiscard warnings..
[libcxx] [test] Fix nodiscard warnings.
Apr 12 2018, 5:05 PM
STL_MSFT committed rCXX329974: [libcxx] [test] Avoid unary_function..
[libcxx] [test] Avoid unary_function.
Apr 12 2018, 5:05 PM
STL_MSFT committed rCXX329973: [libcxx] [test] Avoid MSVC truncation warnings..
[libcxx] [test] Avoid MSVC truncation warnings.
Apr 12 2018, 5:05 PM
STL_MSFT committed rL329978: [libcxx] [test] Fix whitespace, NFC..
[libcxx] [test] Fix whitespace, NFC.
Apr 12 2018, 5:01 PM
STL_MSFT committed rL329977: [libcxx] [test] Use TEST_COMPILER_C1XX..
[libcxx] [test] Use TEST_COMPILER_C1XX.
Apr 12 2018, 5:01 PM
STL_MSFT committed rL329975: [libcxx] [test] Fix nodiscard warnings..
[libcxx] [test] Fix nodiscard warnings.
Apr 12 2018, 5:01 PM
STL_MSFT committed rL329976: [libcxx] [test] Silence MSVC warning C4146..
[libcxx] [test] Silence MSVC warning C4146.
Apr 12 2018, 5:01 PM
STL_MSFT committed rL329974: [libcxx] [test] Avoid unary_function..
[libcxx] [test] Avoid unary_function.
Apr 12 2018, 5:01 PM
STL_MSFT committed rL329973: [libcxx] [test] Avoid MSVC truncation warnings..
[libcxx] [test] Avoid MSVC truncation warnings.
Apr 12 2018, 5:01 PM
STL_MSFT created D45596: [libcxx] [test] Avoid unary_function..
Apr 12 2018, 3:20 PM
STL_MSFT created D45595: [libcxx] [test] Fix nodiscard warnings..
Apr 12 2018, 3:16 PM
STL_MSFT created D45594: [libcxx] [test] Silence MSVC warning C4146..
Apr 12 2018, 3:15 PM

Apr 9 2018

STL_MSFT added a comment to D45016: [libcxx] [test] Avoid MSVC truncation warnings..

Ping?

Apr 9 2018, 8:23 PM

Mar 28 2018

STL_MSFT created D45016: [libcxx] [test] Avoid MSVC truncation warnings..
Mar 28 2018, 8:16 PM

Mar 22 2018

STL_MSFT committed rCXX328264: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Mar 22 2018, 4:01 PM
STL_MSFT committed rL328264: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Mar 22 2018, 4:01 PM

Feb 26 2018

STL_MSFT committed rCXX326120: [libcxx] [test] Fix MSVC warnings and errors..
[libcxx] [test] Fix MSVC warnings and errors.
Feb 26 2018, 12:55 PM
STL_MSFT closed D43273: [libcxx] [test] Fix MSVC warnings and errors..
Feb 26 2018, 12:51 PM
STL_MSFT committed rL326120: [libcxx] [test] Fix MSVC warnings and errors..
[libcxx] [test] Fix MSVC warnings and errors.
Feb 26 2018, 12:50 PM

Feb 21 2018

STL_MSFT updated the diff for D43273: [libcxx] [test] Fix MSVC warnings and errors..

Update based on code review feedback.

Feb 21 2018, 6:32 PM

Feb 15 2018

STL_MSFT added a comment to D43273: [libcxx] [test] Fix MSVC warnings and errors..

Would pragmas guarded by _MSC_VER be acceptable for the truncation warnings?

Feb 15 2018, 11:27 AM

Feb 13 2018

STL_MSFT created D43273: [libcxx] [test] Fix MSVC warnings and errors..
Feb 13 2018, 7:34 PM

Feb 12 2018

STL_MSFT committed rCXX324959: [libcxx] [test] Strip trailing whitespace, NFC..
[libcxx] [test] Strip trailing whitespace, NFC.
Feb 12 2018, 2:58 PM
STL_MSFT committed rL324959: [libcxx] [test] Strip trailing whitespace, NFC..
[libcxx] [test] Strip trailing whitespace, NFC.
Feb 12 2018, 2:58 PM

Jan 22 2018

STL_MSFT added a comment to D42354: Fix libcxx MSVC C++17 redefinition of 'align_val_t'.

Seems reasonable to me.

Jan 22 2018, 10:47 AM

Jan 9 2018

STL_MSFT closed D41213: [libcxx] [test] Improve MSVC portability..

Thanks, I've checked this in as-is. I would support an LWG issue to change the Standardese here.

Jan 9 2018, 4:43 PM
STL_MSFT committed rCXX322144: [libcxx] [test] Improve MSVC portability..
[libcxx] [test] Improve MSVC portability.
Jan 9 2018, 4:42 PM
STL_MSFT committed rL322144: [libcxx] [test] Improve MSVC portability..
[libcxx] [test] Improve MSVC portability.
Jan 9 2018, 4:41 PM
STL_MSFT added a comment to D41213: [libcxx] [test] Improve MSVC portability..

Ping? (And happy Patch Tuesday!)

Jan 9 2018, 12:14 PM

Jan 2 2018

STL_MSFT added a comment to D41213: [libcxx] [test] Improve MSVC portability..

Ping? (And happy new year!)

Jan 2 2018, 12:16 PM

Dec 13 2017

STL_MSFT created D41213: [libcxx] [test] Improve MSVC portability..
Dec 13 2017, 5:20 PM

Dec 12 2017

STL_MSFT closed D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..
Dec 12 2017, 4:54 PM
STL_MSFT accepted D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..

Thanks, I've checked this in without the changes to TODO.TXT. Please let me know if you still want them, otherwise I consider this to be complete.

Dec 12 2017, 4:54 PM
STL_MSFT closed D41030: [libcxx] [test] Fix MSVC warnings, null pointer deref..
Dec 12 2017, 4:53 PM
STL_MSFT committed rCXX320536: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..
[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.
Dec 12 2017, 4:52 PM
STL_MSFT committed rCXX320535: [libcxx] [test] Fix MSVC warnings, null pointer deref..
[libcxx] [test] Fix MSVC warnings, null pointer deref.
Dec 12 2017, 4:52 PM
STL_MSFT committed rL320536: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..
[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.
Dec 12 2017, 4:52 PM
STL_MSFT committed rL320535: [libcxx] [test] Fix MSVC warnings, null pointer deref..
[libcxx] [test] Fix MSVC warnings, null pointer deref.
Dec 12 2017, 4:52 PM

Dec 11 2017

STL_MSFT added a comment to D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..

Would you like me to drop the changes to TODO.TXT?

Dec 11 2017, 11:13 AM

Dec 8 2017

STL_MSFT created D41030: [libcxx] [test] Fix MSVC warnings, null pointer deref..
Dec 8 2017, 12:50 PM

Dec 7 2017

STL_MSFT created D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII..
Dec 7 2017, 4:09 PM

Dec 6 2017

STL_MSFT committed rL319994: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Dec 6 2017, 4:51 PM
STL_MSFT committed rCXX319994: [libcxx] [test] Strip trailing whitespace. NFC..
[libcxx] [test] Strip trailing whitespace. NFC.
Dec 6 2017, 4:51 PM

Oct 18 2017

STL_MSFT added a comment to D39064: implement __has_unique_object_representations.

Looks good to me modulo comments.

Oct 18 2017, 3:19 PM