Rebased on master.
(Is "CTAD for container types" similar to "polymorphic memory resources" in the bucket of "things libc++ doesn't want to implement for engineering reasons," and if so, could you guys go on record with that? It would be less dysfunctional than the current model.)
A couple of minor nits.
Same comment about __identify as in the other review. You need answer it in one place, only.
|88 ↗||(On Diff #195977)|
A comment here "braces instead of paren" would be nice.
|104 ↗||(On Diff #195977)|
These should all be const
Almost there. A couple nits, a few consts, and landing D58587, and we're done.
|862 ↗||(On Diff #195977)|
Any reason that you're not using __iter_value_type here? (Besides that it is declared in D58587)
|1365 ↗||(On Diff #195977)|
same comment re: __iter_value_type
|94 ↗||(On Diff #195977)|
Please change to std::allocator<long> When we tighten up the constraints on set, it won't break this test.