Page MenuHomePhabricator

Implement class deduction guides for `std::array`
ClosedPublic

Authored by mclow.lists on May 16 2018, 10:59 AM.

Details

Reviewers
EricWF
Summary

According to http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0433r2.html

Once this is reviewed, I'll do the rest of the sequence containers.

Diff Detail

Event Timeline

mclow.lists created this revision.May 16 2018, 10:59 AM
EricWF accepted this revision.May 18 2018, 1:34 PM
EricWF added inline comments.
include/array
75

Don't we normally comment // C++17 or similar for new features in the synopsis?

361

The is same clause is a requirement, not a SFINAE constraint. Should this be a hard error? Should we really SFINAE it?

test/std/containers/sequences/array/array.cons/deduct.fail.cpp
12

This should be UNSUPPORTED. We don't expect this test to ever pass without deduction guides.

test/std/containers/sequences/array/array.cons/deduct.pass.cpp
12

UNSUPPORTED

This revision is now accepted and ready to land.May 18 2018, 1:34 PM
mclow.lists added inline comments.May 18 2018, 2:01 PM
include/array
75

we do.

361

If we SFINAE it, then we'll get a hard error; because there are no other deduction guides.

test/std/containers/sequences/array/array.cons/deduct.fail.cpp
12

OK

mclow.lists closed this revision.May 18 2018, 2:05 PM

Committed as revision 332768