[clang] Switch to LLVM_ENABLE_IDE

[smeenai]

Summary

r344555 switched LLVM to guarding install targets with LLVM_ENABLE_IDE
instead of CMAKE_CONFIGURATION_TYPES, which expresses the intent more
directly and can be overridden by a user. Make the corresponding change
in clang. LLVM_ENABLE_IDE is computed by HandleLLVMOptions, so it should
be available for both standalone and integrated builds.

[smeenai]

CC @lebedev.ri, since I believe you raised some issues during the corresponding LLVM change but those were addressed.

[lebedev.ri]

In D58284#1399443, @smeenai wrote:

CC @lebedev.ri, since I believe you raised some issues during the corresponding LLVM change but those were addressed.

Yeah, i don't think i have any comments here.
The logic to pick the default of LLVM_ENABLE_IDE (based on the existence of CMAKE_CONFIGURATION_TYPES) seems hacky,
but it indeed does not currently detect QtCreator's CMake integration as "IDE", so i don't have any additional concerns,
this looks like a straight-forward cleanup.

What i do have concerns about, is that LLVM_ENABLE_IDE is not documented in https://llvm.org/docs/CMake.html

[smeenai]

In D58284#1399446, @lebedev.ri wrote:

In D58284#1399443, @smeenai wrote:

CC @lebedev.ri, since I believe you raised some issues during the corresponding LLVM change but those were addressed.

Yeah, i don't think i have any comments here.
The logic to pick the default of LLVM_ENABLE_IDE (based on the existence of CMAKE_CONFIGURATION_TYPES) seems hacky,
but it indeed does not currently detect QtCreator's CMake integration as "IDE", so i don't have any additional concerns,
this looks like a straight-forward cleanup.

What i do have concerns about, is that LLVM_ENABLE_IDE is not documented in https://llvm.org/docs/CMake.html

Good point. Added documentation in D58286.

[phosek]

LGTM

cfe/trunk/CMakeLists.txt

 if( CLANG_INCLUDE_DOCS )
   add_subdirectory(docs)
 endif()
 
 # Custom target to install all clang libraries.
 add_custom_target(clang-libraries)
 set_target_properties(clang-libraries PROPERTIES FOLDER "Misc")
 
-if(NOT CMAKE_CONFIGURATION_TYPES)
+if(NOT LLVM_ENABLE_IDE)
   add_llvm_install_targets(install-clang-libraries
                            DEPENDS clang-libraries
                            COMPONENT clang-libraries)
 endif()
 
 get_property(CLANG_LIBS GLOBAL PROPERTY CLANG_LIBS)
 if(CLANG_LIBS)
   list(REMOVE_DUPLICATES CLANG_LIBS)
   foreach(lib ${CLANG_LIBS})
     add_dependencies(clang-libraries ${lib})
-    if(NOT CMAKE_CONFIGURATION_TYPES)
+    if(NOT LLVM_ENABLE_IDE)
       add_dependencies(install-clang-libraries install-${lib})
     endif()
   endforeach()
 endif()
 
 add_subdirectory(cmake/modules)
 
 if(CLANG_STAGE)

cfe/trunk/cmake/modules/AddClang.cmake

if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY OR ${name} STREQUAL "libclang")
 
       install(TARGETS ${name}
         COMPONENT ${name}
         ${export_to_clangtargets}
         LIBRARY DESTINATION lib${LLVM_LIBDIR_SUFFIX}
         ARCHIVE DESTINATION lib${LLVM_LIBDIR_SUFFIX}
         RUNTIME DESTINATION bin)
 
-      if (NOT CMAKE_CONFIGURATION_TYPES)
+      if (NOT LLVM_ENABLE_IDE)
         add_llvm_install_targets(install-${name}
                                  DEPENDS ${name}
                                  COMPONENT ${name})
       endif()
 
       set_property(GLOBAL APPEND PROPERTY CLANG_LIBS ${name})
     endif()
     set_property(GLOBAL APPEND PROPERTY CLANG_EXPORTS ${name})
if(${name} IN_LIST LLVM_DISTRIBUTION_COMPONENTS OR
       set_property(GLOBAL PROPERTY CLANG_HAS_EXPORTS True)
     endif()
 
     install(TARGETS ${name}
       ${export_to_clangtargets}
       RUNTIME DESTINATION bin
       COMPONENT ${name})
 
-    if(NOT CMAKE_CONFIGURATION_TYPES)
+    if(NOT LLVM_ENABLE_IDE)
       add_llvm_install_targets(install-${name}
                                DEPENDS ${name}
                                COMPONENT ${name})
     endif()
     set_property(GLOBAL APPEND PROPERTY CLANG_EXPORTS ${name})
   endif()
 endmacro()
 
 macro(add_clang_symlink name dest)
   add_llvm_tool_symlink(${name} ${dest} ALWAYS_GENERATE)
   # Always generate install targets
   llvm_install_symlink(${name} ${dest} ALWAYS_GENERATE)
 endmacro()

cfe/trunk/lib/Headers/CMakeLists.txt

install(
   DESTINATION lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/include)
 
 install(
   FILES ${cuda_wrapper_files}
   COMPONENT clang-headers
   PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
   DESTINATION lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/include/cuda_wrappers)
 
-if (NOT CMAKE_CONFIGURATION_TYPES) # don't add this for IDE's.
+if (NOT LLVM_ENABLE_IDE)
   add_llvm_install_targets(install-clang-headers
                            DEPENDS clang-headers
                            COMPONENT clang-headers)
 endif()

cfe/trunk/tools/c-index-test/CMakeLists.txt

if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
   else()
     set(INSTALL_DESTINATION bin)
   endif()
 
   install(TARGETS c-index-test
     RUNTIME DESTINATION "${INSTALL_DESTINATION}"
     COMPONENT c-index-test)
 
-  if (NOT CMAKE_CONFIGURATION_TYPES) # don't add this for IDE's.
+  if (NOT LLVM_ENABLE_IDE)
     add_llvm_install_targets(install-c-index-test
                              DEPENDS c-index-test
                              COMPONENT c-index-test)
   endif()
 endif()

cfe/trunk/tools/diagtool/CMakeLists.txt

target_link_libraries(diagtool
   clangFrontend
   )
 
 if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
   install(TARGETS diagtool
     COMPONENT diagtool
     RUNTIME DESTINATION bin)
 
-  if (NOT CMAKE_CONFIGURATION_TYPES)
+  if (NOT LLVM_ENABLE_IDE)
     add_llvm_install_targets(install-diagtool
       DEPENDS diagtool
       COMPONENT diagtool)
   endif()
 endif()

cfe/trunk/tools/libclang/CMakeLists.txt

install(DIRECTORY ../../include/clang-c
   )
 
 # LLVM_DISTRIBUTION_COMPONENTS requires that each component have both a
 # component and an install-component target, so add a dummy libclang-headers
 # target to allow using it in LLVM_DISTRIBUTION_COMPONENTS.
 add_custom_target(libclang-headers)
 set_target_properties(libclang-headers PROPERTIES FOLDER "Misc")
 
-if (NOT CMAKE_CONFIGURATION_TYPES) # don't add this for IDE's.
+if (NOT LLVM_ENABLE_IDE)
   add_llvm_install_targets(install-libclang-headers
                            COMPONENT libclang-headers)
 endif()
 
 # Create a target to install the python bindings to make them easier to
 # distribute.  Since the bindings are over libclang, which is installed
 # unbundled to the clang version, follow suit.
 foreach(PythonVersion ${CLANG_PYTHON_BINDINGS_VERSIONS})
   install(DIRECTORY
             ${CMAKE_CURRENT_SOURCE_DIR}/../../bindings/python/clang
           COMPONENT
             libclang-python-bindings
           DESTINATION
             "lib${LLVM_LIBDIR_SUFFIX}/python${PythonVersion}/site-packages")
 endforeach()
-if(NOT CMAKE_CONFIGURATION_TYPES)
+if(NOT LLVM_ENABLE_IDE)
   add_custom_target(libclang-python-bindings)
   add_llvm_install_targets(install-libclang-python-bindings
                            COMPONENT
                              libclang-python-bindings)
 endif()