This is an archive of the discontinued LLVM Phabricator instance.

Add Triple::isAMDGPU
ClosedPublic

Authored by yaxunl on Feb 4 2019, 12:29 PM.

Details

Summary

I have been bothered by missing Triple::isAMDGPU for long time. There is isNVPTX, isARM,
why can't we have isAMDGPU?

Diff Detail

Event Timeline

yaxunl created this revision.Feb 4 2019, 12:29 PM
This revision is now accepted and ready to land.Feb 4 2019, 12:30 PM

Needs unit test

yaxunl updated this revision to Diff 185136.Feb 4 2019, 12:46 PM

add usage of it

Needs unit test

I used it in TargetLibraryInfo.cpp. We have lit tests cover them, so they also cover this function.

arsenm accepted this revision.Mar 19 2020, 4:38 PM
arsenm resigned from this revision.Mar 19 2020, 4:38 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2020, 11:45 AM
Herald added a subscriber: hiraditya. · View Herald Transcript