Allow old toolchain on sanitizer-windows

[jfb]

Summary

As requested by @rnk in D57264, allow old toolchain for the sanitizer-windows bot. This will break once we move to actually using C++ versions which the old toolchains don't support.

[jyknight]

I've no idea whether buildbot auto-updates or if it requires someone to go manually poke it, but this at least looks reasonable.

[jfb]

In D57525#1379209, @jyknight wrote:

I've no idea whether buildbot auto-updates or if it requires someone to go manually poke it, but this at least looks reasonable.

It'll be obvious from the cmake invocation whether it worked next time the bot runs:
http://lab.llvm.org:8011/buildslaves/sanitizer-windows

I'll just monitor that.

[jfb]

It looks like the latest build didn't pick up the change:

Running: cmake "-DLLVM_LIT_ARGS=-sv -j 16" -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PDB=ON -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_C_COMPILER=cl -DCMAKE_CXX_COMPILER=cl "C:\\b\\slave\\sanitizer-windows\\build\\llvm.src"

@rnk do you know what's up with that? Looks like I need to put it in the stage1 args?

[jfb]

In D57525#1379506, @jfb wrote:

It looks like the latest build didn't pick up the change:

Running: cmake "-DLLVM_LIT_ARGS=-sv -j 16" -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PDB=ON -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_C_COMPILER=cl -DCMAKE_CXX_COMPILER=cl "C:\\b\\slave\\sanitizer-windows\\build\\llvm.src"

@rnk do you know what's up with that? Looks like I need to put it in the stage1 args?

Alright I moved it to stage1 in r352808 (which it seems should work for both).

[jfb]

In D57525#1379602, @jfb wrote:

Alright I moved it to stage1 in r352808 (which it seems should work for both).

The latest builds have this new flag, so all seems good to go.

[rnk]

Thanks! It looks like @gkistanova restarted the master and the annotator script worked on the first try. That is, unless someone did more work to get it going. I wasn't around for the restart. If so, that is amazing.

zorg/trunk/zorg/buildbot/builders/annotated/sanitizer-windows.py

def main(argv):
     stage1_extra_cmake_args = [
         '-DCMAKE_BUILD_TYPE=Release',
         '-DLLVM_ENABLE_PDB=ON',
         '-DLLVM_ENABLE_ASSERTIONS=ON',
         '-DLLVM_TARGETS_TO_BUILD=X86',
     ]
     extra_cmake_args = stage1_extra_cmake_args + [
         '-DLLVM_USE_LINKER=lld',
+        '-DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON',
     ]
     check_targets = ['check-asan', 'check-asan-dynamic', 'check-sanitizer',
                      'check-cfi']
 
     # These arguments are a bit misleading, they really mean use cl.exe for
     # stage1 instead of GCC.
     compiler = 'clang-cl'
     linker = 'lld-link'