Page MenuHomePhabricator

Allow old toolchain on sanitizer-windows
ClosedPublic

Authored by jfb on Jan 31 2019, 10:32 AM.

Details

Summary

As requested by @rnk in D57264, allow old toolchain for the sanitizer-windows bot. This will break once we move to actually using C++ versions which the old toolchains don't support.

Diff Detail

Repository
rL LLVM

Event Timeline

jfb created this revision.Jan 31 2019, 10:32 AM
jyknight accepted this revision.Jan 31 2019, 12:06 PM

I've no idea whether buildbot auto-updates or if it requires someone to go manually poke it, but this at least looks reasonable.

This revision is now accepted and ready to land.Jan 31 2019, 12:06 PM
This revision was automatically updated to reflect the committed changes.
jfb added a comment.Jan 31 2019, 1:33 PM

I've no idea whether buildbot auto-updates or if it requires someone to go manually poke it, but this at least looks reasonable.

It'll be obvious from the cmake invocation whether it worked next time the bot runs:
http://lab.llvm.org:8011/buildslaves/sanitizer-windows

I'll just monitor that.

jfb added a comment.EditedJan 31 2019, 2:10 PM

It looks like the latest build didn't pick up the change:

Running: cmake "-DLLVM_LIT_ARGS=-sv -j 16" -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PDB=ON -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_C_COMPILER=cl -DCMAKE_CXX_COMPILER=cl "C:\\b\\slave\\sanitizer-windows\\build\\llvm.src"

@rnk do you know what's up with that? Looks like I need to put it in the stage1 args?

jfb added a comment.Jan 31 2019, 2:49 PM
In D57525#1379506, @jfb wrote:

It looks like the latest build didn't pick up the change:

Running: cmake "-DLLVM_LIT_ARGS=-sv -j 16" -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PDB=ON -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_TARGETS_TO_BUILD=X86 -DCMAKE_C_COMPILER=cl -DCMAKE_CXX_COMPILER=cl "C:\\b\\slave\\sanitizer-windows\\build\\llvm.src"

@rnk do you know what's up with that? Looks like I need to put it in the stage1 args?

Alright I moved it to stage1 in r352808 (which it seems should work for both).

jfb added a comment.EditedJan 31 2019, 3:07 PM
In D57525#1379602, @jfb wrote:

Alright I moved it to stage1 in r352808 (which it seems should work for both).

The latest builds have this new flag, so all seems good to go.

Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2019, 3:07 PM
rnk added a comment.Jan 31 2019, 5:34 PM

Thanks! It looks like @gkistanova restarted the master and the annotator script worked on the first try. That is, unless someone did more work to get it going. I wasn't around for the restart. If so, that is amazing.