GlobalISel: Verify pointer casts

[arsenm]

Summary

Not sure if the old AArch64 tests should be just deleted or not.

[paquette]

I think this seems reasonable. LGTM.

[arsenm]

r352562

lib/CodeGen/MachineVerifier.cpp

case TargetOpcode::G_BITCAST: {
 
     if (SrcTy.isPointer() != DstTy.isPointer())
       report("bitcast cannot convert between pointers and other types", MI);
 
     if (SrcTy.getSizeInBits() != DstTy.getSizeInBits())
       report("bitcast sizes must match", MI);
     break;
   }
+  case TargetOpcode::G_INTTOPTR:
+  case TargetOpcode::G_PTRTOINT:
+  case TargetOpcode::G_ADDRSPACE_CAST: {
+    LLT DstTy = MRI->getType(MI->getOperand(0).getReg());
+    LLT SrcTy = MRI->getType(MI->getOperand(1).getReg());
+    if (!DstTy.isValid() || !SrcTy.isValid())
+      break;
+
+    if (DstTy.isVector() != SrcTy.isVector())
+      report("pointer casts must be all-vector or all-scalar", MI);
+    else {
+      if (DstTy.isVector() ) {
+        if (DstTy.getNumElements() != SrcTy.getNumElements()) {
+          report("pointer casts must preserve number of elements", MI);
+          break;
+        }
+      }
+    }
+
+    DstTy = DstTy.getScalarType();
+    SrcTy = SrcTy.getScalarType();
+
+    if (MI->getOpcode() == TargetOpcode::G_INTTOPTR) {
+      if (!DstTy.isPointer())
+        report("inttoptr result type must be a pointer", MI);
+      if (SrcTy.isPointer())
+        report("inttoptr source type must not be a pointer", MI);
+    } else if (MI->getOpcode() == TargetOpcode::G_PTRTOINT) {
+      if (!SrcTy.isPointer())
+        report("ptrtoint source type must be a pointer", MI);
+      if (DstTy.isPointer())
+        report("ptrtoint result type must not be a pointer", MI);
+    } else {
+      assert(MI->getOpcode() == TargetOpcode::G_ADDRSPACE_CAST);
+      if (!SrcTy.isPointer() || !DstTy.isPointer())
+        report("addrspacecast types must be pointers", MI);
+      else {
+        if (SrcTy.getAddressSpace() == DstTy.getAddressSpace())
+          report("addrspacecast must convert different address spaces", MI);
+      }
+    }
+
+    break;
+  }
   case TargetOpcode::G_SEXT:
   case TargetOpcode::G_ZEXT:
   case TargetOpcode::G_ANYEXT:
   case TargetOpcode::G_TRUNC:
   case TargetOpcode::G_FPEXT:
   case TargetOpcode::G_FPTRUNC: {
     // Number of operands and presense of types is already checked (and
     // reported in case of any issues), so no need to report them again. As

test/CodeGen/AArch64/GlobalISel/legalize-inttoptr-xfail-1.mir

 # subtle bug in its definition that caused it to accept the following
 # MIR as legal. Namely, it checked that type index 0 is either s64 or
 # p0 (in that order) and implicitly declared any type for type index 1
 # as legal. As LegalizerInfo::verify asserts on such a definition due
 # to type index 1 not being covered it forces to review the definition
 # and fix the mistake: check that type index 0 is p0 and type index 1
 # is s64 (in that order).
 
-# CHECK:      LLVM ERROR: unable to legalize instruction:
-# CHECK-SAME: %{{[0-9]+}}:_(s64) = G_INTTOPTR %{{[0-9]+}}:_(p0)
-# CHECK-SAME: (in function: broken)
+# CHECK:  Bad machine code: inttoptr result type must be a pointer
+# CHECK: Bad machine code: inttoptr source type must not be a pointer
+# CHECK: LLVM ERROR: Found 2 machine code errors.
 
 ---
 name:            broken
 alignment:       2
 tracksRegLiveness: true
 registers:
   - { id: 0, class: _ }
   - { id: 1, class: _ }

test/CodeGen/AArch64/GlobalISel/legalize-inttoptr-xfail-2.mir

 # Namely, it checked that type index 0 is either s64 or p0 and
 # implicitly declared any type for type index 1 as legal (as soon as
 # its size is 64 bits). As LegalizerInfo::verify asserts on such a
 # definition due to type index 1 not being covered by a specific
 # action (not just `unsupportedIf`) it forces to review the definition
 # and fix the mistake: check that type index 0 is p0 and type index 1
 # is s64.
 
-# CHECK:      LLVM ERROR: unable to legalize instruction:
-# CHECK-SAME: %{{[0-9]+}}:_(p0) = G_INTTOPTR %{{[0-9]+}}:_(<4 x s16>)
-# CHECK-SAME: (in function: broken)
+# CHECK: Bad machine code: pointer casts must be all-vector or all-scalar
+# CHECK: LLVM ERROR: Found 1 machine code errors.
 
 ---
 name:            broken
 alignment:       2
 tracksRegLiveness: true
 registers:
   - { id: 0, class: _ }
   - { id: 1, class: _ }

test/CodeGen/AMDGPU/GlobalISel/regbankselect-ptrtoint.mir

 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
 # RUN: llc -march=amdgcn -run-pass=regbankselect %s -verify-machineinstrs -o - -regbankselect-fast | FileCheck %s
 # RUN: llc -march=amdgcn -run-pass=regbankselect %s -verify-machineinstrs -o - -regbankselect-greedy | FileCheck %s
 
 ---
 name: ptrtoint_s
 legalized: true
 
 body: |
   bb.0:
     liveins: $sgpr0_sgpr1
     ; CHECK-LABEL: name: ptrtoint_s
-    ; CHECK: [[COPY:%[0-9]+]]:sgpr(s64) = COPY $sgpr0_sgpr1
-    ; CHECK: [[PTRTOINT:%[0-9]+]]:sgpr(p4) = G_PTRTOINT [[COPY]](s64)
-    %0:_(s64) = COPY $sgpr0_sgpr1
-    %1:_(p4) = G_PTRTOINT %0
+    ; CHECK: [[COPY:%[0-9]+]]:sgpr(p1) = COPY $sgpr0_sgpr1
+    ; CHECK: [[PTRTOINT:%[0-9]+]]:sgpr(s64) = G_PTRTOINT [[COPY]](p1)
+    %0:_(p1) = COPY $sgpr0_sgpr1
+    %1:_(s64) = G_PTRTOINT %0
 ...
 
 ---
 name: ptrtoint_v
 legalized: true
 
 body: |
   bb.0:
     liveins: $vgpr0_vgpr1
     ; CHECK-LABEL: name: ptrtoint_v
-    ; CHECK: [[COPY:%[0-9]+]]:vgpr(s64) = COPY $vgpr0_vgpr1
-    ; CHECK: [[PTRTOINT:%[0-9]+]]:vgpr(p0) = G_PTRTOINT [[COPY]](s64)
-    %0:_(s64) = COPY $vgpr0_vgpr1
-    %1:_(p0) = G_PTRTOINT %0
+    ; CHECK: [[COPY:%[0-9]+]]:vgpr(p1) = COPY $vgpr0_vgpr1
+    ; CHECK: [[PTRTOINT:%[0-9]+]]:vgpr(s64) = G_PTRTOINT [[COPY]](p1)
+    %0:_(p1) = COPY $vgpr0_vgpr1
+    %1:_(s64) = G_PTRTOINT %0
 ...

test/Verifier/test_g_addrspacecast.mir

+#RUN: not llc -o -  -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
+# REQUIRES: global-isel, aarch64-registered-target
+
+---
+name:            test_addrspacecast
+legalized:       true
+regBankSelected: false
+selected:        false
+tracksRegLiveness: true
+liveins:
+body:             |
+  bb.0:
+
+    %0:_(s64) = G_IMPLICIT_DEF
+    %1:_(p0) = G_IMPLICIT_DEF
+    %2:_(<2 x s64>) = G_IMPLICIT_DEF
+    %3:_(<2 x p0>) = G_IMPLICIT_DEF
+
+    ; CHECK: Bad machine code: Too few operands
+    %4:_(s64) = G_ADDRSPACE_CAST
+
+    ; CHECK: Bad machine code: Too few operands
+    ; CHECK: Bad machine code: Explicit definition marked as use
+    G_ADDRSPACE_CAST %1
+
+    ; CHECK: Bad machine code: addrspacecast types must be pointers
+    %5:_(p0) = G_ADDRSPACE_CAST %0
+
+    ; CHECK: Bad machine code: addrspacecast types must be pointers
+    %6:_(s64) = G_ADDRSPACE_CAST %1
+
+    ; CHECK: Bad machine code: addrspacecast types must be pointers
+    %7:_(<2 x s64>) = G_ADDRSPACE_CAST %1
+
+    ; CHECK: Bad machine code: addrspacecast types must be pointers
+    %8:_(<2 x p0>) = G_ADDRSPACE_CAST %2
+
+    ; CHECK: Bad machine code: pointer casts must be all-vector or all-scalar
+    %9:_(<2 x p1>) = G_ADDRSPACE_CAST %1
+
+    ; CHECK: Bad machine code: pointer casts must be all-vector or all-scalar
+    %10:_(p1) = G_ADDRSPACE_CAST %3
+
+    ; CHECK: Bad machine code: pointer casts must preserve number of elements
+    %11:_(<4 x p1>) = G_ADDRSPACE_CAST %3
+
+    ; CHECK: Bad machine code: pointer casts must preserve number of elements
+    %12:_(<4 x p1>) = G_IMPLICIT_DEF
+    %13:_(<2 x p0>) = G_ADDRSPACE_CAST %12
+
+    ; CHECK: Bad machine code: addrspacecast must convert different address spaces
+    %14:_(p0) = G_ADDRSPACE_CAST %1
+
+    ; CHECK: Bad machine code: addrspacecast must convert different address spaces
+    %15:_(<2 x p0>) = G_ADDRSPACE_CAST %3
+
+...

test/Verifier/test_g_inttoptr.mir

+#RUN: not llc -o -  -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
+# REQUIRES: global-isel, aarch64-registered-target
+
+---
+name:            test_inttoptr
+legalized:       true
+regBankSelected: false
+selected:        false
+tracksRegLiveness: true
+liveins:
+body:             |
+  bb.0:
+
+    %0:_(s64) = G_IMPLICIT_DEF
+    %1:_(p0) = G_IMPLICIT_DEF
+    %2:_(<2 x s64>) = G_IMPLICIT_DEF
+    %3:_(<2 x p0>) = G_IMPLICIT_DEF
+
+    ; CHECK: Bad machine code: Too few operands
+    %4:_(p0) = G_INTTOPTR
+
+    ; CHECK: Bad machine code: Too few operands
+    ; CHECK: Bad machine code: Explicit definition marked as use
+    G_INTTOPTR %0
+
+    ; CHECK: Bad machine code: inttoptr result type must be a pointer
+    %5:_(s64) = G_INTTOPTR %0
+
+    ; CHECK: Bad machine code: inttoptr result type must be a pointer
+    %6:_(<2 x s64>) = G_INTTOPTR %2
+
+    ; CHECK: Bad machine code: pointer casts must be all-vector or all-scalar
+    %7:_(<2 x p0>) = G_INTTOPTR %0
+
+    ; CHECK: Bad machine code: pointer casts must be all-vector or all-scalar
+    %8:_(p0) = G_INTTOPTR %2
+
+    ; CHECK: Bad machine code: pointer casts must preserve number of elements
+    %9:_(<4 x p0>) = G_INTTOPTR %2
+
+    ; CHECK: Bad machine code: pointer casts must preserve number of elements
+    %10:_(<4 x s64>) = G_IMPLICIT_DEF
+    %11:_(<2 x p0>) = G_INTTOPTR %10
+
+...

test/Verifier/test_g_ptrtoint.mir

+#RUN: not llc -o -  -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
+# REQUIRES: global-isel, aarch64-registered-target
+
+---
+name:            test_ptrtoint
+legalized:       true
+regBankSelected: false
+selected:        false
+tracksRegLiveness: true
+liveins:
+body:             |
+  bb.0:
+
+    %0:_(s64) = G_IMPLICIT_DEF
+    %1:_(p0) = G_IMPLICIT_DEF
+    %2:_(<2 x s64>) = G_IMPLICIT_DEF
+    %3:_(<2 x p0>) = G_IMPLICIT_DEF
+
+    ; CHECK: Bad machine code: Too few operands
+    %4:_(s64) = G_PTRTOINT
+
+    ; CHECK: Bad machine code: Too few operands
+    ; CHECK: Bad machine code: Explicit definition marked as use
+    G_PTRTOINT %1
+
+    ; CHECK: Bad machine code: ptrtoint result type must not be a pointer
+    %5:_(p0) = G_PTRTOINT %1
+
+    ; CHECK: Bad machine code: ptrtoint result type must not be a pointer
+    %6:_(<2 x p0>) = G_PTRTOINT %0
+
+    ; CHECK: Bad machine code: ptrtoint source type must be a pointer
+    %7:_(<2 x s64>) = G_PTRTOINT %2
+
+    ; CHECK: Bad machine code: pointer casts must be all-vector or all-scalar
+    %8:_(s64) = G_PTRTOINT %3
+
+    ; CHECK: Bad machine code: pointer casts must preserve number of elements
+    %9:_(<4 x s64>) = G_INTTOPTR %3
+
+    ; CHECK: Bad machine code: pointer casts must preserve number of elements
+    %10:_(<4 x p0>) = G_IMPLICIT_DEF
+    %11:_(<2 x s64>) = G_PTRTOINT %10
+
+...