Details
Diff Detail
Event Timeline
| include/llvm/CodeGen/GlobalISel/LegalizerHelper.h | ||
|---|---|---|
| 129 | Comment? | |
| lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
| 1636 | Maybe we should assert that Size >= NarrowSize? | |
| 1669–1670 | Can this just be an else if? | |
| 1675 | Out of curiosity, could NumParts ever be 0 for some reason? If so, what would that mean? | |
| 1685 | Can we have a comment explaining what this lambda is doing, just for a small mental breather? :P | |
| 1692 | Offset/8 is used a few places here, maybe make it a variable? | |
| 1705 | Can we have a comment here? | |
| lib/CodeGen/GlobalISel/LegalizerHelper.cpp | ||
|---|---|---|
| 1702 | The alignment isn't used here. The base alignment is copied from the MMO, and the effective alignment is computed from the base alignment + the offset. | |
Comment?