Page MenuHomePhabricator

Make more allocator methods work correctly with in an out-of-process mode.
ClosedPublic

Authored by delcypher on Jan 19 2019, 10:41 AM.

Details

Summary

This makes GetBlockBegin() and GetBlockBeginFastLocked() work correctly with RemoteAddressSpaceView.

This has a knock on effect of also making the PointerIsMine() and
GetMetaData() methods behave correctly when RemoteAddressSpaceView
is used to instantiate the allocators.

This will be used by future out-of-process allocator enumeration
patches.

rdar://problem/45284065

Event Timeline

delcypher created this revision.Jan 19 2019, 10:41 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptJan 19 2019, 10:41 AM
delcypher edited the summary of this revision. (Show Details)Jan 20 2019, 8:25 AM

@vitalybuka In https://reviews.llvm.org/D57279 it looks like you're looking at performing a refactor. Could we land this first? I realise this is addressing my patch series out-of-order but this patches doesn't actually depend on the prior two patches (https://reviews.llvm.org/D56207 and https://reviews.llvm.org/D56206) in the review series.

This revision is now accepted and ready to land.Jan 26 2019, 1:35 PM
This revision was automatically updated to reflect the committed changes.