[llvm-symbolizer] Add -C as a short alias to -demangle

[Quolyk]

Summary

Provides -C as alias to -demangle. Motivation: https://bugs.llvm.org/show_bug.cgi?id=40069.

[Quolyk]

I cannot have DIA SDK on my computer. As I see @jhenderson you have a Windows computer. Could you please write if tests are correct and in the right place. If there is a way to test it without DIA SDK any advice would be helpful.

[jhenderson]

Could you add an ELF test for this too, please, to show the route through the Itanium demangler (and when it doesn't go through it for -C=false)?

Unfortunately, it looks like I don't have a pre-requisite either, so the pdb test is unsupported for me too. The test change looks safe, but adding the ELF test as well would give the extra reassurance.

[Quolyk]

Add test

[Quolyk]

In D56591#1354067, @jhenderson wrote:

Could you add an ELF test for this too, please, to show the route through the Itanium demangler (and when it doesn't go through it for -C=false)?

Unfortunately, it looks like I don't have a pre-requisite either, so the pdb test is unsupported for me too. The test change looks safe, but adding the ELF test as well would give the extra reassurance.

How do i call itanium demangler? AFAIK llvm-symbolizer only accepts bool value of -demangle flag.

[jhenderson]

The Itanium demangler is used typically for ELF C++ symbols. If you take a look at test/tools/llvm-objdump/X86/demangle.s, you can see how the (de-)mangling happens. test/DebugInfo/llvm-symbolizer.test also uses the --demangle switch, and you could extend it to add -C alongside the demangle=false case or similar, if you want.

[ruiu]

test/tools/llvm-symbolizer/pdb/pdb.test

8

This is not a new test because we have a test that exercises -demangle=false, but what is the "false" format style? addr2line reports an error if an argument given to --demangle or -C is not known.

[jhenderson]

test/DebugInfo/llvm-symbolizer.test

218 ↗

(On Diff #181509)

You don't need a new check-prefix. You can reuse the existing one. You also don't need to recreate %t.input7.

test/tools/llvm-symbolizer/pdb/pdb.test

8

Interesting catch. That wasn't something I noticed. llvm-symbolizer treats --demangle (and therefore -C) as a boolean switch, rather than one that takes a style, i.e. --demangle=false disables demangling.

It's worth noting that unlike addr2line, demangling is on by default too, so this switch only needs to exist for a) compatibility, and b) so that demangling can be disabled, unless we change the default (which could break people's workflows...).

[Quolyk]

Update tests

[jhenderson]

LGTM. I'm happy with this, but I'd like @ruiu to give a final thumbs up with relation to his comment.

[ruiu]

LGTM

docs/CommandGuide/llvm-symbolizer.rst

.. option:: -functions=[none|short|linkage]
   print short function name, or print full linkage name, respectively).
   Defaults to ``linkage``.
 
 .. option:: -use-symbol-table
 
  Prefer function names stored in symbol table to function names
  in debug info sections. Defaults to true.
 
-.. option:: -demangle
+.. option:: -demangle, -C
 
  Print demangled function names. Defaults to true.
 
 .. option:: -inlining 
 
  If a source code location is in an inlined function, prints all the
  inlnied frames. Defaults to true.
 

test/tools/llvm-symbolizer/pdb/pdb.test

 RUN: grep '^ADDR:' %s | sed -s 's/ADDR: //' \
 RUN:  | llvm-symbolizer -obj="%p/Inputs/test.exe" \
 RUN:    | FileCheck %s
 RUN: grep '^ADDR:' %s | sed -s 's/ADDR: //' \
 RUN:  | llvm-symbolizer -obj="%p/Inputs/test.exe" -demangle=false \
 RUN:  | FileCheck %s --check-prefix=CHECK-NO-DEMANGLE
+RUN: grep '^ADDR:' %s | sed -s 's/ADDR: //' \
+RUN:  | llvm-symbolizer -obj="%p/Inputs/test.exe" -C=false \
+RUN:  | FileCheck %s --check-prefix=CHECK-NO-DEMANGLE
 
 Subtract ImageBase from all the offsets and run the test again with
 --relative-address.
 
 RUN: grep '^ADDR:' %s | sed -s 's/ADDR: //' \
 RUN:  | %python -c 'import sys;print("\n".join([hex(int(x, 16) - 0x400000) for x in sys.stdin]))' \
 RUN:  | llvm-symbolizer -obj="%p/Inputs/test.exe" -demangle=false --relative-address \
 RUN:    | FileCheck %s --check-prefix=CHECK-NO-DEMANGLE

tools/llvm-symbolizer/llvm-symbolizer.cpp

static cl::opt<bool>
     ClUseRelativeAddress("relative-address", cl::init(false),
                          cl::desc("Interpret addresses as relative addresses"),
                          cl::ReallyHidden);
 
 static cl::opt<bool>
     ClPrintInlining("inlining", cl::init(true),
                     cl::desc("Print all inlined frames for a given address"));
 
+// -demangle, -C
 static cl::opt<bool>
 ClDemangle("demangle", cl::init(true), cl::desc("Demangle function names"));
+static cl::alias
+ClDemangleShort("C", cl::desc("Alias for -demangle"),
+                cl::NotHidden, cl::aliasopt(ClDemangle));
 
 static cl::opt<std::string> ClDefaultArch("default-arch", cl::init(""),
                                           cl::desc("Default architecture "
                                                    "(for multi-arch objects)"));
 
 // -obj, -exe, -e
 static cl::opt<std::string>
 ClBinaryName("obj", cl::init(""),