Update. Solution is not elegant, because DeclRef->BaseRange somehow has zero length.

Minor update

Add NoBuiltin tests.

Use NoBuiltin

Add negative tests

Update

Add unit tests

In D42047#1164773, @lebedev.ri wrote:

In D42047#1164770, @Quolyk wrote:

In D42047#1164762, @lebedev.ri wrote:

Is it possible to add some unit test for this?

I have not seen that this header is explicitly tested, but it can be tested througn some libFunc pattern matches, as I hope to introduce some using this

unittests/IR/PatternMatch.cpp

Use TargetLibraryInfo::getLibFunc.

Update tests. Apply patch only for pow multiplications. Pow divisions will be considered in different patch.

In D41940#1378402, @lebedev.ri wrote:

LG unless others have more comments (@spatel ?)
You probably know this already, but there are some other low-hanging fruit here, e.g.
https://godbolt.org/z/Trdf_e
https://www.wolframalpha.com/input/?i=log2(x)+%2F+log2(10)+%3D+log10(x)

Update tests.

@spatel @lebedev.ri thank you for review and helping me get through.

Update tests.

Update tests.

LGTM.

I think we need to update docs as well.

Update test.

Move test to separate file.
llvm/test/tools/llvm-symbolizer/ and llvm/test/DebugInfo/llvm-symbolizer* pass successfully.

Ping.

Update tests.

@jhenderson thanks a lot for review and remarks. That is very valuable.

Used clang-format -style='{ReflowComments: true}'.

Update tests.

Update tests.

Update tests. Add logic. Honestly, I'm not good at writing llvm-symbolizer test, so I picked test that would fail if --demangle=true to test --demangle, --no-demangle order.
That doesn't mean I want to merge this patch as is. If more specific tests are needed I would be happy to dive into.

I'm not sure how do I handle situation when -demange and -no-demangle appear in one command. I mean what precedence to use.

Update tests

Patch is not yet fixed.

For now I just updated tests. The problem is in BaseRange definition, as it holds EndLoc and BeginLoc pointing to the beginning of ArrayExpression base https://github.com/llvm-mirror/clang-tools-extra/blob/e0441f6939da38f26bea9c1d75bb33024daa4e40/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp#L78. I'm investigating this.

In D56635#1355791, @jhenderson wrote:

In D56635#1355781, @jhenderson wrote:

I'll file a bug for it, as it's probably worth fixing this all in one go.

https://bugs.llvm.org/show_bug.cgi?id=40304

In D56591#1354067, @jhenderson wrote:

Could you add an ELF test for this too, please, to show the route through the Itanium demangler (and when it doesn't go through it for -C=false)?

Unfortunately, it looks like I don't have a pre-requisite either, so the pdb test is unsupported for me too. The test change looks safe, but adding the ELF test as well would give the extra reassurance.

Add test

Update tests. Handle length.

In D56644#1355434, @lebedev.ri wrote:

Either this is a NFC change with just tests, or the actual fix is missing.

For now, I just added tests. I have several questions, as I'm beginner (ContainerSizeEmptyCheck.cpp).

1. Do I have to extend ValidContainer, so it recognises ::std::string with length() method as valid container too or we can assume ::std::string as valid container by default?
2. If ::std::string is valid container, I just add one more expression to match. Is it correct way?

I cannot have DIA SDK on my computer. As I see @jhenderson you have a Windows computer. Could you please write if tests are correct and in the right place. If there is a way to test it without DIA SDK any advice would be helpful.

Update tests

FileCheck --check-prefix --> FileCheck -check-prefix

Add cl::NotHidden option

In D42047#1164762, @lebedev.ri wrote:

Is it possible to add some unit test for this?

Check if call isNoBuiltin

Ping

Ping

Up. I guess it still needs to be merged as it introduces pattern matching for LibFuncs that would be quite usefull.