Page MenuHomePhabricator

erik.pilkington (Erik Pilkington)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2016, 10:56 AM (218 w, 4 h)

Recent Activity

Today

erik.pilkington added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Ping!

Tue, Apr 7, 11:23 AM
erik.pilkington accepted D77586: Allow parameter names to be elided in a function definition in C.

This also adds the same feature to ObjC blocks under the assumption that ObjC wishes to follow the C standard in this regard.

Tue, Apr 7, 8:39 AM

Yesterday

erik.pilkington committed rGd33c7de8e11f: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a… (authored by erik.pilkington).
[CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a…
Mon, Apr 6, 1:05 PM
erik.pilkington closed D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct.
Mon, Apr 6, 1:05 PM · Restricted Project
erik.pilkington updated the diff for D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct.

Don't bother including zero length bit-fields in the mangling of the copy/destroy helpers.

Mon, Apr 6, 10:18 AM · Restricted Project

Thu, Apr 2

erik.pilkington accepted D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

LGTM, sorry for the delay in reviewing this.

Thu, Apr 2, 11:55 AM · Restricted Project

Tue, Mar 31

erik.pilkington added inline comments to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.
Tue, Mar 31, 1:48 PM
erik.pilkington updated the diff for D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Address review comments.

Tue, Mar 31, 1:48 PM

Mon, Mar 30

erik.pilkington created D77070: [SemaObjC] Add a warning for declarations of BOOL:1 when BOOL is a signed char.
Mon, Mar 30, 9:43 AM

Wed, Mar 25

erik.pilkington created D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct.
Wed, Mar 25, 10:16 AM · Restricted Project

Tue, Mar 24

erik.pilkington committed rGde98cf92e301: [CodeGen] Add an alignment attribute to all sret parameters (authored by erik.pilkington).
[CodeGen] Add an alignment attribute to all sret parameters
Tue, Mar 24, 12:55 PM
erik.pilkington closed D74183: [IRGen] Add an alignment attribute to underaligned sret parameters.
Tue, Mar 24, 12:55 PM · Restricted Project

Mon, Mar 23

erik.pilkington accepted D76643: [objc_direct] also go through implementations when looking for clashes.

LGTM

Mon, Mar 23, 5:59 PM · Restricted Project
erik.pilkington added inline comments to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.
Mon, Mar 23, 7:36 AM
erik.pilkington updated the diff for D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Add tests for bit_cast<bool>((char)1);

Mon, Mar 23, 7:36 AM

Fri, Mar 20

erik.pilkington updated the diff for D74183: [IRGen] Add an alignment attribute to underaligned sret parameters.

Add alignment attribute to all sret parameters.

Fri, Mar 20, 5:22 PM · Restricted Project

Tue, Mar 17

erik.pilkington added inline comments to D75960: [libc++] Implement C++20's P0476r2: std::bit_cast.
Tue, Mar 17, 2:35 PM · Restricted Project
erik.pilkington created D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.
Tue, Mar 17, 2:35 PM

Fri, Mar 13

erik.pilkington added inline comments to D75960: [libc++] Implement C++20's P0476r2: std::bit_cast.
Fri, Mar 13, 10:44 AM · Restricted Project

Tue, Mar 10

erik.pilkington committed rG75af694a6da5: [CodeGenObjC] Place property names in __objc_methname (authored by erik.pilkington).
[CodeGenObjC] Place property names in __objc_methname
Tue, Mar 10, 2:48 PM
erik.pilkington added a comment to rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

This also fixes https://bugs.llvm.org/show_bug.cgi?id=44253. Is there any update on the ppc reproducer?

Tue, Mar 10, 12:33 PM

Mon, Mar 9

erik.pilkington committed rG7fbf15a8f2df: [CodeGenObjC] Privatize some ObjC metadata symbols (authored by erik.pilkington).
[CodeGenObjC] Privatize some ObjC metadata symbols
Mon, Mar 9, 4:13 PM
erik.pilkington closed D75491: [CodeGenObjC] Privatize some ObjC metadata symbols.
Mon, Mar 9, 4:13 PM · Restricted Project

Mar 2 2020

erik.pilkington committed rG29a4239d31c6: [Sema] Fix a crash when attaching comments to an implicit decl (authored by erik.pilkington).
[Sema] Fix a crash when attaching comments to an implicit decl
Mar 2 2020, 4:55 PM
erik.pilkington closed D75483: [Sema] Fix a crash when attaching comments to an implicit decl.
Mar 2 2020, 4:55 PM · Restricted Project
erik.pilkington added a comment to D75490: [clang] Skip implicit declarations when attaching doc comments.

It looks like this check is done already in getDeclLocForCommentSearch. Any reason to duplicate it?

Mar 2 2020, 4:55 PM
erik.pilkington created D75491: [CodeGenObjC] Privatize some ObjC metadata symbols.
Mar 2 2020, 4:38 PM · Restricted Project
erik.pilkington created D75483: [Sema] Fix a crash when attaching comments to an implicit decl.
Mar 2 2020, 2:56 PM · Restricted Project
erik.pilkington committed rGe392dcd5708b: [Sema] Look through OpaqueValueExpr when checking implicit conversions (authored by erik.pilkington).
[Sema] Look through OpaqueValueExpr when checking implicit conversions
Mar 2 2020, 11:38 AM
erik.pilkington closed D75387: [Sema] Look through OpaqueValueExpr when checking implicit conversions.
Mar 2 2020, 11:38 AM · Restricted Project

Feb 28 2020

erik.pilkington accepted D74417: [clang][ARC] Remove invalid assertion that can crash clangd.

Okay, I've added this, it seems to fix the test but I'm not sure if it's fully correct since the place where it was modified is under the VarDecl comment instead of ParmVarDecl.

Feb 28 2020, 4:16 PM · Restricted Project
erik.pilkington committed rG2e4f5e629de8: [Sema] Fix an assert when objc_externally_retained was applied to an… (authored by erik.pilkington).
[Sema] Fix an assert when objc_externally_retained was applied to an…
Feb 28 2020, 3:49 PM
erik.pilkington created D75387: [Sema] Look through OpaqueValueExpr when checking implicit conversions.
Feb 28 2020, 3:21 PM · Restricted Project

Feb 26 2020

erik.pilkington committed rG30f4362040fe: Disable memory leak checking in a test to work around a bot failure (authored by erik.pilkington).
Disable memory leak checking in a test to work around a bot failure
Feb 26 2020, 2:57 PM

Feb 14 2020

erik.pilkington accepted D73755: [objc_direct] Small updates to help with adoption..

LGTM, thanks.

Feb 14 2020, 3:52 PM · Restricted Project

Feb 13 2020

erik.pilkington added a comment to D74417: [clang][ARC] Remove invalid assertion that can crash clangd.

Added but it's still failing due to a different assertion failure, do you think this could be because the abbreviation is different for the ParamVars? I'm not sure how to handle this...

Feb 13 2020, 10:43 AM · Restricted Project

Feb 12 2020

erik.pilkington added inline comments to D73755: [objc_direct] Small updates to help with adoption..
Feb 12 2020, 4:58 PM · Restricted Project
erik.pilkington added a comment to D74417: [clang][ARC] Remove invalid assertion that can crash clangd.

This looks good, but please add a testcase.

Feb 12 2020, 3:27 PM · Restricted Project
erik.pilkington committed rGe26c24b84921: Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate argument… (authored by erik.pilkington).
Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate argument…
Feb 12 2020, 12:34 PM
erik.pilkington added a reverting change for rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas: rGe26c24b84921: Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate argument….
Feb 12 2020, 12:34 PM
erik.pilkington added a comment to rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

This patch broke our multistage bot during stage 2 build: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23546
We are investigating, please pull until we can provide a reproducer.

Feb 12 2020, 12:33 PM

Feb 10 2020

erik.pilkington accepted D74355: [ubsan] Null-check and adjust TypeLoc before using it.

LGTM!

Feb 10 2020, 2:06 PM · Restricted Project

Feb 7 2020

erik.pilkington committed rGfafc6e4fdf36: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas (authored by erik.pilkington).
[IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas
Feb 7 2020, 2:44 PM
erik.pilkington closed D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.
Feb 7 2020, 2:43 PM · Restricted Project
erik.pilkington added inline comments to D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.
Feb 7 2020, 11:39 AM · Restricted Project
erik.pilkington updated the diff for D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.

Disable the optimization for non-trivially destructible types.

Feb 7 2020, 11:21 AM · Restricted Project

Feb 6 2020

erik.pilkington created D74183: [IRGen] Add an alignment attribute to underaligned sret parameters.
Feb 6 2020, 4:53 PM · Restricted Project
erik.pilkington planned changes to D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.
Feb 6 2020, 12:05 PM · Restricted Project

Feb 5 2020

erik.pilkington created D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas.
Feb 5 2020, 3:11 PM · Restricted Project

Jan 16 2020

erik.pilkington added reviewers for D71566: New checks for fortified sprintf: aaron.ballman, rsmith.
Jan 16 2020, 9:48 PM · Restricted Project

Jan 9 2020

erik.pilkington committed rGeb9d2faaa3dc: Add support for constant discriminators in PointerAuthSchema (authored by erik.pilkington).
Add support for constant discriminators in PointerAuthSchema
Jan 9 2020, 4:55 PM
erik.pilkington committed rG771fed1834c9: NFC: get rid of the unnecessary union in PointerAuthSchema (authored by erik.pilkington).
NFC: get rid of the unnecessary union in PointerAuthSchema
Jan 9 2020, 4:55 PM
erik.pilkington committed rG183b5d38d7cf: [demangle] Copy back some NFC commits from LLVM (authored by erik.pilkington).
[demangle] Copy back some NFC commits from LLVM
Jan 9 2020, 10:43 AM

Dec 16 2019

erik.pilkington added a comment to D71566: New checks for fortified sprintf.

Thanks for working on this! I think this would be a really useful diagnostic to have.

Dec 16 2019, 5:03 PM · Restricted Project

Dec 12 2019

erik.pilkington committed rGfe0320826270: Fix mishandling of invalid-but-non-empty nested name specifiers in name… (authored by rsmith).
Fix mishandling of invalid-but-non-empty nested name specifiers in name…
Dec 12 2019, 3:55 PM
erik.pilkington committed rG328cafe7e862: Fix a compile error from a merge (authored by erik.pilkington).
Fix a compile error from a merge
Dec 12 2019, 2:40 PM
erik.pilkington committed rG9fac594889c1: Fix some internal fallout from r370379 (authored by erik.pilkington).
Fix some internal fallout from r370379
Dec 12 2019, 2:40 PM
erik.pilkington committed rG124de095c71b: Merge commit '96b6383be3e03fea6d7d498931163b49bf824ce3' into upstream-with-swift (authored by erik.pilkington).
Merge commit '96b6383be3e03fea6d7d498931163b49bf824ce3' into upstream-with-swift
Dec 12 2019, 2:39 PM
erik.pilkington committed rG8f376ab9e4dc: Revert a commit series that leads to a tricky merge until Jan can take a look. (authored by erik.pilkington).
Revert a commit series that leads to a tricky merge until Jan can take a look.
Dec 12 2019, 2:39 PM
erik.pilkington committed rGe62cb7a6f8f0: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by erik.pilkington).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:38 PM
erik.pilkington committed rG4bc87ab0a3a2: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by erik.pilkington).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:00 PM
erik.pilkington committed rG25c9acb62c65: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by erik.pilkington).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:34 PM
erik.pilkington committed rG7efef6ede5c7: Fix some failing tests (authored by erik.pilkington).
Fix some failing tests
Dec 12 2019, 11:48 AM

Dec 10 2019

erik.pilkington committed rGd5e66f0e060d: NFC: Get rid of an unused parameter to CGObjCMac::EmitSelectorAddr. (authored by erik.pilkington).
NFC: Get rid of an unused parameter to CGObjCMac::EmitSelectorAddr.
Dec 10 2019, 5:14 PM

Nov 20 2019

erik.pilkington committed rGd9957c7405bc: [Sema] Add a 'Semantic' parameter to Expr::isKnownToHaveBooleanValue (authored by erik.pilkington).
[Sema] Add a 'Semantic' parameter to Expr::isKnownToHaveBooleanValue
Nov 20 2019, 4:34 PM
erik.pilkington added a comment to rG8bfb353bb33c: [Sema] Fix a -Wobjc-signed-char-bool false-positive.

Yeah, I agree that -Wswitch-bool isn't appropriate there. I fixed this in d9957c7405bc726422dbc2736ad62f704916fbe8.

Nov 20 2019, 4:34 PM

Nov 18 2019

erik.pilkington accepted D70250: [llvm-cxxfilt] Improve strip-underscore behavior.

LGTM

Nov 18 2019, 2:37 PM · Restricted Project
erik.pilkington committed rG8bfb353bb33c: [Sema] Fix a -Wobjc-signed-char-bool false-positive (authored by erik.pilkington).
[Sema] Fix a -Wobjc-signed-char-bool false-positive
Nov 18 2019, 12:21 PM

Nov 4 2019

erik.pilkington committed rGaf11f417fc7d: [demangle] NFC: get rid of NodeOrString (authored by erik.pilkington).
[demangle] NFC: get rid of NodeOrString
Nov 4 2019, 12:22 PM

Nov 2 2019

erik.pilkington added inline comments to D50930: Move Itanium demangler implementation into a header file and add visitation support..
Nov 2 2019, 12:20 PM · Restricted Project
erik.pilkington added inline comments to D50930: Move Itanium demangler implementation into a header file and add visitation support..
Nov 2 2019, 11:53 AM · Restricted Project

Oct 7 2019

erik.pilkington closed D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type.
Oct 7 2019, 5:58 AM · Restricted Project

Oct 4 2019

erik.pilkington committed rGf7766b1ed41a: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic (authored by erik.pilkington).
[Sema] Split out -Wformat-type-confusion from -Wformat-pedantic
Oct 4 2019, 12:23 PM

Oct 3 2019

erik.pilkington added inline comments to D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic .
Oct 3 2019, 9:52 PM · Restricted Project, Restricted Project
erik.pilkington updated the diff for D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic .

Address review comments.

Oct 3 2019, 9:52 PM · Restricted Project, Restricted Project

Oct 2 2019

erik.pilkington added a comment to D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic .

Ping!

Oct 2 2019, 1:45 PM · Restricted Project, Restricted Project

Sep 30 2019

erik.pilkington accepted D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

Okay, LGTM.

Sep 30 2019, 11:15 AM · Restricted Project

Sep 24 2019

erik.pilkington planned changes to D67935: Add `#pragma clang deprecated`, used to deprecate macros.

Marking as "planned changes" to get this out of review queues. Aaron Ballman wants to add "macro attributes", which would be a better way of solving this problem, and is going to ask the C and C++ committees if there is an appetite for such an idea. This is blocked on getting that answer.

Sep 24 2019, 12:13 PM · Restricted Project

Sep 23 2019

erik.pilkington created D67935: Add `#pragma clang deprecated`, used to deprecate macros.
Sep 23 2019, 2:40 PM · Restricted Project
erik.pilkington committed rG2d225bbec1a0: NFC: Fix a poorly-written test (authored by erik.pilkington).
NFC: Fix a poorly-written test
Sep 23 2019, 10:17 AM
erik.pilkington added a comment to rL372533: [NFC] Fixed failed test.

Hi @erik.pilkington, as the author of https://reviews.llvm.org/D62825,

Did you mean

static_assert(i == (LITTLE_END ? 0x00000201 : 0x01020000), "");

?

(please re-check all ternary ops in this file)

Sep 23 2019, 10:15 AM

Sep 19 2019

erik.pilkington created D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic .
Sep 19 2019, 1:12 PM · Restricted Project, Restricted Project

Sep 18 2019

erik.pilkington committed rG5741d19f046f: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd (authored by erik.pilkington).
[Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd
Sep 18 2019, 12:08 PM
erik.pilkington added a comment to D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.

Ping!

Sep 18 2019, 11:08 AM · Restricted Project, Restricted Project

Sep 17 2019

erik.pilkington committed rG5c62152275c0: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C… (authored by erik.pilkington).
[Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C…
Sep 17 2019, 2:12 PM
erik.pilkington added inline comments to D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL.
Sep 17 2019, 2:11 PM · Restricted Project, Restricted Project
erik.pilkington committed rGa1e29a3407fb: Use 'BOOL' instead of BOOL in diagnostic messages (authored by erik.pilkington).
Use 'BOOL' instead of BOOL in diagnostic messages
Sep 17 2019, 11:03 AM
erik.pilkington added inline comments to D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL.
Sep 17 2019, 10:33 AM · Restricted Project, Restricted Project
erik.pilkington updated the diff for D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL.

Address review comments.

Sep 17 2019, 10:33 AM · Restricted Project, Restricted Project

Sep 13 2019

erik.pilkington created D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL.
Sep 13 2019, 9:15 AM · Restricted Project, Restricted Project

Sep 11 2019

erik.pilkington added a comment to D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.

The reflector discussion is still happening and there are issues with ambiguities that we are pretty sure we want to correct. I've got a paper out that touches on some of this: http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2420.pdf

Sep 11 2019, 2:58 PM · Restricted Project, Restricted Project
erik.pilkington updated the diff for D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.

Update the diagnostic text.

Sep 11 2019, 2:58 PM · Restricted Project, Restricted Project

Sep 10 2019

erik.pilkington updated the diff for D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.

Address review comments.

Sep 10 2019, 1:44 PM · Restricted Project, Restricted Project

Sep 9 2019

erik.pilkington added a comment to D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

I'm a bit curious about clients that use getCanonicalType() to get a full desugaring, instead of doing a single step. It seems like they'd still get the out of date type parameter type. Has that ever worked?

Sep 9 2019, 2:24 PM · Restricted Project

Aug 28 2019

erik.pilkington committed rG6c7687ed6770: Fix a passing XFAIL test (authored by erik.pilkington).
Fix a passing XFAIL test
Aug 28 2019, 3:38 PM
erik.pilkington added a comment to D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.

I'm wondering whether this should even warn pedantically. There are no format specifiers that apply directly to a _Bool datatype, so the user is left making a choice as to what specifier fits best. I think hhd and hhu are both equally reasonable types, as are the d and u groups directly -- I don't think we should warn on either of those specifiers with a _Bool argument. I could maybe see a case for pedantically diagnosing h, l, and ll prefixes with _Bool because that seems a bit type-confused to me. c as a specifier seems weird (given that false values will potentially terminate the string suddenly depending on terminal behavior, IIRC), but lc seems like type confusion again.

Aug 28 2019, 1:01 PM · Restricted Project, Restricted Project

Aug 27 2019

erik.pilkington created D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.
Aug 27 2019, 6:20 PM · Restricted Project, Restricted Project

Aug 22 2019

erik.pilkington accepted D66622: [Bugfix] fix r369705 unit test.

LGTM, thanks for fixing this!

Aug 22 2019, 3:49 PM · Restricted Project, Restricted Project

Aug 14 2019

erik.pilkington added a comment to D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression).

Hmm, looks like this patch fails to fix the case where we're referencing the variable in an non-odr use context, since we don't even bother to instantiate the initializer here:

Aug 14 2019, 11:17 AM · Restricted Project
erik.pilkington committed rGaa3855694ff4: [Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey (authored by erik.pilkington).
[Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey
Aug 14 2019, 10:00 AM