Page MenuHomePhabricator

erik.pilkington (Erik Pilkington)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2016, 10:56 AM (259 w, 4 d)

Recent Activity

Dec 16 2020

erik.pilkington committed rG95b2dab19910: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to… (authored by erik.pilkington).
[Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to…
Dec 16 2020, 7:02 AM
erik.pilkington committed rG92d6e8001e20: NFC: balance a quote in AttrDocs.td (authored by erik.pilkington).
NFC: balance a quote in AttrDocs.td
Dec 16 2020, 7:02 AM
erik.pilkington closed D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays.
Dec 16 2020, 7:02 AM · Restricted Project

Dec 14 2020

erik.pilkington requested review of D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays.
Dec 14 2020, 2:26 PM · Restricted Project

Dec 7 2020

erik.pilkington committed rG5a28e1d9e50e: [clang] Add support for attribute 'swift_async' (authored by erik.pilkington).
[clang] Add support for attribute 'swift_async'
Dec 7 2020, 2:20 PM
erik.pilkington committed rG9cd2413f1ca7: [clang] Add a new nullability annotation for swift async: _Nullable_result (authored by erik.pilkington).
[clang] Add a new nullability annotation for swift async: _Nullable_result
Dec 7 2020, 2:20 PM
erik.pilkington closed D92742: [clang] Add support for attribute 'swift_async'.
Dec 7 2020, 2:20 PM · Restricted Project
erik.pilkington closed D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .
Dec 7 2020, 2:20 PM · Restricted Project

Dec 6 2020

erik.pilkington requested review of D92742: [clang] Add support for attribute 'swift_async'.
Dec 6 2020, 6:38 PM · Restricted Project

Dec 4 2020

erik.pilkington accepted D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces.

LGTM

Dec 4 2020, 11:53 AM · Restricted Project
erik.pilkington added inline comments to D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .
Dec 4 2020, 10:09 AM · Restricted Project
erik.pilkington updated the diff for D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .

Address review comments.

Dec 4 2020, 10:09 AM · Restricted Project
erik.pilkington added a comment to D90871: [Sema] Fold VLAs to constant arrays in a few more contexts.

Looks like this breaks tests on Windows: http://45.33.8.238/win/29181/step_7.txt

PTAL, and revert while you investigate if it takes a while to fix.

Dec 4 2020, 8:21 AM · Restricted Project
erik.pilkington committed rG4fa0dbd6885b: Fix a test failing on windows (authored by erik.pilkington).
Fix a test failing on windows
Dec 4 2020, 8:21 AM
erik.pilkington added inline comments to D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .
Dec 4 2020, 7:38 AM · Restricted Project
erik.pilkington updated the diff for D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .

Address review comments.

Dec 4 2020, 7:38 AM · Restricted Project
erik.pilkington committed rG090dd647d98d: [Sema] Fold VLAs to constant arrays in a few more contexts (authored by erik.pilkington).
[Sema] Fold VLAs to constant arrays in a few more contexts
Dec 4 2020, 7:04 AM
erik.pilkington closed D90871: [Sema] Fold VLAs to constant arrays in a few more contexts.
Dec 4 2020, 7:04 AM · Restricted Project

Dec 2 2020

erik.pilkington requested review of D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .
Dec 2 2020, 10:07 AM · Restricted Project
erik.pilkington accepted D92355: [clang] add a `swift_async_name` attribute.

LGTM!

Dec 2 2020, 8:35 AM · Restricted Project
erik.pilkington added a comment to D92354: [clang] add a new `swift_attr` attribute.

Do we need to add APINotes support for this?

Dec 2 2020, 8:14 AM · Restricted Project

Nov 26 2020

erik.pilkington added a comment to D90871: [Sema] Fold VLAs to constant arrays in a few more contexts.

Ping!

Nov 26 2020, 7:22 AM · Restricted Project

Nov 25 2020

erik.pilkington added inline comments to D90188: Add support for attribute 'using_if_exists'.
Nov 25 2020, 11:36 AM
erik.pilkington updated the diff for D90188: Add support for attribute 'using_if_exists'.

Address review comments.

Nov 25 2020, 11:36 AM
erik.pilkington added a comment to D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

Can you mention this change in the release notes? Also, should we document it explicitly in the Language Extensions documentation, or do you think this is too tiny of a feature to warrant that?

Nov 25 2020, 11:35 AM
erik.pilkington updated the diff for D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

Address review comments.

Nov 25 2020, 11:35 AM

Nov 17 2020

erik.pilkington added a comment to D90188: Add support for attribute 'using_if_exists'.

FWIW, it'd be a bit easier if those changes were split off into their own patch, as they're orthogonal to using_if_exists.

Nov 17 2020, 7:19 AM
erik.pilkington updated the diff for D90188: Add support for attribute 'using_if_exists'.

Split off parsing support for C++ attributes.

Nov 17 2020, 7:19 AM
erik.pilkington requested review of D91630: [Parse] Add parsing support for C++ attributes on using-declarations.
Nov 17 2020, 7:19 AM

Nov 16 2020

erik.pilkington updated the diff for D90871: [Sema] Fold VLAs to constant arrays in a few more contexts.

Use a bit on Declarator instead of an ad-hoc bool parameter.

Nov 16 2020, 7:22 AM · Restricted Project

Nov 13 2020

erik.pilkington added a reviewer for D90871: [Sema] Fold VLAs to constant arrays in a few more contexts: efriedma.

Ping!

Nov 13 2020, 9:33 AM · Restricted Project
erik.pilkington updated the diff for D90188: Add support for attribute 'using_if_exists'.

Add support for C++11-style attributes on using-declarations.

Nov 13 2020, 9:31 AM

Nov 6 2020

erik.pilkington accepted D90891: [clang] ns_error_domain attribute also supports CFString typed variables.
Nov 6 2020, 6:16 AM · Restricted Project

Nov 5 2020

erik.pilkington requested review of D90871: [Sema] Fold VLAs to constant arrays in a few more contexts.
Nov 5 2020, 11:54 AM · Restricted Project

Nov 4 2020

erik.pilkington added inline comments to D90188: Add support for attribute 'using_if_exists'.
Nov 4 2020, 8:05 AM

Nov 3 2020

erik.pilkington added inline comments to D90188: Add support for attribute 'using_if_exists'.
Nov 3 2020, 8:24 PM
erik.pilkington updated the diff for D90188: Add support for attribute 'using_if_exists'.

Address review comments, thanks!

Nov 3 2020, 8:24 PM

Oct 27 2020

erik.pilkington added inline comments to D90188: Add support for attribute 'using_if_exists'.
Oct 27 2020, 12:11 PM

Oct 26 2020

erik.pilkington requested review of D90188: Add support for attribute 'using_if_exists'.
Oct 26 2020, 1:19 PM

Oct 23 2020

erik.pilkington accepted D90003: Demangling support for class type non-type template parameter extensions..

LGTM!

Oct 23 2020, 10:06 AM · Restricted Project, Restricted Project

Oct 19 2020

erik.pilkington abandoned D33977: [libcxx][WIP] Experimental support for a scheduler for use in the parallel stl algorithms.
Oct 19 2020, 3:38 PM

Oct 15 2020

erik.pilkington committed rG351317167e2b: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to… (authored by erik.pilkington).
[SemaObjC] Fix composite pointer type calculation for `void*` and pointer to…
Oct 15 2020, 12:21 PM
erik.pilkington closed D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type.
Oct 15 2020, 12:21 PM · Restricted Project
erik.pilkington requested review of D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type.
Oct 15 2020, 8:18 AM · Restricted Project

Oct 13 2020

erik.pilkington committed rG498c7fa48a02: [SemaObjC] Fix a crash on an invalid ternary with ARC pointers (authored by erik.pilkington).
[SemaObjC] Fix a crash on an invalid ternary with ARC pointers
Oct 13 2020, 6:20 PM

Sep 3 2020

erik.pilkington committed rG0f1be87e2947: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling… (authored by erik.pilkington).
[Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling…
Sep 3 2020, 1:57 PM
erik.pilkington closed D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once.
Sep 3 2020, 1:57 PM · Restricted Project
erik.pilkington requested review of D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once.
Sep 3 2020, 10:59 AM · Restricted Project

Sep 2 2020

erik.pilkington committed rG2d11ae0a40e2: Fix a -Wparenthesis warning in 8ff44e644bb7, NFC (authored by erik.pilkington).
Fix a -Wparenthesis warning in 8ff44e644bb7, NFC
Sep 2 2020, 12:09 PM
erik.pilkington committed rG9523cf02c22a: [AST] Fix handling of long double and bool in __builtin_bit_cast (authored by erik.pilkington).
[AST] Fix handling of long double and bool in __builtin_bit_cast
Sep 2 2020, 12:09 PM
erik.pilkington closed D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.
Sep 2 2020, 12:09 PM · Restricted Project
erik.pilkington committed rGd46f2c51e4c8: Make -fvisibility-inlines-hidden apply to static local variables in inline… (authored by erik.pilkington).
Make -fvisibility-inlines-hidden apply to static local variables in inline…
Sep 2 2020, 9:19 AM
erik.pilkington committed rG8ff44e644bb7: [IRGen] Fix an assert when __attribute__((used)) is used on an ObjC method (authored by erik.pilkington).
[IRGen] Fix an assert when __attribute__((used)) is used on an ObjC method
Sep 2 2020, 9:19 AM
erik.pilkington closed D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin.
Sep 2 2020, 9:19 AM · Restricted Project

Sep 1 2020

erik.pilkington requested review of D67935: Add `#pragma clang deprecated`, used to deprecate macros.

@aaron.ballman: Did you happen to get any feedback on macro attributes? There are a growing number of macros that we'd like to be able to deprecate, and having a workable solution would be useful for us.

Sep 1 2020, 5:33 PM · Restricted Project

Aug 31 2020

erik.pilkington requested review of D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin.
Aug 31 2020, 9:52 AM · Restricted Project
erik.pilkington committed rGa9a6e62ddff2: [CodeGen] Make sure the EH cleanup for block captures is conditional when the… (authored by erik.pilkington).
[CodeGen] Make sure the EH cleanup for block captures is conditional when the…
Aug 31 2020, 7:13 AM
erik.pilkington closed D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context.
Aug 31 2020, 7:12 AM · Restricted Project

Aug 30 2020

erik.pilkington requested review of D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context.
Aug 30 2020, 2:15 PM · Restricted Project

Aug 12 2020

erik.pilkington committed rGcc6d9f59fdba: [libcxx][test] Fix a -Wstring-concatenation warning in fuzzer_test.h (authored by erik.pilkington).
[libcxx][test] Fix a -Wstring-concatenation warning in fuzzer_test.h
Aug 12 2020, 1:55 PM
erik.pilkington committed rGfc915d13b867: [clang-tidy] use stable_sort instead of sort to fix EXPENSIVE_CHECKS tests (authored by erik.pilkington).
[clang-tidy] use stable_sort instead of sort to fix EXPENSIVE_CHECKS tests
Aug 12 2020, 9:13 AM

Jul 31 2020

erik.pilkington accepted D85035: [libc++] Avoid including <Block.h> from <functional>.

LGTM

Jul 31 2020, 10:18 AM · Restricted Project

Jul 30 2020

erik.pilkington added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

It looks like the behavior here is host-dependent (we demangle the target's long double literals based on the host's long double). Is that correct? Should we try to avoid that? It seems like a bad idea to make llvm-cxxfilt behave differently on different targets.

Jul 30 2020, 4:48 PM · Restricted Project, Restricted Project
erik.pilkington added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

@enh: Do you have commit rights? If not, Louis or I would be happy to commit this on your behalf.

Jul 30 2020, 12:44 PM · Restricted Project, Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rGbf8b1ac4344d: Merge pull request #1320 from apple/cherry-pick-64037250 (authored by erik.pilkington).
Merge pull request #1320 from apple/cherry-pick-64037250
Jul 14 2020, 4:54 PM
erik.pilkington committed rG668f3e6381c9: [ObjC] Fix AST serialization for pseudo-strong parameters (authored by dgoldman).
[ObjC] Fix AST serialization for pseudo-strong parameters
Jul 14 2020, 4:54 PM
GitHub <noreply@github.com> committed rG0c5ba9d8c9df: Merge pull request #1140 from apple/cherry-pick-60092165 (authored by erik.pilkington).
Merge pull request #1140 from apple/cherry-pick-60092165
Jul 14 2020, 4:48 PM
erik.pilkington committed rGdf8d249a9fc1: [AST] Fix a crash on a dependent vector_size attribute (authored by erik.pilkington).
[AST] Fix a crash on a dependent vector_size attribute
Jul 14 2020, 4:48 PM
GitHub <noreply@github.com> committed rGd591cb3e71a8: Merge pull request #1045 from apple/cherry-pick-61462374 (authored by erik.pilkington).
Merge pull request #1045 from apple/cherry-pick-61462374
Jul 14 2020, 4:40 PM
erik.pilkington committed rG7d0b07c08a38: [IR] Lazily number instructions for local dominance queries (authored by rnk).
[IR] Lazily number instructions for local dominance queries
Jul 14 2020, 4:40 PM
erik.pilkington committed rG9a4b0a026551: Fix NDEBUG build after instruction ordering (authored by rnk).
Fix NDEBUG build after instruction ordering
Jul 14 2020, 4:40 PM
GitHub <noreply@github.com> committed rG5d61a2caf44b: Merge pull request #1032 from apple/cherry-pick-60695105 (authored by erik.pilkington).
Merge pull request #1032 from apple/cherry-pick-60695105
Jul 14 2020, 4:39 PM
erik.pilkington committed rG1eeb3ddb2250: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a… (authored by erik.pilkington).
[CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a…
Jul 14 2020, 4:39 PM
GitHub <noreply@github.com> committed rG15ae82a75a1f: Merge pull request #1019 from apple/cherry-pick-59270180 (authored by erik.pilkington).
Merge pull request #1019 from apple/cherry-pick-59270180
Jul 14 2020, 4:39 PM
erik.pilkington committed rGfe7314d3bb1b: [CodeGen] Add an alignment attribute to all sret parameters (authored by erik.pilkington).
[CodeGen] Add an alignment attribute to all sret parameters
Jul 14 2020, 4:39 PM
GitHub <noreply@github.com> committed rGc0f64db97119: Merge pull request #950 from apple/cherry-pick-58548532 (authored by erik.pilkington).
Merge pull request #950 from apple/cherry-pick-58548532
Jul 14 2020, 4:35 PM
erik.pilkington committed rGb6a9124bf4ce: Fix type-dependency of bitfields in templates (authored by eandrews).
Fix type-dependency of bitfields in templates
Jul 14 2020, 4:35 PM
GitHub <noreply@github.com> committed rG2e0f055e9829: Merge pull request #933 from apple/eng/PR-54603814 (authored by erik.pilkington).
Merge pull request #933 from apple/eng/PR-54603814
Jul 14 2020, 4:34 PM
erik.pilkington committed rG7e462eee4d94: [Sema] Fix a crash when diagnosing a failed overload due to __ptrauth qualifier (authored by erik.pilkington).
[Sema] Fix a crash when diagnosing a failed overload due to __ptrauth qualifier
Jul 14 2020, 4:34 PM
erik.pilkington committed rG002b09222f9d: [Sema] Fix an assert when objc_externally_retained was applied to an… (authored by erik.pilkington).
[Sema] Fix an assert when objc_externally_retained was applied to an…
Jul 14 2020, 4:34 PM
GitHub <noreply@github.com> committed rG3138d9047036: Merge pull request #914 from apple/cherry-pick-58893199 (authored by erik.pilkington).
Merge pull request #914 from apple/cherry-pick-58893199
Jul 14 2020, 4:34 PM
GitHub <noreply@github.com> committed rG064f357e879e: Merge pull request #895 from apple/cherry-pick-56579760 (authored by erik.pilkington).
Merge pull request #895 from apple/cherry-pick-56579760
Jul 14 2020, 4:32 PM
erik.pilkington committed rG9ec7a1eb4a0c: [CodeGenObjC] Privatize some ObjC metadata symbols (authored by erik.pilkington).
[CodeGenObjC] Privatize some ObjC metadata symbols
Jul 14 2020, 4:32 PM
GitHub <noreply@github.com> committed rGd222a9c1c2b6: Merge pull request #889 from apple/cherry-pick-60052657 (authored by erik.pilkington).
Merge pull request #889 from apple/cherry-pick-60052657
Jul 14 2020, 4:32 PM
erik.pilkington committed rGaf66a442e800: [CodeGen] Avoid applying an offset to a constant function lvalue when ptrauth… (authored by erik.pilkington).
[CodeGen] Avoid applying an offset to a constant function lvalue when ptrauth…
Jul 14 2020, 4:32 PM
GitHub <noreply@github.com> committed rG8b0c9cc763fc: Merge pull request #878 from apple/57372317-cherry-pick (authored by erik.pilkington).
Merge pull request #878 from apple/57372317-cherry-pick
Jul 14 2020, 4:32 PM
erik.pilkington committed rG89b1a463a531: [Sema] Look through OpaqueValueExpr when checking implicit conversions (authored by erik.pilkington).
[Sema] Look through OpaqueValueExpr when checking implicit conversions
Jul 14 2020, 4:32 PM
GitHub <noreply@github.com> committed rGe6ce0dd73bbd: Merge pull request #877 from apple/59919733-cherry-pick (authored by erik.pilkington).
Merge pull request #877 from apple/59919733-cherry-pick
Jul 14 2020, 4:31 PM
erik.pilkington committed rG08c4a4134f17: [Sema] Fix a crash when attaching comments to an implicit decl (authored by erik.pilkington).
[Sema] Fix a crash when attaching comments to an implicit decl
Jul 14 2020, 4:31 PM

Jul 10 2020

erik.pilkington committed rGdafc3106d206: [Sema] Emit a -Wformat warning for printf("%s", (void*)p) (authored by erik.pilkington).
[Sema] Emit a -Wformat warning for printf("%s", (void*)p)
Jul 10 2020, 12:10 PM

Jul 7 2020

erik.pilkington committed rG2f71cf6d77c5: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional… (authored by erik.pilkington).
[SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional…
Jul 7 2020, 10:30 AM
erik.pilkington committed rG7437a9496528: [SemaObjC] Add a warning for @selector expressions that potentially refer to… (authored by erik.pilkington).
[SemaObjC] Add a warning for @selector expressions that potentially refer to…
Jul 7 2020, 10:30 AM
erik.pilkington closed D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator.
Jul 7 2020, 10:30 AM · Restricted Project
erik.pilkington closed D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.
Jul 7 2020, 10:30 AM · Restricted Project

Jul 6 2020

erik.pilkington added a reviewer for D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator: ahatanak.

Ping!

Jul 6 2020, 1:19 PM · Restricted Project
erik.pilkington added a comment to D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.

So the risk with that one is that if someone had say the -didSomething direct selector and that some UIKit/Apple SDK API now adds this as a thing that you use with CFNotification center for example, where you _need_ dynamism, then the uses of the API would warn all the time when the internal to the client project -didSomething is in scope.

So we ideally need a way to silence this warning, so at the very least this needs to be a new -W flag (on by default (?)) so that callers that have an issue can use a _Pragma at the call site to ignore the error for when it's legal.

Jul 6 2020, 10:25 AM · Restricted Project
erik.pilkington updated the diff for D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.

Add an off-by-default variant of this warning.

Jul 6 2020, 10:25 AM · Restricted Project

Jun 30 2020

erik.pilkington accepted D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16.

LGTM, after mine and Aaron's comments.

Jun 30 2020, 9:15 AM

Jun 25 2020

erik.pilkington added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Ping, @rsmith did you want to take another look at this?

Jun 25 2020, 4:56 PM · Restricted Project
erik.pilkington created D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.
Jun 25 2020, 4:56 PM · Restricted Project