Page MenuHomePhabricator

erik.pilkington (Erik Pilkington)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2016, 10:56 AM (279 w, 4 d)

Recent Activity

Fri, May 14

erik.pilkington accepted D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement.

LGTM!

Fri, May 14, 12:39 PM · Restricted Project

Apr 20 2021

erik.pilkington added a comment to D100404: Add Global support for #pragma clang attributes.

Using a global scope is more complicated. We need to properly handle Erik's concerns about nested namespaces.

His concern seems to me to apply to any scope, even without a global namespace. I.e., how do you know nobody else push-ed (or pushes in the future) a #pca scope in the "lots of code" parts below?

#pragma clang attribute push
/ lots of code
#pragma clang attribute (....)
/ lots of code
/// code that depends on attribute
#pragma clang attribute pop

Might go undetected if "code that depends on attribute" includes conditional compilation with #ifdef

Thus, I don't see this as a problem particular to there being a global scope.

Apr 20 2021, 10:43 AM
erik.pilkington added a comment to D100404: Add Global support for #pragma clang attributes.

If Clang supported a "global" scope, then you would be able to just use the "#pragma clang attribute (...)" syntax when you don't want to pop. Seems like the natural solution.

Apr 20 2021, 9:23 AM
erik.pilkington added a comment to D90188: Add support for attribute 'using_if_exists'.

Does anyone have any remaining concerns or a desire to take another pass through this patch? If not, then I'll commit this later this week on Aaron's LGTM.

Apr 20 2021, 8:29 AM · Restricted Project

Apr 12 2021

erik.pilkington accepted D100246: [demangler] Use standard semantics for StringView::substr.

LGTM as well, thanks!

Apr 12 2021, 9:29 AM · Restricted Project, Restricted Project

Apr 6 2021

erik.pilkington added a comment to D90188: Add support for attribute 'using_if_exists'.

Ping!

Apr 6 2021, 2:13 PM · Restricted Project
erik.pilkington committed rGb660abc80d0d: [ObjC] Add a command line flag that disables recognition of objc_direct for… (authored by erik.pilkington).
[ObjC] Add a command line flag that disables recognition of objc_direct for…
Apr 6 2021, 8:18 AM
erik.pilkington closed D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability.
Apr 6 2021, 8:18 AM · Restricted Project

Apr 5 2021

erik.pilkington committed rG803b79221edf: [SemaObjC] Fix a -Wbridge-cast false-positive (authored by erik.pilkington).
[SemaObjC] Fix a -Wbridge-cast false-positive
Apr 5 2021, 8:43 AM
erik.pilkington closed D99661: [SemaObjC] Fix a -Wbridge-cast false-positive.
Apr 5 2021, 8:43 AM · Restricted Project

Apr 1 2021

erik.pilkington updated the diff for D99661: [SemaObjC] Fix a -Wbridge-cast false-positive.

Should we try to restore the behavior prior to https://reviews.llvm.org/rG09abecef7bbfda18d34f046954eaa4d491062839 as much as we can? Or that's not important?

Apr 1 2021, 12:50 PM · Restricted Project

Mar 31 2021

erik.pilkington requested review of D99661: [SemaObjC] Fix a -Wbridge-cast false-positive.
Mar 31 2021, 7:27 AM · Restricted Project

Mar 30 2021

erik.pilkington updated the diff for D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability.
  • Use the new marshaling infrastructure
  • Fix a few places in Sema where we manually checked for ObjCDirectAttr instead of using isDirectMethod
Mar 30 2021, 6:35 AM · Restricted Project

Mar 29 2021

erik.pilkington added inline comments to D90188: Add support for attribute 'using_if_exists'.
Mar 29 2021, 7:55 AM · Restricted Project
erik.pilkington updated the diff for D90188: Add support for attribute 'using_if_exists'.

Address review comments.

Mar 29 2021, 7:55 AM · Restricted Project
erik.pilkington updated the diff for D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

Address @aaron.ballman's review comments. Also, fix a bug where we failed to properly parse an inherited constructor declaration with a trailing attribute.

Mar 29 2021, 7:55 AM · Restricted Project

Mar 23 2021

erik.pilkington accepted D98687: Fix demangling of optional template-args for vendor extended type qualifier..

LGTM, thanks!

Mar 23 2021, 12:46 PM · Restricted Project, Restricted Project

Mar 22 2021

erik.pilkington accepted D55212: Handle alloc_size attribute on function pointers.

I think folks will have a chance to react if we apply it to trunk now, but I am wondering if anyone's had a chance to investigate usage in the wild. @erik.pilkington or @dexonsmith, do either of you have a gut feeling?

Mar 22 2021, 7:59 AM · Restricted Project

Feb 10 2021

erik.pilkington committed rG1e8afba6f176: [clang] Add support for attribute 'swift_async_error' (authored by erik.pilkington).
[clang] Add support for attribute 'swift_async_error'
Feb 10 2021, 10:23 AM
erik.pilkington closed D96175: [clang] Add support for attribute 'swift_async_error'.
Feb 10 2021, 10:23 AM · Restricted Project

Feb 8 2021

erik.pilkington added inline comments to D96175: [clang] Add support for attribute 'swift_async_error'.
Feb 8 2021, 10:01 AM · Restricted Project
erik.pilkington updated the diff for D96175: [clang] Add support for attribute 'swift_async_error'.

Get rid of a useless return.

Feb 8 2021, 10:01 AM · Restricted Project

Feb 5 2021

erik.pilkington requested review of D96175: [clang] Add support for attribute 'swift_async_error'.
Feb 5 2021, 1:22 PM · Restricted Project

Feb 1 2021

erik.pilkington requested review of D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability.
Feb 1 2021, 7:54 PM · Restricted Project
erik.pilkington added a comment to D95482: [PATCH] [clang] Fix bug 48848 by removing assertion related to recoverFromMSUnqualifiedLookup.

Sorry, yeah, I'm OK with this change.

Feb 1 2021, 10:59 AM · Restricted Project
erik.pilkington committed rG5f3c4923e4e4: [compiler-rt] Fix AArch64 out-of-line atomics visibility on mach-o (authored by erik.pilkington).
[compiler-rt] Fix AArch64 out-of-line atomics visibility on mach-o
Feb 1 2021, 8:30 AM
erik.pilkington closed D95639: [compiler-rt] Fix AArch64 out-of-line atomics visibility on mach-o.
Feb 1 2021, 8:29 AM · Restricted Project

Jan 28 2021

erik.pilkington requested review of D95639: [compiler-rt] Fix AArch64 out-of-line atomics visibility on mach-o.
Jan 28 2021, 2:08 PM · Restricted Project

Jan 26 2021

erik.pilkington accepted D93260: Frontend: Simplify handling of non-seeking streams in CompilerInstance, NFC.

LGTM

Jan 26 2021, 2:32 PM · Restricted Project, Restricted Project
erik.pilkington accepted D93249: Frontend: Fix memory leak in CompilerInstance::setVerboseOutputStream.

LGTM

Jan 26 2021, 2:27 PM · Restricted Project
erik.pilkington accepted D93248: Frontend: Fix layering between create{,Default}OutputFile, NFC.

LGTM!

Jan 26 2021, 2:24 PM · Restricted Project

Jan 25 2021

erik.pilkington committed rGc4355670b4bb: [Sema] Fix an assertion failure in -Wcompletion-handler (authored by erik.pilkington).
[Sema] Fix an assertion failure in -Wcompletion-handler
Jan 25 2021, 10:03 AM

Dec 16 2020

erik.pilkington committed rG95b2dab19910: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to… (authored by erik.pilkington).
[Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to…
Dec 16 2020, 7:02 AM
erik.pilkington committed rG92d6e8001e20: NFC: balance a quote in AttrDocs.td (authored by erik.pilkington).
NFC: balance a quote in AttrDocs.td
Dec 16 2020, 7:02 AM
erik.pilkington closed D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays.
Dec 16 2020, 7:02 AM · Restricted Project

Dec 14 2020

erik.pilkington requested review of D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays.
Dec 14 2020, 2:26 PM · Restricted Project

Dec 7 2020

erik.pilkington committed rG5a28e1d9e50e: [clang] Add support for attribute 'swift_async' (authored by erik.pilkington).
[clang] Add support for attribute 'swift_async'
Dec 7 2020, 2:20 PM
erik.pilkington committed rG9cd2413f1ca7: [clang] Add a new nullability annotation for swift async: _Nullable_result (authored by erik.pilkington).
[clang] Add a new nullability annotation for swift async: _Nullable_result
Dec 7 2020, 2:20 PM
erik.pilkington closed D92742: [clang] Add support for attribute 'swift_async'.
Dec 7 2020, 2:20 PM · Restricted Project
erik.pilkington closed D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .
Dec 7 2020, 2:20 PM · Restricted Project

Dec 6 2020

erik.pilkington requested review of D92742: [clang] Add support for attribute 'swift_async'.
Dec 6 2020, 6:38 PM · Restricted Project

Dec 4 2020

erik.pilkington accepted D92602: [objc] diagnose protocol conformance in categories with direct members in their corresponding class interfaces.

LGTM

Dec 4 2020, 11:53 AM · Restricted Project
erik.pilkington added inline comments to D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .
Dec 4 2020, 10:09 AM · Restricted Project
erik.pilkington updated the diff for D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .

Address review comments.

Dec 4 2020, 10:09 AM · Restricted Project
erik.pilkington added a comment to D90871: [Sema] Fold VLAs to constant arrays in a few more contexts.

Looks like this breaks tests on Windows: http://45.33.8.238/win/29181/step_7.txt

PTAL, and revert while you investigate if it takes a while to fix.

Dec 4 2020, 8:21 AM · Restricted Project
erik.pilkington committed rG4fa0dbd6885b: Fix a test failing on windows (authored by erik.pilkington).
Fix a test failing on windows
Dec 4 2020, 8:21 AM
erik.pilkington added inline comments to D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .
Dec 4 2020, 7:38 AM · Restricted Project
erik.pilkington updated the diff for D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .

Address review comments.

Dec 4 2020, 7:38 AM · Restricted Project
erik.pilkington committed rG090dd647d98d: [Sema] Fold VLAs to constant arrays in a few more contexts (authored by erik.pilkington).
[Sema] Fold VLAs to constant arrays in a few more contexts
Dec 4 2020, 7:04 AM
erik.pilkington closed D90871: [Sema] Fold VLAs to constant arrays in a few more contexts.
Dec 4 2020, 7:04 AM · Restricted Project

Dec 2 2020

erik.pilkington requested review of D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result .
Dec 2 2020, 10:07 AM · Restricted Project
erik.pilkington accepted D92355: [clang] add a `swift_async_name` attribute.

LGTM!

Dec 2 2020, 8:35 AM · Restricted Project
erik.pilkington added a comment to D92354: [clang] add a new `swift_attr` attribute.

Do we need to add APINotes support for this?

Dec 2 2020, 8:14 AM · Restricted Project

Nov 26 2020

erik.pilkington added a comment to D90871: [Sema] Fold VLAs to constant arrays in a few more contexts.

Ping!

Nov 26 2020, 7:22 AM · Restricted Project

Nov 25 2020

erik.pilkington added inline comments to D90188: Add support for attribute 'using_if_exists'.
Nov 25 2020, 11:36 AM · Restricted Project
erik.pilkington updated the diff for D90188: Add support for attribute 'using_if_exists'.

Address review comments.

Nov 25 2020, 11:36 AM · Restricted Project
erik.pilkington added a comment to D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

Can you mention this change in the release notes? Also, should we document it explicitly in the Language Extensions documentation, or do you think this is too tiny of a feature to warrant that?

Nov 25 2020, 11:35 AM · Restricted Project
erik.pilkington updated the diff for D91630: [Parse] Add parsing support for C++ attributes on using-declarations.

Address review comments.

Nov 25 2020, 11:35 AM · Restricted Project

Nov 17 2020

erik.pilkington added a comment to D90188: Add support for attribute 'using_if_exists'.

FWIW, it'd be a bit easier if those changes were split off into their own patch, as they're orthogonal to using_if_exists.

Nov 17 2020, 7:19 AM · Restricted Project
erik.pilkington updated the diff for D90188: Add support for attribute 'using_if_exists'.

Split off parsing support for C++ attributes.

Nov 17 2020, 7:19 AM · Restricted Project
erik.pilkington requested review of D91630: [Parse] Add parsing support for C++ attributes on using-declarations.
Nov 17 2020, 7:19 AM · Restricted Project

Nov 16 2020

erik.pilkington updated the diff for D90871: [Sema] Fold VLAs to constant arrays in a few more contexts.

Use a bit on Declarator instead of an ad-hoc bool parameter.

Nov 16 2020, 7:22 AM · Restricted Project

Nov 13 2020

erik.pilkington added a reviewer for D90871: [Sema] Fold VLAs to constant arrays in a few more contexts: efriedma.

Ping!

Nov 13 2020, 9:33 AM · Restricted Project
erik.pilkington updated the diff for D90188: Add support for attribute 'using_if_exists'.

Add support for C++11-style attributes on using-declarations.

Nov 13 2020, 9:31 AM · Restricted Project

Nov 6 2020

erik.pilkington accepted D90891: [clang] ns_error_domain attribute also supports CFString typed variables.
Nov 6 2020, 6:16 AM · Restricted Project

Nov 5 2020

erik.pilkington requested review of D90871: [Sema] Fold VLAs to constant arrays in a few more contexts.
Nov 5 2020, 11:54 AM · Restricted Project

Nov 4 2020

erik.pilkington added inline comments to D90188: Add support for attribute 'using_if_exists'.
Nov 4 2020, 8:05 AM · Restricted Project

Nov 3 2020

erik.pilkington added inline comments to D90188: Add support for attribute 'using_if_exists'.
Nov 3 2020, 8:24 PM · Restricted Project
erik.pilkington updated the diff for D90188: Add support for attribute 'using_if_exists'.

Address review comments, thanks!

Nov 3 2020, 8:24 PM · Restricted Project

Oct 27 2020

erik.pilkington added inline comments to D90188: Add support for attribute 'using_if_exists'.
Oct 27 2020, 12:11 PM · Restricted Project

Oct 26 2020

erik.pilkington requested review of D90188: Add support for attribute 'using_if_exists'.
Oct 26 2020, 1:19 PM · Restricted Project

Oct 23 2020

erik.pilkington accepted D90003: Demangling support for class type non-type template parameter extensions..

LGTM!

Oct 23 2020, 10:06 AM · Restricted Project, Restricted Project

Oct 19 2020

erik.pilkington abandoned D33977: [libcxx][WIP] Experimental support for a scheduler for use in the parallel stl algorithms.
Oct 19 2020, 3:38 PM

Oct 15 2020

erik.pilkington committed rG351317167e2b: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to… (authored by erik.pilkington).
[SemaObjC] Fix composite pointer type calculation for `void*` and pointer to…
Oct 15 2020, 12:21 PM
erik.pilkington closed D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type.
Oct 15 2020, 12:21 PM · Restricted Project
erik.pilkington requested review of D89475: [SemaObjC] Fix composite pointer type calculation for `void*` and pointer to lifetime qualified ObjC pointer type.
Oct 15 2020, 8:18 AM · Restricted Project

Oct 13 2020

erik.pilkington committed rG498c7fa48a02: [SemaObjC] Fix a crash on an invalid ternary with ARC pointers (authored by erik.pilkington).
[SemaObjC] Fix a crash on an invalid ternary with ARC pointers
Oct 13 2020, 6:20 PM

Sep 3 2020

erik.pilkington committed rG0f1be87e2947: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling… (authored by erik.pilkington).
[Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling…
Sep 3 2020, 1:57 PM
erik.pilkington closed D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once.
Sep 3 2020, 1:57 PM · Restricted Project
erik.pilkington requested review of D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once.
Sep 3 2020, 10:59 AM · Restricted Project

Sep 2 2020

erik.pilkington committed rG2d11ae0a40e2: Fix a -Wparenthesis warning in 8ff44e644bb7, NFC (authored by erik.pilkington).
Fix a -Wparenthesis warning in 8ff44e644bb7, NFC
Sep 2 2020, 12:09 PM
erik.pilkington committed rG9523cf02c22a: [AST] Fix handling of long double and bool in __builtin_bit_cast (authored by erik.pilkington).
[AST] Fix handling of long double and bool in __builtin_bit_cast
Sep 2 2020, 12:09 PM
erik.pilkington closed D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.
Sep 2 2020, 12:09 PM · Restricted Project
erik.pilkington committed rGd46f2c51e4c8: Make -fvisibility-inlines-hidden apply to static local variables in inline… (authored by erik.pilkington).
Make -fvisibility-inlines-hidden apply to static local variables in inline…
Sep 2 2020, 9:19 AM
erik.pilkington committed rG8ff44e644bb7: [IRGen] Fix an assert when __attribute__((used)) is used on an ObjC method (authored by erik.pilkington).
[IRGen] Fix an assert when __attribute__((used)) is used on an ObjC method
Sep 2 2020, 9:19 AM
erik.pilkington closed D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin.
Sep 2 2020, 9:19 AM · Restricted Project

Sep 1 2020

erik.pilkington requested review of D67935: Add `#pragma clang deprecated`, used to deprecate macros.

@aaron.ballman: Did you happen to get any feedback on macro attributes? There are a growing number of macros that we'd like to be able to deprecate, and having a workable solution would be useful for us.

Sep 1 2020, 5:33 PM · Restricted Project

Aug 31 2020

erik.pilkington requested review of D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin.
Aug 31 2020, 9:52 AM · Restricted Project
erik.pilkington committed rGa9a6e62ddff2: [CodeGen] Make sure the EH cleanup for block captures is conditional when the… (authored by erik.pilkington).
[CodeGen] Make sure the EH cleanup for block captures is conditional when the…
Aug 31 2020, 7:13 AM
erik.pilkington closed D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context.
Aug 31 2020, 7:12 AM · Restricted Project

Aug 30 2020

erik.pilkington requested review of D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context.
Aug 30 2020, 2:15 PM · Restricted Project

Aug 12 2020

erik.pilkington committed rGcc6d9f59fdba: [libcxx][test] Fix a -Wstring-concatenation warning in fuzzer_test.h (authored by erik.pilkington).
[libcxx][test] Fix a -Wstring-concatenation warning in fuzzer_test.h
Aug 12 2020, 1:55 PM
erik.pilkington committed rGfc915d13b867: [clang-tidy] use stable_sort instead of sort to fix EXPENSIVE_CHECKS tests (authored by erik.pilkington).
[clang-tidy] use stable_sort instead of sort to fix EXPENSIVE_CHECKS tests
Aug 12 2020, 9:13 AM

Jul 31 2020

erik.pilkington accepted D85035: [libc++] Avoid including <Block.h> from <functional>.

LGTM

Jul 31 2020, 10:18 AM · Restricted Project

Jul 30 2020

erik.pilkington added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

It looks like the behavior here is host-dependent (we demangle the target's long double literals based on the host's long double). Is that correct? Should we try to avoid that? It seems like a bad idea to make llvm-cxxfilt behave differently on different targets.

Jul 30 2020, 4:48 PM · Restricted Project, Restricted Project
erik.pilkington added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

@enh: Do you have commit rights? If not, Louis or I would be happy to commit this on your behalf.

Jul 30 2020, 12:44 PM · Restricted Project, Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rGbf8b1ac4344d: Merge pull request #1320 from apple/cherry-pick-64037250 (authored by erik.pilkington).
Merge pull request #1320 from apple/cherry-pick-64037250
Jul 14 2020, 4:54 PM
erik.pilkington committed rG668f3e6381c9: [ObjC] Fix AST serialization for pseudo-strong parameters (authored by dgoldman).
[ObjC] Fix AST serialization for pseudo-strong parameters
Jul 14 2020, 4:54 PM
GitHub <noreply@github.com> committed rG0c5ba9d8c9df: Merge pull request #1140 from apple/cherry-pick-60092165 (authored by erik.pilkington).
Merge pull request #1140 from apple/cherry-pick-60092165
Jul 14 2020, 4:48 PM
erik.pilkington committed rGdf8d249a9fc1: [AST] Fix a crash on a dependent vector_size attribute (authored by erik.pilkington).
[AST] Fix a crash on a dependent vector_size attribute
Jul 14 2020, 4:48 PM