Page MenuHomePhabricator

erik.pilkington (Erik Pilkington)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2016, 10:56 AM (241 w, 4 d)

Recent Activity

Thu, Sep 3

erik.pilkington committed rG0f1be87e2947: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling… (authored by erik.pilkington).
[Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling…
Thu, Sep 3, 1:57 PM
erik.pilkington closed D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once.
Thu, Sep 3, 1:57 PM · Restricted Project
erik.pilkington requested review of D87102: [Sema] Fix a -Warc-repeated-use-of-weak false-positive by only calling CheckPlaceholderExpr once.
Thu, Sep 3, 10:59 AM · Restricted Project

Wed, Sep 2

erik.pilkington committed rG2d11ae0a40e2: Fix a -Wparenthesis warning in 8ff44e644bb7, NFC (authored by erik.pilkington).
Fix a -Wparenthesis warning in 8ff44e644bb7, NFC
Wed, Sep 2, 12:09 PM
erik.pilkington committed rG9523cf02c22a: [AST] Fix handling of long double and bool in __builtin_bit_cast (authored by erik.pilkington).
[AST] Fix handling of long double and bool in __builtin_bit_cast
Wed, Sep 2, 12:09 PM
erik.pilkington closed D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.
Wed, Sep 2, 12:09 PM · Restricted Project
erik.pilkington committed rGd46f2c51e4c8: Make -fvisibility-inlines-hidden apply to static local variables in inline… (authored by erik.pilkington).
Make -fvisibility-inlines-hidden apply to static local variables in inline…
Wed, Sep 2, 9:19 AM
erik.pilkington committed rG8ff44e644bb7: [IRGen] Fix an assert when __attribute__((used)) is used on an ObjC method (authored by erik.pilkington).
[IRGen] Fix an assert when __attribute__((used)) is used on an ObjC method
Wed, Sep 2, 9:19 AM
erik.pilkington closed D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin.
Wed, Sep 2, 9:19 AM · Restricted Project

Tue, Sep 1

erik.pilkington requested review of D67935: Add `#pragma clang deprecated`, used to deprecate macros.

@aaron.ballman: Did you happen to get any feedback on macro attributes? There are a growing number of macros that we'd like to be able to deprecate, and having a workable solution would be useful for us.

Tue, Sep 1, 5:33 PM · Restricted Project

Mon, Aug 31

erik.pilkington requested review of D86881: Make -fvisibility-inlines-hidden apply to static local variables in inline functions on Darwin.
Mon, Aug 31, 9:52 AM · Restricted Project
erik.pilkington committed rGa9a6e62ddff2: [CodeGen] Make sure the EH cleanup for block captures is conditional when the… (authored by erik.pilkington).
[CodeGen] Make sure the EH cleanup for block captures is conditional when the…
Mon, Aug 31, 7:13 AM
erik.pilkington closed D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context.
Mon, Aug 31, 7:12 AM · Restricted Project

Sun, Aug 30

erik.pilkington requested review of D86854: [CodeGen] Make sure the EH cleanup for block captures is conditional when the block literal is in a conditional context.
Sun, Aug 30, 2:15 PM · Restricted Project

Aug 12 2020

erik.pilkington committed rGcc6d9f59fdba: [libcxx][test] Fix a -Wstring-concatenation warning in fuzzer_test.h (authored by erik.pilkington).
[libcxx][test] Fix a -Wstring-concatenation warning in fuzzer_test.h
Aug 12 2020, 1:55 PM
erik.pilkington committed rGfc915d13b867: [clang-tidy] use stable_sort instead of sort to fix EXPENSIVE_CHECKS tests (authored by erik.pilkington).
[clang-tidy] use stable_sort instead of sort to fix EXPENSIVE_CHECKS tests
Aug 12 2020, 9:13 AM

Jul 31 2020

erik.pilkington accepted D85035: [libc++] Avoid including <Block.h> from <functional>.

LGTM

Jul 31 2020, 10:18 AM · Restricted Project

Jul 30 2020

erik.pilkington added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

It looks like the behavior here is host-dependent (we demangle the target's long double literals based on the host's long double). Is that correct? Should we try to avoid that? It seems like a bad idea to make llvm-cxxfilt behave differently on different targets.

Jul 30 2020, 4:48 PM · Restricted Project, Restricted Project
erik.pilkington added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

@enh: Do you have commit rights? If not, Louis or I would be happy to commit this on your behalf.

Jul 30 2020, 12:44 PM · Restricted Project, Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rGbf8b1ac4344d: Merge pull request #1320 from apple/cherry-pick-64037250 (authored by erik.pilkington).
Merge pull request #1320 from apple/cherry-pick-64037250
Jul 14 2020, 4:54 PM
erik.pilkington committed rG668f3e6381c9: [ObjC] Fix AST serialization for pseudo-strong parameters (authored by dgoldman).
[ObjC] Fix AST serialization for pseudo-strong parameters
Jul 14 2020, 4:54 PM
GitHub <noreply@github.com> committed rG0c5ba9d8c9df: Merge pull request #1140 from apple/cherry-pick-60092165 (authored by erik.pilkington).
Merge pull request #1140 from apple/cherry-pick-60092165
Jul 14 2020, 4:48 PM
erik.pilkington committed rGdf8d249a9fc1: [AST] Fix a crash on a dependent vector_size attribute (authored by erik.pilkington).
[AST] Fix a crash on a dependent vector_size attribute
Jul 14 2020, 4:48 PM
GitHub <noreply@github.com> committed rGd591cb3e71a8: Merge pull request #1045 from apple/cherry-pick-61462374 (authored by erik.pilkington).
Merge pull request #1045 from apple/cherry-pick-61462374
Jul 14 2020, 4:40 PM
erik.pilkington committed rG7d0b07c08a38: [IR] Lazily number instructions for local dominance queries (authored by rnk).
[IR] Lazily number instructions for local dominance queries
Jul 14 2020, 4:40 PM
erik.pilkington committed rG9a4b0a026551: Fix NDEBUG build after instruction ordering (authored by rnk).
Fix NDEBUG build after instruction ordering
Jul 14 2020, 4:40 PM
GitHub <noreply@github.com> committed rG5d61a2caf44b: Merge pull request #1032 from apple/cherry-pick-60695105 (authored by erik.pilkington).
Merge pull request #1032 from apple/cherry-pick-60695105
Jul 14 2020, 4:39 PM
erik.pilkington committed rG1eeb3ddb2250: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a… (authored by erik.pilkington).
[CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a…
Jul 14 2020, 4:39 PM
GitHub <noreply@github.com> committed rG15ae82a75a1f: Merge pull request #1019 from apple/cherry-pick-59270180 (authored by erik.pilkington).
Merge pull request #1019 from apple/cherry-pick-59270180
Jul 14 2020, 4:39 PM
erik.pilkington committed rGfe7314d3bb1b: [CodeGen] Add an alignment attribute to all sret parameters (authored by erik.pilkington).
[CodeGen] Add an alignment attribute to all sret parameters
Jul 14 2020, 4:39 PM
GitHub <noreply@github.com> committed rGc0f64db97119: Merge pull request #950 from apple/cherry-pick-58548532 (authored by erik.pilkington).
Merge pull request #950 from apple/cherry-pick-58548532
Jul 14 2020, 4:35 PM
erik.pilkington committed rGb6a9124bf4ce: Fix type-dependency of bitfields in templates (authored by eandrews).
Fix type-dependency of bitfields in templates
Jul 14 2020, 4:35 PM
GitHub <noreply@github.com> committed rG2e0f055e9829: Merge pull request #933 from apple/eng/PR-54603814 (authored by erik.pilkington).
Merge pull request #933 from apple/eng/PR-54603814
Jul 14 2020, 4:34 PM
erik.pilkington committed rG7e462eee4d94: [Sema] Fix a crash when diagnosing a failed overload due to __ptrauth qualifier (authored by erik.pilkington).
[Sema] Fix a crash when diagnosing a failed overload due to __ptrauth qualifier
Jul 14 2020, 4:34 PM
erik.pilkington committed rG002b09222f9d: [Sema] Fix an assert when objc_externally_retained was applied to an… (authored by erik.pilkington).
[Sema] Fix an assert when objc_externally_retained was applied to an…
Jul 14 2020, 4:34 PM
GitHub <noreply@github.com> committed rG3138d9047036: Merge pull request #914 from apple/cherry-pick-58893199 (authored by erik.pilkington).
Merge pull request #914 from apple/cherry-pick-58893199
Jul 14 2020, 4:34 PM
GitHub <noreply@github.com> committed rG064f357e879e: Merge pull request #895 from apple/cherry-pick-56579760 (authored by erik.pilkington).
Merge pull request #895 from apple/cherry-pick-56579760
Jul 14 2020, 4:32 PM
erik.pilkington committed rG9ec7a1eb4a0c: [CodeGenObjC] Privatize some ObjC metadata symbols (authored by erik.pilkington).
[CodeGenObjC] Privatize some ObjC metadata symbols
Jul 14 2020, 4:32 PM
GitHub <noreply@github.com> committed rGd222a9c1c2b6: Merge pull request #889 from apple/cherry-pick-60052657 (authored by erik.pilkington).
Merge pull request #889 from apple/cherry-pick-60052657
Jul 14 2020, 4:32 PM
erik.pilkington committed rGaf66a442e800: [CodeGen] Avoid applying an offset to a constant function lvalue when ptrauth… (authored by erik.pilkington).
[CodeGen] Avoid applying an offset to a constant function lvalue when ptrauth…
Jul 14 2020, 4:32 PM
GitHub <noreply@github.com> committed rG8b0c9cc763fc: Merge pull request #878 from apple/57372317-cherry-pick (authored by erik.pilkington).
Merge pull request #878 from apple/57372317-cherry-pick
Jul 14 2020, 4:32 PM
erik.pilkington committed rG89b1a463a531: [Sema] Look through OpaqueValueExpr when checking implicit conversions (authored by erik.pilkington).
[Sema] Look through OpaqueValueExpr when checking implicit conversions
Jul 14 2020, 4:32 PM
GitHub <noreply@github.com> committed rGe6ce0dd73bbd: Merge pull request #877 from apple/59919733-cherry-pick (authored by erik.pilkington).
Merge pull request #877 from apple/59919733-cherry-pick
Jul 14 2020, 4:31 PM
erik.pilkington committed rG08c4a4134f17: [Sema] Fix a crash when attaching comments to an implicit decl (authored by erik.pilkington).
[Sema] Fix a crash when attaching comments to an implicit decl
Jul 14 2020, 4:31 PM

Jul 10 2020

erik.pilkington committed rGdafc3106d206: [Sema] Emit a -Wformat warning for printf("%s", (void*)p) (authored by erik.pilkington).
[Sema] Emit a -Wformat warning for printf("%s", (void*)p)
Jul 10 2020, 12:10 PM

Jul 7 2020

erik.pilkington committed rG2f71cf6d77c5: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional… (authored by erik.pilkington).
[SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional…
Jul 7 2020, 10:30 AM
erik.pilkington committed rG7437a9496528: [SemaObjC] Add a warning for @selector expressions that potentially refer to… (authored by erik.pilkington).
[SemaObjC] Add a warning for @selector expressions that potentially refer to…
Jul 7 2020, 10:30 AM
erik.pilkington closed D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator.
Jul 7 2020, 10:30 AM · Restricted Project
erik.pilkington closed D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.
Jul 7 2020, 10:30 AM · Restricted Project

Jul 6 2020

erik.pilkington added a reviewer for D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator: ahatanak.

Ping!

Jul 6 2020, 1:19 PM · Restricted Project
erik.pilkington added a comment to D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.

So the risk with that one is that if someone had say the -didSomething direct selector and that some UIKit/Apple SDK API now adds this as a thing that you use with CFNotification center for example, where you _need_ dynamism, then the uses of the API would warn all the time when the internal to the client project -didSomething is in scope.

So we ideally need a way to silence this warning, so at the very least this needs to be a new -W flag (on by default (?)) so that callers that have an issue can use a _Pragma at the call site to ignore the error for when it's legal.

Jul 6 2020, 10:25 AM · Restricted Project
erik.pilkington updated the diff for D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.

Add an off-by-default variant of this warning.

Jul 6 2020, 10:25 AM · Restricted Project

Jun 30 2020

erik.pilkington accepted D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16.

LGTM, after mine and Aaron's comments.

Jun 30 2020, 9:15 AM

Jun 25 2020

erik.pilkington added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Ping, @rsmith did you want to take another look at this?

Jun 25 2020, 4:56 PM · Restricted Project
erik.pilkington created D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods.
Jun 25 2020, 4:56 PM · Restricted Project
erik.pilkington accepted D77924: ld128 demangle: allow space for 'L' suffix..

LGTM, thanks for figuring this out!

Jun 25 2020, 1:39 PM · Restricted Project, Restricted Project

Jun 24 2020

erik.pilkington committed rG69d2fa9ed1c1: [SemaObjC] Fix a crash on invalid when 'auto' is used in a @property (authored by erik.pilkington).
[SemaObjC] Fix a crash on invalid when 'auto' is used in a @property
Jun 24 2020, 9:43 AM

Jun 20 2020

erik.pilkington added a comment to D81905: Enhance Itanium demangler interface..

I don't have a problem with adding an API like this in theory, but what exactly are you planning on using these for in an IR pass? If its to infer some semantic property of the symbol then there probably are better ways of expressing that, like getting the frontend to add metadata or a function attribute or something.

Jun 20 2020, 4:57 PM · Restricted Project

Jun 15 2020

erik.pilkington added inline comments to D77592: [clang] Frontend components for the relative vtables ABI.
Jun 15 2020, 9:46 AM · Restricted Project

Jun 12 2020

erik.pilkington created D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator.
Jun 12 2020, 11:26 AM · Restricted Project

Jun 11 2020

erik.pilkington committed rG95d7ccb70b9c: [PCH] Support writing BuiltinBitCastExprs to PCHs (authored by hyd-dev).
[PCH] Support writing BuiltinBitCastExprs to PCHs
Jun 11 2020, 11:03 AM
erik.pilkington closed D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.
Jun 11 2020, 11:02 AM · Restricted Project

Jun 9 2020

erik.pilkington accepted D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs.

LGTM (after a minor comment), thank you for fixing this!

Jun 9 2020, 1:14 PM · Restricted Project

Jun 8 2020

erik.pilkington committed rG8b529e311a90: [ObjC] Fix AST serialization for pseudo-strong parameters (authored by dgoldman).
[ObjC] Fix AST serialization for pseudo-strong parameters
Jun 8 2020, 9:24 AM
erik.pilkington closed D74417: [clang][ARC] Remove invalid assertion that can crash clangd.
Jun 8 2020, 9:23 AM · Restricted Project

May 14 2020

erik.pilkington added a comment to D74813: Function block naming - add hash of parameter type to end of block name.

Could I please get a review on this ? Thanks :) !

May 14 2020, 7:32 AM · Restricted Project, Restricted Project

May 13 2020

erik.pilkington committed rG1c1fb350c59a: [demangler] Support for 'this' expressions (authored by erik.pilkington).
[demangler] Support for 'this' expressions
May 13 2020, 7:39 PM
erik.pilkington committed rG15426b2161a4: [demangler] Fix demangling of enumerators with negative values (authored by erik.pilkington).
[demangler] Fix demangling of enumerators with negative values
May 13 2020, 11:58 AM

May 6 2020

erik.pilkington added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Ping!

May 6 2020, 9:07 AM · Restricted Project

May 5 2020

erik.pilkington committed rG873e27909539: [SemaObjC] Add a warning for dictionary literals with duplicate keys (authored by erik.pilkington).
[SemaObjC] Add a warning for dictionary literals with duplicate keys
May 5 2020, 12:58 PM
erik.pilkington committed rG86e50af72d0a: [AST] Print fixed enum type regardless of language mode (authored by erik.pilkington).
[AST] Print fixed enum type regardless of language mode
May 5 2020, 12:58 PM
erik.pilkington closed D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys.
May 5 2020, 12:58 PM · Restricted Project
erik.pilkington added inline comments to D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys.
May 5 2020, 6:25 AM · Restricted Project

May 1 2020

erik.pilkington added a comment to D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys.

Ping!

May 1 2020, 5:10 PM · Restricted Project

Apr 30 2020

erik.pilkington accepted D79166: [docs][llvm-cxxfilt] Document the --no-strip-underscore option.

LGTM, thanks!

Apr 30 2020, 6:46 AM · Restricted Project

Apr 29 2020

erik.pilkington edited reviewers for D74813: Function block naming - add hash of parameter type to end of block name, added: rjmccall; removed: Restricted Project.

@erik.pilkington would the hash-based numbering be OK for now ?

Apr 29 2020, 12:54 PM · Restricted Project, Restricted Project
erik.pilkington added a reviewer for D79094: [SemaObjC] Warn on visibility attributes on an @implementation: ahatanak.
Apr 29 2020, 10:43 AM
erik.pilkington created D79094: [SemaObjC] Warn on visibility attributes on an @implementation.
Apr 29 2020, 8:33 AM

Apr 28 2020

erik.pilkington committed rG2bb686b4b629: [AST] Fix a crash on a dependent vector_size attribute (authored by erik.pilkington).
[AST] Fix a crash on a dependent vector_size attribute
Apr 28 2020, 10:12 AM
erik.pilkington closed D79012: [AST] Fix a crash on a dependent vector_size attribute.
Apr 28 2020, 10:12 AM · Restricted Project
erik.pilkington created D79012: [AST] Fix a crash on a dependent vector_size attribute.
Apr 28 2020, 8:34 AM · Restricted Project

Apr 23 2020

erik.pilkington added inline comments to D74813: Function block naming - add hash of parameter type to end of block name.
Apr 23 2020, 9:43 AM · Restricted Project, Restricted Project

Apr 22 2020

erik.pilkington created D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys.
Apr 22 2020, 11:58 AM · Restricted Project
erik.pilkington accepted D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..

LGTM, again :) Thanks for cleaning this up.

Apr 22 2020, 10:19 AM · Restricted Project, Restricted Project
erik.pilkington added a comment to D74813: Function block naming - add hash of parameter type to end of block name.

The demangler changes should also be made in libcxxabi/src/demangle, as there is a copy of the demangler there. This change also needs tests, there should be demangler tests (in libcxxabi/test/test_demangle.cpp), and IRGen tests (in clang/test/CodeGen) that check the mangled name. Finally, can you please add full contexts to your diffs? (by running e.g. git show -U99999).

Apr 22 2020, 9:12 AM · Restricted Project, Restricted Project

Apr 20 2020

erik.pilkington committed rG85cca945b4c9: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber (authored by erik.pilkington).
[SemaObjC] Forbid storing an unboxed integer literal in an NSNumber
Apr 20 2020, 12:28 PM
erik.pilkington closed D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber.
Apr 20 2020, 12:28 PM · Restricted Project

Apr 15 2020

erik.pilkington added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Ping!

Apr 15 2020, 9:50 AM · Restricted Project

Apr 14 2020

erik.pilkington accepted D74163: [demangler] PPC and S390: Fix parsing of e-prefixed long double literals.

Please also commit this to llvm's copy of the demangler. You can copy the change over by running the cp-to-llvm.sh script.

Apr 14 2020, 3:12 PM · Restricted Project, Restricted Project, Restricted Project
erik.pilkington added inline comments to D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..
Apr 14 2020, 6:22 AM · Restricted Project, Restricted Project

Apr 13 2020

erik.pilkington created D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber.
Apr 13 2020, 5:24 PM · Restricted Project
erik.pilkington requested changes to D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..
Apr 13 2020, 8:34 AM · Restricted Project, Restricted Project
erik.pilkington accepted D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..

LGTM (after fixing those tests). Thanks for cleaning this up!

Apr 13 2020, 6:25 AM · Restricted Project, Restricted Project

Apr 12 2020

erik.pilkington added inline comments to D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec..
Apr 12 2020, 7:14 PM · Restricted Project, Restricted Project

Apr 11 2020

erik.pilkington added a comment to D77924: ld128 demangle: allow space for 'L' suffix..

Can you add your test to libcxxabi/test/test_demangle.pass.cpp? You can put it in invalid_cases if you expect it to fail to demangle.

Apr 11 2020, 11:43 AM · Restricted Project, Restricted Project

Apr 8 2020

erik.pilkington added a comment to D74813: Function block naming - add hash of parameter type to end of block name.

What do you think about using the block type instead of a hash? That should be stable across compiler versions, changes to the block body, and changes to referenced declarations. You'd still have to number blocks of the same type within the same function, but that should be a much smaller problem. It'd also allow demanglers to provide more information about the symbol, e.g. a demangler could print:

Apr 8 2020, 1:35 PM · Restricted Project, Restricted Project

Apr 7 2020

erik.pilkington added a comment to D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast.

Ping!

Apr 7 2020, 11:23 AM · Restricted Project
erik.pilkington accepted D77586: Allow parameter names to be elided in a function definition in C.

This also adds the same feature to ObjC blocks under the assumption that ObjC wishes to follow the C standard in this regard.

Apr 7 2020, 8:39 AM

Apr 6 2020

erik.pilkington committed rGd33c7de8e11f: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a… (authored by erik.pilkington).
[CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a…
Apr 6 2020, 1:05 PM
erik.pilkington closed D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct.
Apr 6 2020, 1:05 PM · Restricted Project