Page MenuHomePhabricator

erik.pilkington (Erik Pilkington)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2016, 10:56 AM (206 w, 3 d)

Recent Activity

Thu, Jan 16

erik.pilkington added reviewers for D71566: New checks for fortified sprintf: aaron.ballman, rsmith.
Thu, Jan 16, 9:48 PM · Restricted Project

Thu, Jan 9

erik.pilkington committed rGeb9d2faaa3dc: Add support for constant discriminators in PointerAuthSchema (authored by erik.pilkington).
Add support for constant discriminators in PointerAuthSchema
Thu, Jan 9, 4:55 PM
erik.pilkington committed rG771fed1834c9: NFC: get rid of the unnecessary union in PointerAuthSchema (authored by erik.pilkington).
NFC: get rid of the unnecessary union in PointerAuthSchema
Thu, Jan 9, 4:55 PM
erik.pilkington committed rG183b5d38d7cf: [demangle] Copy back some NFC commits from LLVM (authored by erik.pilkington).
[demangle] Copy back some NFC commits from LLVM
Thu, Jan 9, 10:43 AM

Dec 16 2019

erik.pilkington added a comment to D71566: New checks for fortified sprintf.

Thanks for working on this! I think this would be a really useful diagnostic to have.

Dec 16 2019, 5:03 PM · Restricted Project

Dec 12 2019

erik.pilkington committed rGfe0320826270: Fix mishandling of invalid-but-non-empty nested name specifiers in name… (authored by rsmith).
Fix mishandling of invalid-but-non-empty nested name specifiers in name…
Dec 12 2019, 3:55 PM
erik.pilkington committed rG328cafe7e862: Fix a compile error from a merge (authored by erik.pilkington).
Fix a compile error from a merge
Dec 12 2019, 2:40 PM
erik.pilkington committed rG9fac594889c1: Fix some internal fallout from r370379 (authored by erik.pilkington).
Fix some internal fallout from r370379
Dec 12 2019, 2:40 PM
erik.pilkington committed rG124de095c71b: Merge commit '96b6383be3e03fea6d7d498931163b49bf824ce3' into upstream-with-swift (authored by erik.pilkington).
Merge commit '96b6383be3e03fea6d7d498931163b49bf824ce3' into upstream-with-swift
Dec 12 2019, 2:39 PM
erik.pilkington committed rG8f376ab9e4dc: Revert a commit series that leads to a tricky merge until Jan can take a look. (authored by erik.pilkington).
Revert a commit series that leads to a tricky merge until Jan can take a look.
Dec 12 2019, 2:39 PM
erik.pilkington committed rGe62cb7a6f8f0: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by erik.pilkington).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:38 PM
erik.pilkington committed rG4bc87ab0a3a2: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by erik.pilkington).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:00 PM
erik.pilkington committed rG25c9acb62c65: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by erik.pilkington).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:34 PM
erik.pilkington committed rG7efef6ede5c7: Fix some failing tests (authored by erik.pilkington).
Fix some failing tests
Dec 12 2019, 11:48 AM

Dec 10 2019

erik.pilkington committed rGd5e66f0e060d: NFC: Get rid of an unused parameter to CGObjCMac::EmitSelectorAddr. (authored by erik.pilkington).
NFC: Get rid of an unused parameter to CGObjCMac::EmitSelectorAddr.
Dec 10 2019, 5:14 PM

Nov 20 2019

erik.pilkington committed rGd9957c7405bc: [Sema] Add a 'Semantic' parameter to Expr::isKnownToHaveBooleanValue (authored by erik.pilkington).
[Sema] Add a 'Semantic' parameter to Expr::isKnownToHaveBooleanValue
Nov 20 2019, 4:34 PM
erik.pilkington added a comment to rG8bfb353bb33c: [Sema] Fix a -Wobjc-signed-char-bool false-positive.

Yeah, I agree that -Wswitch-bool isn't appropriate there. I fixed this in d9957c7405bc726422dbc2736ad62f704916fbe8.

Nov 20 2019, 4:34 PM

Nov 18 2019

erik.pilkington accepted D70250: [llvm-cxxfilt] Improve strip-underscore behavior.

LGTM

Nov 18 2019, 2:37 PM · Restricted Project
erik.pilkington committed rG8bfb353bb33c: [Sema] Fix a -Wobjc-signed-char-bool false-positive (authored by erik.pilkington).
[Sema] Fix a -Wobjc-signed-char-bool false-positive
Nov 18 2019, 12:21 PM

Nov 4 2019

erik.pilkington committed rGaf11f417fc7d: [demangle] NFC: get rid of NodeOrString (authored by erik.pilkington).
[demangle] NFC: get rid of NodeOrString
Nov 4 2019, 12:22 PM

Nov 2 2019

erik.pilkington added inline comments to D50930: Move Itanium demangler implementation into a header file and add visitation support..
Nov 2 2019, 12:20 PM · Restricted Project
erik.pilkington added inline comments to D50930: Move Itanium demangler implementation into a header file and add visitation support..
Nov 2 2019, 11:53 AM · Restricted Project

Oct 7 2019

erik.pilkington closed D34096: [Sema][C++1z] Ensure structured binding's bindings in dependent foreach have non-null type.
Oct 7 2019, 5:58 AM · Restricted Project

Oct 4 2019

erik.pilkington committed rGf7766b1ed41a: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic (authored by erik.pilkington).
[Sema] Split out -Wformat-type-confusion from -Wformat-pedantic
Oct 4 2019, 12:23 PM

Oct 3 2019

erik.pilkington added inline comments to D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic .
Oct 3 2019, 9:52 PM · Restricted Project, Restricted Project
erik.pilkington updated the diff for D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic .

Address review comments.

Oct 3 2019, 9:52 PM · Restricted Project, Restricted Project

Oct 2 2019

erik.pilkington added a comment to D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic .

Ping!

Oct 2 2019, 1:45 PM · Restricted Project, Restricted Project

Sep 30 2019

erik.pilkington accepted D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

Okay, LGTM.

Sep 30 2019, 11:15 AM · Restricted Project

Sep 24 2019

erik.pilkington planned changes to D67935: Add `#pragma clang deprecated`, used to deprecate macros.

Marking as "planned changes" to get this out of review queues. Aaron Ballman wants to add "macro attributes", which would be a better way of solving this problem, and is going to ask the C and C++ committees if there is an appetite for such an idea. This is blocked on getting that answer.

Sep 24 2019, 12:13 PM · Restricted Project

Sep 23 2019

erik.pilkington created D67935: Add `#pragma clang deprecated`, used to deprecate macros.
Sep 23 2019, 2:40 PM · Restricted Project
erik.pilkington committed rG2d225bbec1a0: NFC: Fix a poorly-written test (authored by erik.pilkington).
NFC: Fix a poorly-written test
Sep 23 2019, 10:17 AM
erik.pilkington added a comment to rL372533: [NFC] Fixed failed test.

Hi @erik.pilkington, as the author of https://reviews.llvm.org/D62825,

Did you mean

static_assert(i == (LITTLE_END ? 0x00000201 : 0x01020000), "");

?

(please re-check all ternary ops in this file)

Sep 23 2019, 10:15 AM

Sep 19 2019

erik.pilkington created D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic .
Sep 19 2019, 1:12 PM · Restricted Project, Restricted Project

Sep 18 2019

erik.pilkington committed rG5741d19f046f: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd (authored by erik.pilkington).
[Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd
Sep 18 2019, 12:08 PM
erik.pilkington added a comment to D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.

Ping!

Sep 18 2019, 11:08 AM · Restricted Project, Restricted Project

Sep 17 2019

erik.pilkington committed rG5c62152275c0: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C… (authored by erik.pilkington).
[Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C…
Sep 17 2019, 2:12 PM
erik.pilkington added inline comments to D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL.
Sep 17 2019, 2:11 PM · Restricted Project, Restricted Project
erik.pilkington committed rGa1e29a3407fb: Use 'BOOL' instead of BOOL in diagnostic messages (authored by erik.pilkington).
Use 'BOOL' instead of BOOL in diagnostic messages
Sep 17 2019, 11:03 AM
erik.pilkington added inline comments to D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL.
Sep 17 2019, 10:33 AM · Restricted Project, Restricted Project
erik.pilkington updated the diff for D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL.

Address review comments.

Sep 17 2019, 10:33 AM · Restricted Project, Restricted Project

Sep 13 2019

erik.pilkington created D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL.
Sep 13 2019, 9:15 AM · Restricted Project, Restricted Project

Sep 11 2019

erik.pilkington added a comment to D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.

The reflector discussion is still happening and there are issues with ambiguities that we are pretty sure we want to correct. I've got a paper out that touches on some of this: http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2420.pdf

Sep 11 2019, 2:58 PM · Restricted Project, Restricted Project
erik.pilkington updated the diff for D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.

Update the diagnostic text.

Sep 11 2019, 2:58 PM · Restricted Project, Restricted Project

Sep 10 2019

erik.pilkington updated the diff for D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.

Address review comments.

Sep 10 2019, 1:44 PM · Restricted Project, Restricted Project

Sep 9 2019

erik.pilkington added a comment to D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

I'm a bit curious about clients that use getCanonicalType() to get a full desugaring, instead of doing a single step. It seems like they'd still get the out of date type parameter type. Has that ever worked?

Sep 9 2019, 2:24 PM · Restricted Project

Aug 28 2019

erik.pilkington committed rG6c7687ed6770: Fix a passing XFAIL test (authored by erik.pilkington).
Fix a passing XFAIL test
Aug 28 2019, 3:38 PM
erik.pilkington added a comment to D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.

I'm wondering whether this should even warn pedantically. There are no format specifiers that apply directly to a _Bool datatype, so the user is left making a choice as to what specifier fits best. I think hhd and hhu are both equally reasonable types, as are the d and u groups directly -- I don't think we should warn on either of those specifiers with a _Bool argument. I could maybe see a case for pedantically diagnosing h, l, and ll prefixes with _Bool because that seems a bit type-confused to me. c as a specifier seems weird (given that false values will potentially terminate the string suddenly depending on terminal behavior, IIRC), but lc seems like type confusion again.

Aug 28 2019, 1:01 PM · Restricted Project, Restricted Project

Aug 27 2019

erik.pilkington created D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd.
Aug 27 2019, 6:20 PM · Restricted Project, Restricted Project

Aug 22 2019

erik.pilkington accepted D66622: [Bugfix] fix r369705 unit test.

LGTM, thanks for fixing this!

Aug 22 2019, 3:49 PM · Restricted Project, Restricted Project

Aug 14 2019

erik.pilkington added a comment to D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression).

Hmm, looks like this patch fails to fix the case where we're referencing the variable in an non-odr use context, since we don't even bother to instantiate the initializer here:

Aug 14 2019, 11:17 AM · Restricted Project
erik.pilkington committed rGaa3855694ff4: [Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey (authored by erik.pilkington).
[Sema][ObjC] Fix a -Wformat false positive with localizedStringForKey
Aug 14 2019, 10:00 AM

Aug 13 2019

erik.pilkington updated the diff for D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value.

Address review comments.

Aug 13 2019, 4:40 PM · Restricted Project
erik.pilkington committed rG6c97f8898685: Add a missing header comment, NFC (authored by erik.pilkington).
Add a missing header comment, NFC
Aug 13 2019, 3:05 PM
erik.pilkington edited reviewers for D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value, added: rjmccall; removed: manmanren.
Aug 13 2019, 2:41 PM · Restricted Project
erik.pilkington updated the diff for D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value.

Special case localizedStringForKey instead of using an attribute.

Aug 13 2019, 2:41 PM · Restricted Project
erik.pilkington commandeered D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value.

Stealing this (with Alex's permission). I think it makes more sense to add a special case for the method -[NSBundle localizedStringForKey:value:table:] rather then add a new general purpose attribute that'll only be used in one place.

Aug 13 2019, 2:41 PM · Restricted Project

Aug 12 2019

erik.pilkington committed rG055fcec78cf6: [Sema] Check __builtin_bit_cast operand for completeness before materializing… (authored by erik.pilkington).
[Sema] Check __builtin_bit_cast operand for completeness before materializing…
Aug 12 2019, 12:30 PM
erik.pilkington committed rG0a223d981e6d: [Sema] Require a complete type for __builtin_bit_cast operands (authored by erik.pilkington).
[Sema] Require a complete type for __builtin_bit_cast operands
Aug 12 2019, 11:32 AM

Aug 2 2019

erik.pilkington committed rG06cccc5e6f7a: Remove a dead diagnostic, NFC (authored by erik.pilkington).
Remove a dead diagnostic, NFC
Aug 2 2019, 12:27 PM
erik.pilkington created D65665: Support for attributes on @class declarations.
Aug 2 2019, 10:51 AM · Restricted Project

Jul 30 2019

erik.pilkington updated the diff for D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression).

Rebase on top of r367367.

Jul 30 2019, 4:53 PM · Restricted Project
erik.pilkington committed rG4cae092099df: [Sema] Actually map a variable template specialization from pattern to… (authored by erik.pilkington).
[Sema] Actually map a variable template specialization from pattern to…
Jul 30 2019, 4:39 PM
erik.pilkington committed rGbe19c48f6d6b: [Parser] Lambda capture lists can start with '*' (authored by erik.pilkington).
[Parser] Lambda capture lists can start with '*'
Jul 30 2019, 12:23 PM

Jul 26 2019

erik.pilkington created D65359: [Sema] Map from a variable template specialization in a pattern to a variable template specialization in an instantiation properly .
Jul 26 2019, 5:03 PM · Restricted Project
erik.pilkington updated the diff for D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression).

Fix the type of the MemberExpr/DeclRefExpr after instantiating the variable initializer.

Jul 26 2019, 4:55 PM · Restricted Project

Jul 19 2019

erik.pilkington created D65022: [Sema] Always instantiate the initializer of a variable template with undeduced type (8.0 regression).
Jul 19 2019, 2:50 PM · Restricted Project

Jul 12 2019

erik.pilkington added inline comments to D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}.
Jul 12 2019, 2:46 PM · Restricted Project
erik.pilkington updated the diff for D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}.

Address review comments.

Jul 12 2019, 2:46 PM · Restricted Project

Jul 11 2019

erik.pilkington created D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}.
Jul 11 2019, 3:12 PM · Restricted Project

Jul 9 2019

erik.pilkington committed rGabffae3a563d: [ObjC] Add a warning for implicit conversions of a constant non-boolean value… (authored by erik.pilkington).
[ObjC] Add a warning for implicit conversions of a constant non-boolean value…
Jul 9 2019, 10:32 AM

Jul 8 2019

erik.pilkington updated the diff for D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL.

Address review comments.

Jul 8 2019, 5:12 PM · Restricted Project, Restricted Project
erik.pilkington added inline comments to D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL.
Jul 8 2019, 5:12 PM · Restricted Project, Restricted Project
erik.pilkington committed rGfa591c370d24: [ObjC] Add a -Wtautological-compare warning for BOOL (authored by erik.pilkington).
[ObjC] Add a -Wtautological-compare warning for BOOL
Jul 8 2019, 4:46 PM
erik.pilkington added a comment to D63856: [ObjC] Add a -Wtautological-compare warning for BOOL.

This only applies to relational operators, right? I'm a little uncomfortable with calling this "tautological" since it's not like it's *undefined behavior* to have (BOOL) 2, it's just *unwise*. But as long as we aren't warning about reasonable idioms that are intended to handle unfortunate situations — like other code that might have left a non-{0,1} value in the BOOL — I think this is fine.

I think the party line is that it is undefined behaviour (in some sense), since UBSan will happily crash if you try to load a non-boolean value from a BOOL.

What? Since when?

https://reviews.llvm.org/D27607

Interesting; I'm not sure I find that convincing. Probably the least convincing part is where it links to its own behavioral documentation as justification for doing what it does. But okay, I guess we do this.

Jul 8 2019, 4:46 PM · Restricted Project, Restricted Project
erik.pilkington added a comment to D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL.

Ping!

Jul 8 2019, 1:25 PM · Restricted Project, Restricted Project
erik.pilkington added a comment to D63856: [ObjC] Add a -Wtautological-compare warning for BOOL.

Ping!

Jul 8 2019, 1:25 PM · Restricted Project, Restricted Project

Jul 2 2019

erik.pilkington committed rGeee944e7f9e6: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast (authored by erik.pilkington).
[C++2a] Add __builtin_bit_cast, used to implement std::bit_cast
Jul 2 2019, 11:29 AM

Jun 28 2019

erik.pilkington added a comment to D63954: Add lifetime categories attributes.

We explicitly allow to add an annotation after
the definition of the class to allow adding annotations
to external source from by the user, e.g.

#include <vector>

namespace std {
template<typename T, typename Alloc>
class [[gsl::Owner(T)]] vector;
}
Jun 28 2019, 2:20 PM · Restricted Project, Restricted Project
erik.pilkington committed rG9a6cef74d8a9: [demangle] Support for C++2a char8_t (authored by erik.pilkington).
[demangle] Support for C++2a char8_t
Jun 28 2019, 12:57 PM

Jun 27 2019

erik.pilkington added a reviewer for D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL: arphaman.
Jun 27 2019, 5:31 PM · Restricted Project, Restricted Project
erik.pilkington created D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL.
Jun 27 2019, 5:31 PM · Restricted Project, Restricted Project
erik.pilkington added a comment to D63856: [ObjC] Add a -Wtautological-compare warning for BOOL.

This only applies to relational operators, right? I'm a little uncomfortable with calling this "tautological" since it's not like it's *undefined behavior* to have (BOOL) 2, it's just *unwise*. But as long as we aren't warning about reasonable idioms that are intended to handle unfortunate situations — like other code that might have left a non-{0,1} value in the BOOL — I think this is fine.

I think the party line is that it is undefined behaviour (in some sense), since UBSan will happily crash if you try to load a non-boolean value from a BOOL.

What? Since when?

Jun 27 2019, 11:13 AM · Restricted Project, Restricted Project

Jun 26 2019

erik.pilkington added a comment to D63856: [ObjC] Add a -Wtautological-compare warning for BOOL.

This only applies to relational operators, right? I'm a little uncomfortable with calling this "tautological" since it's not like it's *undefined behavior* to have (BOOL) 2, it's just *unwise*. But as long as we aren't warning about reasonable idioms that are intended to handle unfortunate situations — like other code that might have left a non-{0,1} value in the BOOL — I think this is fine.

Jun 26 2019, 11:31 PM · Restricted Project, Restricted Project
erik.pilkington created D63856: [ObjC] Add a -Wtautological-compare warning for BOOL.
Jun 26 2019, 5:28 PM · Restricted Project, Restricted Project
erik.pilkington committed rGd7999cbc6eb5: [ObjC] Improve error message for a malformed objc-type-name (authored by erik.pilkington).
[ObjC] Improve error message for a malformed objc-type-name
Jun 26 2019, 4:40 PM

Jun 24 2019

erik.pilkington updated the diff for D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast.

Address review comments.

Jun 24 2019, 2:47 PM · Restricted Project, Restricted Project
erik.pilkington added inline comments to D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast.
Jun 24 2019, 2:47 PM · Restricted Project, Restricted Project

Jun 19 2019

erik.pilkington added inline comments to D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast.
Jun 19 2019, 4:54 PM · Restricted Project, Restricted Project
erik.pilkington updated the diff for D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast.

Address review comments, thanks!

Jun 19 2019, 4:54 PM · Restricted Project, Restricted Project
erik.pilkington added inline comments to D62960: Add SVE opaque built-in types.
Jun 19 2019, 11:04 AM · Restricted Project, Restricted Project

Jun 18 2019

erik.pilkington committed rGcf8c6cfcdc82: [demangle] Special case clang's creative mangling of __uuidof expressions. (authored by erik.pilkington).
[demangle] Special case clang's creative mangling of __uuidof expressions.
Jun 18 2019, 4:32 PM

Jun 13 2019

erik.pilkington added a comment to D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast.

Can we also use the same bit reader/writer implementation to generalize the current implementation of __builtin_memcpy and friends? (I don't think we can remove the existing implementation, sadly, since we allow copying arrays of the same trivially-copyable type today even if it contains pointers and unions and such.)

Jun 13 2019, 12:43 PM · Restricted Project, Restricted Project
erik.pilkington updated the diff for D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast.

Address review comments.

Jun 13 2019, 12:43 PM · Restricted Project, Restricted Project

Jun 11 2019

erik.pilkington created D63176: [SemaObjC] Infer availability of stuff declared in categories from the availability of the enclosing category.
Jun 11 2019, 5:03 PM · Restricted Project

Jun 10 2019

erik.pilkington committed rG65831d049964: [demangle] Vendor extended types shouldn't be considered substitution candidates (authored by erik.pilkington).
[demangle] Vendor extended types shouldn't be considered substitution candidates
Jun 10 2019, 2:03 PM
erik.pilkington added inline comments to D62960: Add SVE opaque built-in types.
Jun 10 2019, 10:31 AM · Restricted Project, Restricted Project

Jun 5 2019

erik.pilkington added a comment to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.

I think this looks good from a clang perspective. No reason to land it before the dust settles on D62433 though.

Jun 5 2019, 2:41 PM · Restricted Project, Restricted Project
erik.pilkington added inline comments to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.
Jun 5 2019, 11:16 AM · Restricted Project, Restricted Project

Jun 3 2019

erik.pilkington accepted D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'.

I thinks this looks good, aside from a null concern.

Jun 3 2019, 5:09 PM · Restricted Project, Restricted Project
erik.pilkington created D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast.
Jun 3 2019, 3:11 PM · Restricted Project, Restricted Project