Page MenuHomePhabricator

[CMake] In standalone builds, LLVM_BINARY_DIR should point to LLVM's binary directory
ClosedPublic

Authored by sgraenitz on Tue, Jan 8, 7:53 AM.

Details

Summary

In standalone builds LLVM_BINARY_DIR was equal to LLDB_BINARY_DIR so far. This is counterintuitive and invalidated the values of LLDB_DEFAULT_TEST_DSYMUTIL/FILECHECK/COMPILER etc.

Diff Detail

Repository
rL LLVM

Event Timeline

sgraenitz created this revision.Tue, Jan 8, 7:53 AM
sgraenitz updated this revision to Diff 180683.Tue, Jan 8, 8:44 AM

Use LLVM_BINARY_DIR when checking for existance of libc++ include directory

labath accepted this revision.Tue, Jan 8, 9:05 AM

Makes sense to me.

CMakeLists.txt
117 ↗(On Diff #180683)

typo (but BINRAY sounds cool, we should make that mean something :P).

This revision is now accepted and ready to land.Tue, Jan 8, 9:05 AM
sgraenitz updated this revision to Diff 180830.Wed, Jan 9, 6:15 AM
sgraenitz marked an inline comment as done.

Fix typo

sgraenitz marked an inline comment as done.Wed, Jan 9, 6:16 AM
sgraenitz added inline comments.
CMakeLists.txt
117 ↗(On Diff #180683)

Woooow thanks!

This revision was automatically updated to reflect the committed changes.