This is just changing naming and documentation to be general about external definitions that can be imported for cross translation unit analysis. There is at least a plan to add VarDecls: D46421
NoQ xazax.hun martong a.sidorin george.karpenkov serge-sans-paille
- rC350852: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external…
rG8c48705a1975: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external…
rL350852: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external…
Thanks for the quick response! Will wait a couple days to see if someone else has something to add.
But I think something is wrong here...
When trying to "arc diff" I got the following error:
Exception Command failed with error #1! COMMAND svn propget 'svn:mime-type' '/data/work/commitllvm/llvm/tools/clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp'@ STDOUT (empty) STDERR svn: warning: W200017: Property 'svn:mime-type' not found on '/data/work/commitllvm/llvm/tools/clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp@' svn: E200000: A problem occurred; see other errors for details
So I did:
svn propset svn:mime-type text/plain tools/clang-extdef-mapping/ClangExtDefMapGen.cpp
This was on all the new/renamed files.
Now this diff shows some weird "svn:mime-type" changes which are probably unwanted. But only on two of the new files (?).
I only found this online, but weird that no one else is having this issue: https://secure.phabricator.com/T10608
Hmm, this fails for me. The substitution fails for some reason:
FAIL: Clang :: Analysis/func-mapping-test.cpp (211 of 569) ******************** TEST 'Clang :: Analysis/func-mapping-test.cpp' FAILED ******************** Script: -- : 'RUN: at line 1'; %clang_extdef_map /Users/adergachev/svn/llvm/tools/clang/test/Analysis/func-mapping-test.cpp -- | /Users/adergachev/svn/release/bin/FileCheck /Users/adergachev/svn/llvm/tools/clang/test/Analysis/func-mapping-test.cpp -- Exit Code: 2 Command Output (stderr): -- /Users/adergachev/svn/release/tools/clang/test/Analysis/Output/func-mapping-test.cpp.script: line 1: %clang_extdef_map: command not found FileCheck error: '-' is empty. FileCheck command line: /Users/adergachev/svn/release/bin/FileCheck /Users/adergachev/svn/llvm/tools/clang/test/Analysis/func-mapping-test.cpp -- ******************** Testing Time: 5.12s ******************** Failing Tests (1): Clang :: Analysis/func-mapping-test.cpp
I'm not really good with LIT and i don't immediately see any problems here. If it only fails for me, please let me know so that i could see if the problem is on my end or otherwise help investigating the problem :)
Hmm, it disappeared after a clean rebuild. I think the problem was that i did make clang and then ran tests manually, instead of make, so the tool was not rebuilt and was only present under its old name. Because the tool does get rebuilt under make check-clang-analysis, i guess i was just doing an unsupported thing.
Sry for distraction, pls nvm :)