- User Since
- Aug 23 2017, 7:34 AM (112 w, 2 d)
Fri, Oct 11
Jul 29 2019
Jul 12 2019
Jul 10 2019
This should be trivial enough to just commit, but I'd just be more comfortable if someone looked at it before, because this is my first commit in this area of clang.
Apr 23 2019
@xazax.hun Yes, I planned to just commit. Set you as Subscriber not Reviewer in Arc. Was just a bit confused why it fails at first :)
Apr 22 2019
@xazax.hun good point and that actually fixes a bug since that branch should also do the deep check. Added that to the tests.
Apr 9 2019
- addressed review comments
- created cross_tu::containsConst
- fixed bug that unions were not exported
- added TODO test for constructor case
Apr 8 2019
ASTContext::getParents should not be used this way. This use-case is solved by function-scoped ParentMaps or AnalysisDeclContext::getParentMap. Discussion: http://lists.llvm.org/pipermail/cfe-dev/2019-April/061944.html
Apr 5 2019
Okay so I would suggest to go ahead and commit this. Rebased it succeeds without modification.
Feb 8 2019
Feb 1 2019
Thanks for the comments! All good points. Nice idea with the constructor, but that can probably happen in a follow up patch.
Jan 29 2019
Jan 11 2019
Strip name changes (see D56441); addressed review comments
Jan 10 2019
addressed review comments
Jan 8 2019
Thanks for the quick response! Will wait a couple days to see if someone else has something to add.
Jan 7 2019
I tried adding isGLValue to evalStore and the test suite didn't complain. For evalLoad (on BoundEx) it failed in pretty much every test. Should the evalStore assert also go into trunk?
Dec 14 2018
Please let me know if there is anything else that should be addressed.
cfe-dev thread with short discussion: http://lists.llvm.org/pipermail/cfe-dev/2018-April/057562.html
Jul 11 2018
@rsmith Yes, this should generally better be handled outside of the ASTContext. That would be out of scope of this patch. Is it fine to proceed with this one for now?
Jul 9 2018
Jul 5 2018
Alright, but then I would suggest to pass an invalid loc to the constructors instead to make it more explicit and save a map lookup in the import function.
Jul 4 2018
Jun 26 2018
@rsmith do you have a chance to take a look or assign someone else?
Jun 25 2018
improved code quality; added nested macro test. it "works", but is disabled because it revealed another bug: the function end location is not imported. will send a patch
Jun 22 2018
addressed review comment, but there is nothing like FullSourceRange to improve everything
Jun 20 2018
Jun 13 2018
remove stray include
Jun 5 2018
- add missing AnalysisConsumer diff
- only collect const qualified vardecls in the extdef index and adjust test
Jun 4 2018
The split-token case should be covered by this, because it takes the correct TokenLen and the isTokenRange flag. Other than that the split-token ExpansionInfo is indistinguishable.
May 29 2018
May 28 2018
Added FIXME tests.
I'm not really too confident to approve changes yet, but with a second opinion it should be fine.
May 18 2018
May 17 2018
addressed review comments
May 16 2018
May 15 2018
I looked through the original patches and found quite a few more occurrences of "function map" and renamed them - including the tool "clang-func-mapping". There is one comment "by using the 'clang-extdef-mapping' packaged with Xcode (on OS X)". Is this implicit from the install targets that the tool name changed or do I have to inform someone?
May 14 2018
- added tests
- updated doc and var naming
- addressed review comment
May 9 2018
May 8 2018
Didn't see that overload, thanks!
May 7 2018
full patch with test
May 4 2018
Tests and doc fixes pending. First I'm interested in your thoughts to this change.
addressed the comments, thanks!
May 3 2018
Maybe this is a user error of CrossTU, but it seemed to import a FuncDecl with attributes, causing the imported FuncDecl to have all those attributes twice. That's why I thought merging would maybe make sense. However I did not encounter any issue with the duplicate attributes. Only the wrong source locations produced odd crashes.
It puts everything at the start of the marco expansion.
May 2 2018
I encountered an issue caused by this change.