While writing a patch I noticed myself removing a few else statements after return statements. Rather than doing this ad-hoc I remembered there's a clang-tidy pass that does this.
https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
So essentially what I did was run the following command over the LLDB code base:
run-clang-tidy.py -checks='-*,readability-else-after-return' -format -fix $PWD
I'm not sure if it's worth the churn, but I do believe lldb could benefit from some reduced indentation.
PS: Diff is without context, otherwise it exceeds the Phabricator limit of 8 megabytes.
This function probably could use some manual refactoring, too.