Page MenuHomePhabricator

[PPC64][PPC] add tests for R_PPC64_REL14 R_PPC_REL14
Needs ReviewPublic

Authored by martell on Dec 9 2018, 6:26 PM.

Details

Summary

As a follow up to rLLD348255
I wanted to add some tests to ensure we don't regress the creation of these relocations in future on the generation side from llvm

Diff Detail

Repository
rL LLVM

Event Timeline

martell created this revision.Dec 9 2018, 6:26 PM
martell updated this revision to Diff 177453.Dec 9 2018, 6:35 PM

add context

martell removed a subscriber: nemanjai.
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: rupprecht. · View Herald Transcript

@sfertile Do you have any comments regarding this as you're most familiar with this part of the PPC backend?

Overall patch LGTM. Thanks for adding this. I have one small question about the llvm-readobj test though. IIUC the python file is used to generate the output files for test/tools/llvm-readobj/reloc-types.test. Do we need to run the python script to get the updated relocs.obj.elf-ppc64 file and update the checks for the added relocations in reloc-types.test?