Page MenuHomePhabricator

Remove stat cache chaining as it's no longer needed after PTH support has been removed
ClosedPublic

Authored by arphaman on Dec 7 2018, 1:11 PM.

Details

Summary

Stat cache chaining was implemented for a StatListener in the PTH writer so that it could write out the stat information to PTH. r348266 removed support for PTH, and it doesn't seem like there are other uses of stat cache chaining. We can remove the chaining support.

Diff Detail

Repository
rC Clang

Event Timeline

arphaman created this revision.Dec 7 2018, 1:11 PM

I've no problem with this, but I don't consider myself 'expert' on this stuff enough to mark 'Approve' without giving others time to take a look. I'd say give this until this time tuesday for the others to take a look, then you can consider this an 'approve'.

I won't mark it as such so as to not scare away other reviews :)

This patch LGTM, but before committing I suggest sending an RFC to cfe-dev and waiting a few days.

This patch LGTM, but before committing I suggest sending an RFC to cfe-dev and waiting a few days.

I posted to cfe-dev to check if there are any objections.

Yay! Anything that makes FileManager and friends simpler LG

dexonsmith accepted this revision.Dec 13 2018, 9:04 AM

It has been about a week since your cfe-dev post with no concerns. I think you can commit.

This revision is now accepted and ready to land.Dec 13 2018, 9:04 AM
This revision was automatically updated to reflect the committed changes.