[OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp - (NFC)

[saghir]

Summary

In ParseOpenMP.cpp:

bool ColonExpected = false;
...
...
...
else if (ColonExpected)
      Diag(Tok, diag::warn_pragma_expected_colon) << "map type";

The flag ColonExpected is not changed after being initialized to false at declaration. Hence, the code within the else if is never executed.

We should remove all instances of this flag.

[ABataev]

LG

cfe/trunk/lib/Parse/ParseOpenMP.cpp

// Handle dependency type for depend clause.
     // map-type-modifier. The map modifier can also be delete which has the same
     // spelling of the C++ delete keyword.
     Data.MapType =
         IsMapClauseModifierToken(Tok)
             ? static_cast<OpenMPMapClauseKind>(
                   getOpenMPSimpleClauseType(Kind, PP.getSpelling(Tok)))
             : OMPC_MAP_unknown;
     Data.DepLinMapLoc = Tok.getLocation();
-    bool ColonExpected = false;
 
     if (IsMapClauseModifierToken(Tok)) {
       if (PP.LookAhead(0).is(tok::colon)) {
         if (Data.MapType == OMPC_MAP_unknown)
           Diag(Tok, diag::err_omp_unknown_map_type);
         else if (Data.MapType == OMPC_MAP_always)
           Diag(Tok, diag::err_omp_map_type_missing);
         ConsumeToken();
if (IsMapClauseModifierToken(Tok)) {
       }
     } else {
       Data.MapType = OMPC_MAP_tofrom;
       Data.IsMapTypeImplicit = true;
     }
 
     if (Tok.is(tok::colon))
       Data.ColonLoc = ConsumeToken();
-    else if (ColonExpected)
-      Diag(Tok, diag::warn_pragma_expected_colon) << "map type";
   }
 
   bool IsComma =
       (Kind != OMPC_reduction && Kind != OMPC_task_reduction &&
        Kind != OMPC_in_reduction && Kind != OMPC_depend && Kind != OMPC_map) ||
       (Kind == OMPC_reduction && !InvalidReductionId) ||
       (Kind == OMPC_map && Data.MapType != OMPC_MAP_unknown) ||
       (Kind == OMPC_depend && Data.DepKind != OMPC_DEPEND_unknown);