This adds support for the 'event section' specified in the exception
handling proposal.
Wasm exception handling binary model spec
Companion to D55247.
Paths
| Differential D54875
[WebAssembly] Add support for the event section ClosedPublic Authored by aheejin on Nov 25 2018, 12:44 AM.
Details Summary This adds support for the 'event section' specified in the exception Wasm exception handling binary model spec Companion to D55247.
Diff Detail
Event TimelineHerald added subscribers: llvm-commits, sunfish, jgravelle-google. · View Herald TranscriptNov 25 2018, 12:44 AM aheejin added a parent revision: D54874: [WebAssembly] Make Signature an optional property for every type. Comment Actions lgtm % nits and the question of whether we leave SigIndex as part of the EventType in wasm.h.
Comment Actions Overall, this patch needs more comments. lld should be readable to those who knows what the linker is but don't know too much about wasm, so you should explain what event symbol/section/etc. are.
aheejin removed a parent revision: D54874: [WebAssembly] Make Signature an optional property for every type.Dec 3 2018, 4:21 PM Herald added subscribers: dexonsmith, steven_wu, mehdi_amini. · View Herald TranscriptDec 3 2018, 7:57 PM
Comment Actions @ruiu I add some comments here and there, but it's hard to explain the concept of wasm event fully in the comments only. Wasm globals seem to not have comments for the same reason. aheejin added a parent revision: D55247: [WebAssembly] Make WasmSymbol's signature usable for events (NFC).Dec 3 2018, 8:07 PM aheejin mentioned this in D55247: [WebAssembly] Make WasmSymbol's signature usable for events (NFC). Comment Actions This change is looking nice! The only thing I'm not sure about is the header file named "InputEntity.h". This names doesn't mean much. Perhaps we can avoid the problem by just have InputGlobal.h and InputEvent.h as separate headers? Aside form that an couple of nits this lgtm.
aheejin marked 3 inline comments as done. Comment Actions
This revision is now accepted and ready to land.Dec 7 2018, 10:58 AM Comment Actions LGTM
Closed by commit rL348703: [WebAssembly] Add support for the event section (authored by aheejin). · Explain WhyDec 7 2018, 10:20 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 176539 include/lld/Common/LLVM.h
test/wasm/Inputs/event-section1.ll
test/wasm/Inputs/event-section2.ll
test/wasm/event-section.ll
wasm/Driver.cpp
wasm/InputChunks.cpp
wasm/InputEntity.h
wasm/InputFiles.h
wasm/InputFiles.cpp
wasm/InputGlobal.h
wasm/LTO.cpp
wasm/MarkLive.cpp
wasm/OutputSections.cpp
wasm/SymbolTable.h
wasm/SymbolTable.cpp
wasm/Symbols.h
wasm/Symbols.cpp
wasm/Writer.cpp
wasm/WriterUtils.h
wasm/WriterUtils.cpp
|
nit: alphabetize