This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Change GnuPub{Names,Types}Section from StringRef to LLDDWARFSection
ClosedPublic

Authored by MaskRay on Nov 10 2018, 1:19 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Nov 10 2018, 1:19 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2018, 11:00 AM
This revision was automatically updated to reflect the committed changes.
ruiu added inline comments.Nov 11 2018, 5:37 PM
lld/trunk/ELF/SyntheticSections.cpp
2517

Is the object you get with the following line

auto &Obj = static_cast<const LLDDwarfObj<ELFT> &>(Dwarf.getDWARFObj());

the same object as you create at this line? If so, I'd pass the object you are creating with make_unique to readPubNamesAndTypes instead of passing a Dwarf object.