Page MenuHomePhabricator

[clang-tidy] add IgnoreMacros option to modernize-use-equals-delete
ClosedPublic

Authored by vmiklos on Oct 12 2018, 2:19 PM.

Details

Summary

And also enable it by default to be consistent with e.g. modernize-use-using.
This improves consistency inside the check itself as well: both checks are now
disabled in macros by default.

This helps e.g. when running this check on client code where the macro is
provided by the system, so there is no easy way to modify it.

Diff Detail

Repository
rL LLVM

Event Timeline

vmiklos created this revision.Oct 12 2018, 2:19 PM
Eugene.Zelenko retitled this revision from clang-tidy: add IgnoreMacros option to modernize-use-equals-delete to [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete.Oct 12 2018, 2:23 PM
Eugene.Zelenko added a project: Restricted Project.
alexfh accepted this revision.Oct 12 2018, 5:49 PM

LG with a nit.

clang-tidy/modernize/UseEqualsDeleteCheck.h
46 ↗(On Diff #169490)

Clang-format this, please (it should add an empty line before the access modifier).

This revision is now accepted and ready to land.Oct 12 2018, 5:49 PM
This revision was automatically updated to reflect the committed changes.