Page MenuHomePhabricator

vmiklos (Miklos Vajna)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2016, 5:23 AM (179 w, 2 d)

Recent Activity

Mon, Sep 2

vmiklos committed rL370680: Request commit access for vmiklos.
Request commit access for vmiklos
Mon, Sep 2, 12:40 PM

Jun 21 2019

vmiklos committed rG580a8bc69ae8: [git-clang-format] recognize hxx as a C++ file (authored by vmiklos).
[git-clang-format] recognize hxx as a C++ file
Jun 21 2019, 2:49 AM
vmiklos added a comment to D63621: [git-clang-format] recognize hxx as a C++ file.

Thanks!

Jun 21 2019, 2:47 AM · Restricted Project, Restricted Project
vmiklos committed rL364014: [git-clang-format] recognize hxx as a C++ file.
[git-clang-format] recognize hxx as a C++ file
Jun 21 2019, 2:46 AM
vmiklos closed D63621: [git-clang-format] recognize hxx as a C++ file.
Jun 21 2019, 2:46 AM · Restricted Project, Restricted Project

Jun 20 2019

vmiklos created D63621: [git-clang-format] recognize hxx as a C++ file.
Jun 20 2019, 1:02 PM · Restricted Project, Restricted Project

Jan 20 2019

vmiklos closed D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods.
Jan 20 2019, 6:32 AM · Restricted Project
vmiklos added a comment to D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods.

Sorry, forgot to use the magic line at the end of the commit message to auto-close this review. Done in r351686, anyhow.

Jan 20 2019, 6:30 AM · Restricted Project
vmiklos committed rCTE351686: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit….
[clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit…
Jan 20 2019, 6:30 AM
vmiklos committed rL351686: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit….
[clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit…
Jan 20 2019, 6:30 AM
vmiklos updated the diff for D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods.
Jan 20 2019, 5:47 AM · Restricted Project
vmiklos added a comment to D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods.

I also noticed I forgot to clang-format the testcase, done now.

Jan 20 2019, 5:46 AM · Restricted Project

Jan 19 2019

vmiklos set the repository for D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods to rCTE Clang Tools Extra.
Jan 19 2019, 12:52 PM · Restricted Project
vmiklos created D56966: [clang-tidy] misc-non-private-member-variables-in-classes: ignore implicit methods.
Jan 19 2019, 12:50 PM · Restricted Project

Jan 11 2019

vmiklos committed rCTE350922: [clang-tidy] new check 'readability-redundant-preprocessor'.
[clang-tidy] new check 'readability-redundant-preprocessor'
Jan 11 2019, 12:05 AM
vmiklos committed rL350922: [clang-tidy] new check 'readability-redundant-preprocessor'.
[clang-tidy] new check 'readability-redundant-preprocessor'
Jan 11 2019, 12:05 AM
vmiklos closed D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Jan 11 2019, 12:04 AM · Restricted Project

Jan 10 2019

vmiklos added a comment to D54450: Get the correct range of tokens for preprocessor conditions.

@aaron.ballman do you wait for someone else to commit this? Thanks.

Jan 10 2019, 1:02 PM

Jan 3 2019

vmiklos added a comment to D54450: Get the correct range of tokens for preprocessor conditions.

Could you please review this one? It would be especially helpful, due to the depending other review. Thanks!

Jan 3 2019, 1:15 PM

Dec 24 2018

vmiklos committed rCTE350056: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix.
[clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix
Dec 24 2018, 9:51 AM
vmiklos added a comment to D56025: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix.

LGTM, do you have commit rights?

Dec 24 2018, 9:51 AM
vmiklos committed rL350056: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix.
[clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix
Dec 24 2018, 9:51 AM
vmiklos closed D56025: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix.
Dec 24 2018, 9:50 AM

Dec 21 2018

vmiklos added inline comments to D56025: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix.
Dec 21 2018, 3:09 PM
vmiklos updated the diff for D56025: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix.
Dec 21 2018, 3:08 PM
vmiklos created D56025: [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix.
Dec 21 2018, 2:20 PM

Dec 19 2018

vmiklos added a comment to D54450: Get the correct range of tokens for preprocessor conditions.

Ping, could this be reviewed, please? :-) Thanks!

Dec 19 2018, 8:25 AM

Dec 8 2018

vmiklos added a comment to D54450: Get the correct range of tokens for preprocessor conditions.

Next ping -- could you please review this one? Thanks! :-)

Dec 8 2018, 5:56 AM

Nov 26 2018

vmiklos added a comment to D54450: Get the correct range of tokens for preprocessor conditions.

Could you please review this at some stage? As mentioned previously, this is a dependency for D54349. Thanks!

Nov 26 2018, 8:01 AM

Nov 16 2018

vmiklos added a comment to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.

I think this check is in good shape for the initial commit. Additional functionality can be added incrementally.

Nov 16 2018, 2:21 PM · Restricted Project
vmiklos added inline comments to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 16 2018, 2:04 PM · Restricted Project
vmiklos added inline comments to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 16 2018, 1:20 PM · Restricted Project
vmiklos updated the diff for D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 16 2018, 1:19 PM · Restricted Project

Nov 14 2018

vmiklos updated the diff for D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 14 2018, 5:36 AM · Restricted Project
vmiklos added inline comments to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 14 2018, 5:36 AM · Restricted Project
vmiklos added a comment to D54450: Get the correct range of tokens for preprocessor conditions.

Oh, and running the check-clang-tools target, this currently results in:

Nov 14 2018, 5:19 AM
vmiklos added a comment to D54450: Get the correct range of tokens for preprocessor conditions.

As far as I see GCC warns on these 3 things.

Nov 14 2018, 4:57 AM

Nov 11 2018

vmiklos updated the diff for D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 11 2018, 1:05 PM · Restricted Project
vmiklos added inline comments to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 11 2018, 1:04 PM · Restricted Project
vmiklos added inline comments to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 11 2018, 12:37 PM · Restricted Project
vmiklos updated the diff for D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 11 2018, 12:37 PM · Restricted Project
vmiklos added a comment to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.

Let's see if that works in practice.

Nov 11 2018, 7:28 AM · Restricted Project
vmiklos updated the diff for D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 11 2018, 7:27 AM · Restricted Project
vmiklos added a comment to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.

As it stands, I feel like this check is a bit too simplistic to have much value, but if you covered some of these other cases, it would alleviate that worry for me.

Nov 11 2018, 5:24 AM · Restricted Project
vmiklos updated the diff for D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 11 2018, 5:20 AM · Restricted Project

Nov 10 2018

vmiklos updated the diff for D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 10 2018, 12:31 PM · Restricted Project
vmiklos added inline comments to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 10 2018, 12:31 PM · Restricted Project
vmiklos added a comment to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.

What do you think about code like:

#if FOO == 4
#if FOO == 4
#endif
#endif

#if defined(FOO)
#if defined(FOO)
#endif
#endif

#if !defined(FOO)
#if !defined(FOO)
#endif
#endif
Nov 10 2018, 12:23 PM · Restricted Project
vmiklos updated the diff for D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 10 2018, 12:22 PM · Restricted Project

Nov 9 2018

vmiklos added a comment to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.

preprocessor directives? Same in documentation.

Nov 9 2018, 4:16 PM · Restricted Project
vmiklos updated the diff for D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 9 2018, 4:16 PM · Restricted Project
vmiklos added a comment to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.

I think that name is not very descriptive for the user of clang-tidy. pp
should be preprocessor or some other constellation that makes it very clear
its about the preprocessor.

Nov 9 2018, 4:12 PM · Restricted Project
vmiklos updated the diff for D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 9 2018, 4:11 PM · Restricted Project
vmiklos added a comment to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.

No one will know for sure what "pp" in "readability-redundant-pp" means.
I'd highly recommend to fully spell it out.

Nov 9 2018, 1:44 PM · Restricted Project
vmiklos added a comment to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.

I've used this check originally on LibreOffice (core, online) code and it found a handful of not necessary ifdef / ifndef lines. It seemed it's simple and generic enough that it would make sense to upstream this.

Nov 9 2018, 1:25 PM · Restricted Project
vmiklos created D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 9 2018, 1:19 PM · Restricted Project

Oct 21 2018

vmiklos committed rCTE344885: ReleaseNotes: move readability-redundant-smartptr-get part down below new checks.
ReleaseNotes: move readability-redundant-smartptr-get part down below new checks
Oct 21 2018, 11:39 PM
vmiklos committed rL344885: ReleaseNotes: move readability-redundant-smartptr-get part down below new checks.
ReleaseNotes: move readability-redundant-smartptr-get part down below new checks
Oct 21 2018, 11:38 PM
vmiklos added inline comments to rCTE344871: [clang-tidy] add IgnoreMacros option to readability-redundant-smartptr-get.
Oct 21 2018, 11:38 PM
vmiklos committed rCTE344871: [clang-tidy] add IgnoreMacros option to readability-redundant-smartptr-get.
[clang-tidy] add IgnoreMacros option to readability-redundant-smartptr-get
Oct 21 2018, 12:19 PM
vmiklos committed rL344871: [clang-tidy] add IgnoreMacros option to readability-redundant-smartptr-get.
[clang-tidy] add IgnoreMacros option to readability-redundant-smartptr-get
Oct 21 2018, 12:19 PM
vmiklos closed D53454: [clang-tidy] add IgnoreMacros option to eadability-redundant-smartptr-get.
Oct 21 2018, 12:19 PM
vmiklos added a comment to D53454: [clang-tidy] add IgnoreMacros option to eadability-redundant-smartptr-get.

LGTM, but could you please add a short notice in the release notes?

Oct 21 2018, 12:17 PM

Oct 19 2018

vmiklos added a comment to D53454: [clang-tidy] add IgnoreMacros option to eadability-redundant-smartptr-get.

In practice cppunit's CPPUNIT_TEST_SUITE_END macro triggers this problem.

Oct 19 2018, 2:44 PM
vmiklos created D53454: [clang-tidy] add IgnoreMacros option to eadability-redundant-smartptr-get.
Oct 19 2018, 2:43 PM

Oct 13 2018

vmiklos committed rCTE344440: [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete.
[clang-tidy] add IgnoreMacros option to modernize-use-equals-delete
Oct 13 2018, 1:01 AM
vmiklos committed rL344440: [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete.
[clang-tidy] add IgnoreMacros option to modernize-use-equals-delete
Oct 13 2018, 1:00 AM
vmiklos closed D53217: [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete.
Oct 13 2018, 1:00 AM · Restricted Project

Oct 12 2018

vmiklos created D53217: [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete.
Oct 12 2018, 2:19 PM · Restricted Project

Mar 19 2018

vmiklos committed rL327854: run-clang-tidy: forward clang-tidy exit status.
run-clang-tidy: forward clang-tidy exit status
Mar 19 2018, 7:46 AM
vmiklos committed rCTE327854: run-clang-tidy: forward clang-tidy exit status.
run-clang-tidy: forward clang-tidy exit status
Mar 19 2018, 7:46 AM
vmiklos closed D44366: run-clang-tidy: forward clang-tidy exit status.
Mar 19 2018, 7:46 AM

Mar 17 2018

vmiklos added a comment to D44366: run-clang-tidy: forward clang-tidy exit status.

Updated patch now includes the first run-clang-tidy.py testcase. :-)

Mar 17 2018, 6:00 AM
vmiklos updated the diff for D44366: run-clang-tidy: forward clang-tidy exit status.
Mar 17 2018, 6:00 AM
vmiklos added a comment to D44366: run-clang-tidy: forward clang-tidy exit status.

Most of the tests that use a compilation database are located under llvm/tools/clang/test/Tooling/. These tests create a directory with source file(s) and a corresponding compile_commands.json file and then just run the tool on these file(s).

Mar 17 2018, 5:56 AM

Mar 13 2018

vmiklos added a comment to D44366: run-clang-tidy: forward clang-tidy exit status.

I've went with failed_files. And yes, this could be a simple reference, I just exploit the fact here that a list is passed by reference in Python.

Mar 13 2018, 5:57 AM
vmiklos updated the diff for D44366: run-clang-tidy: forward clang-tidy exit status.
Mar 13 2018, 5:53 AM

Mar 12 2018

vmiklos added a comment to D44366: run-clang-tidy: forward clang-tidy exit status.

I grepped for run-clang-tidy under tools/clang/tools/extra/test/clang-tidy/, but found nothing, so I assume run-clang-tidy has no test coverage at the moment.

Mar 12 2018, 7:18 AM

Mar 11 2018

vmiklos created D44366: run-clang-tidy: forward clang-tidy exit status.
Mar 11 2018, 7:31 AM

Jan 5 2018

vmiklos committed rCTE321913: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration….
clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration…
Jan 5 2018, 3:23 PM
vmiklos committed rL321913: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration….
clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration…
Jan 5 2018, 3:23 PM
vmiklos closed D41716: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name.
Jan 5 2018, 3:23 PM

Jan 4 2018

vmiklos added a comment to D41716: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name.

That changes the defaults though. I thought clang-tidy *tried* to produce the same results
on different clang-tidy versions with the same .clang-tidy config? Or is there no such guarantees?

Jan 4 2018, 12:17 AM

Jan 3 2018

vmiklos created D41716: clang-tidy: add IgnoreMacros option to readability-inconsistent-declaration-parameter-name.
Jan 3 2018, 2:09 PM

Sep 11 2017

vmiklos committed rL312942: clang-rename: let -force handle multiple renames.
clang-rename: let -force handle multiple renames
Sep 11 2017, 1:20 PM
vmiklos closed D37634: clang-rename: let -force handle multiple renames by committing rL312942: clang-rename: let -force handle multiple renames.
Sep 11 2017, 1:20 PM

Sep 8 2017

vmiklos created D37634: clang-rename: let -force handle multiple renames.
Sep 8 2017, 11:40 AM

Jun 2 2017

vmiklos committed rL304534: clang-rename: add new -force option.
clang-rename: add new -force option
Jun 2 2017, 2:32 AM
vmiklos closed D32403: clang-rename: add new -force option by committing rL304534: clang-rename: add new -force option.
Jun 2 2017, 2:32 AM

May 31 2017

vmiklos added a comment to D32403: clang-rename: add new -force option.

@klimek ping, do you have any further comments, please?

May 31 2017, 8:01 AM

May 17 2017

vmiklos added a comment to D32403: clang-rename: add new -force option.

Manuel, do you have any further comments, please? Thanks.

May 17 2017, 6:27 AM

May 8 2017

vmiklos committed rL302429: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init.
clang-tidy: add IgnoreMacros option to modernize-use-default-member-init
May 8 2017, 8:27 AM
vmiklos closed D32945: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init by committing rL302429: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init.
May 8 2017, 8:26 AM
vmiklos added a comment to D32945: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init.

Please change modernize-use-using to match.

May 8 2017, 7:03 AM
vmiklos updated the diff for D32945: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init.
May 8 2017, 7:02 AM

May 7 2017

vmiklos added a comment to D32945: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init.

See uses of OptionsView::getLocalOrGlobal().

May 7 2017, 1:23 PM
vmiklos updated the diff for D32945: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init.
May 7 2017, 1:20 PM
vmiklos added a comment to D32945: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init.

Should this option be shared?

May 7 2017, 2:32 AM

May 6 2017

vmiklos created D32945: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init.
May 6 2017, 12:47 PM

May 3 2017

vmiklos updated the diff for D32403: clang-rename: add new -force option.
May 3 2017, 12:22 PM