Page MenuHomePhabricator

malcolm.parsons (Malcolm Parsons)
User

Projects

User does not belong to any projects.

User Details

User Since
May 2 2013, 1:42 AM (315 w, 3 d)

Recent Activity

Feb 17 2019

malcolm.parsons added a comment to D57087: [clang-tidy] add OverrideMacro to modernize-use-override check.

Some Clang warnings use PP.getLastMacroWithSpelling() to determine the user's macro automatically.

Feb 17 2019, 7:11 AM · Restricted Project, Restricted Project

Feb 8 2019

malcolm.parsons committed rG297b6a2b6ea6: [clang-tidy] Don't use assignment for value-initialized enums (authored by malcolm.parsons).
[clang-tidy] Don't use assignment for value-initialized enums
Feb 8 2019, 11:45 AM
malcolm.parsons committed rL353554: [clang-tidy] Don't use assignment for value-initialized enums.
[clang-tidy] Don't use assignment for value-initialized enums
Feb 8 2019, 11:44 AM
malcolm.parsons committed rCTE353554: [clang-tidy] Don't use assignment for value-initialized enums.
[clang-tidy] Don't use assignment for value-initialized enums
Feb 8 2019, 11:44 AM
malcolm.parsons closed D57852: [clang-tidy] Don't use assignment for value-initialized enums.
Feb 8 2019, 11:44 AM · Restricted Project

Feb 7 2019

malcolm.parsons added a comment to D57852: [clang-tidy] Don't use assignment for value-initialized enums.

How are the semantics for enum class in this case?

Feb 7 2019, 6:48 AM · Restricted Project

Feb 6 2019

malcolm.parsons created D57852: [clang-tidy] Don't use assignment for value-initialized enums.
Feb 6 2019, 3:00 PM · Restricted Project

Feb 4 2019

malcolm.parsons committed rGa7c957fd8149: [clang-tidy] Handle unions with existing default-member-init (authored by malcolm.parsons).
[clang-tidy] Handle unions with existing default-member-init
Feb 4 2019, 1:11 PM
malcolm.parsons committed rL353092: [clang-tidy] Handle unions with existing default-member-init.
[clang-tidy] Handle unions with existing default-member-init
Feb 4 2019, 1:09 PM
malcolm.parsons committed rCTE353092: [clang-tidy] Handle unions with existing default-member-init.
[clang-tidy] Handle unions with existing default-member-init
Feb 4 2019, 1:09 PM
malcolm.parsons closed D57665: [clang-tidy] Handle unions with existing default-member-init.
Feb 4 2019, 1:09 PM · Restricted Project, Restricted Project

Feb 3 2019

malcolm.parsons created D57665: [clang-tidy] Handle unions with existing default-member-init.
Feb 3 2019, 1:47 PM · Restricted Project, Restricted Project

Nov 27 2018

malcolm.parsons committed rCTE347671: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability….
[clang-tidy] Ignore bool -> single bit bitfield conversion in readability…
Nov 27 2018, 8:26 AM
malcolm.parsons committed rL347671: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability….
[clang-tidy] Ignore bool -> single bit bitfield conversion in readability…
Nov 27 2018, 8:26 AM
malcolm.parsons closed D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion.
Nov 27 2018, 8:26 AM
malcolm.parsons added inline comments to D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion.
Nov 27 2018, 6:44 AM
malcolm.parsons created D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion.
Nov 27 2018, 2:53 AM

Oct 17 2018

malcolm.parsons accepted D53377: [clang-tidy] Ignore a case where the fix of make_unique check introduces side effect..

LGTM.

Oct 17 2018, 11:25 AM

Oct 12 2018

malcolm.parsons resigned from D53206: Allow padding checker to traverse simple class hierarchies.
Oct 12 2018, 2:02 PM · Restricted Project

Sep 10 2018

malcolm.parsons retitled D51297: [docs] Provide pointers to known editor plugins and extensions from [docs] Create a guide for Vim users on how to setup Clangd to [docs] Create a guide for Vim users on how to set up Clangd.
Sep 10 2018, 7:31 AM · Restricted Project

May 23 2018

malcolm.parsons added inline comments to D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type.
May 23 2018, 12:51 PM · Restricted Project

May 22 2018

malcolm.parsons added inline comments to D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type.
May 22 2018, 11:17 AM · Restricted Project

May 2 2018

malcolm.parsons committed rL331361: [analyzer] Fix filename in cross-file HTML report.
[analyzer] Fix filename in cross-file HTML report
May 2 2018, 7:30 AM
malcolm.parsons committed rC331361: [analyzer] Fix filename in cross-file HTML report.
[analyzer] Fix filename in cross-file HTML report
May 2 2018, 7:29 AM
malcolm.parsons closed D45611: [analyzer] Fix filename in cross-file HTML report.
May 2 2018, 7:29 AM

May 1 2018

malcolm.parsons updated the diff for D45611: [analyzer] Fix filename in cross-file HTML report.

Add test

May 1 2018, 9:45 AM

Apr 22 2018

malcolm.parsons added a comment to D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.

I think spaces that will be removed should be counted - long long is 9.

Apr 22 2018, 12:11 AM · Restricted Project

Apr 16 2018

malcolm.parsons committed rL330112: Clean carriage returns from lib/ and include/. NFC..
Clean carriage returns from lib/ and include/. NFC.
Apr 16 2018, 1:34 AM
malcolm.parsons committed rC330112: Clean carriage returns from lib/ and include/. NFC..
Clean carriage returns from lib/ and include/. NFC.
Apr 16 2018, 1:34 AM
malcolm.parsons closed D45591: Clean carriage returns from lib/ and include/. NFC..
Apr 16 2018, 1:34 AM

Apr 13 2018

malcolm.parsons accepted D45591: Clean carriage returns from lib/ and include/. NFC..

LGTM. Can't commit right now - using phone.

Apr 13 2018, 11:18 AM
malcolm.parsons created D45611: [analyzer] Fix filename in cross-file HTML report.
Apr 13 2018, 1:41 AM

Apr 12 2018

malcolm.parsons committed rL329914: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency.
Diagnose cases of "return x" that should be "return std::move(x)" for efficiency
Apr 12 2018, 7:52 AM
malcolm.parsons committed rC329914: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency.
Diagnose cases of "return x" that should be "return std::move(x)" for efficiency
Apr 12 2018, 7:51 AM
malcolm.parsons closed D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency.
Apr 12 2018, 7:51 AM · Restricted Project
malcolm.parsons added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Third commit introducing linking errors.
Did no buildbot catch those?

Apr 12 2018, 4:34 AM

Apr 11 2018

malcolm.parsons committed rCTE329813: [clang-apply-replacements] Convert tooling::Replacements to tooling….
[clang-apply-replacements] Convert tooling::Replacements to tooling…
Apr 11 2018, 7:42 AM
malcolm.parsons committed rL329813: [clang-apply-replacements] Convert tooling::Replacements to tooling….
[clang-apply-replacements] Convert tooling::Replacements to tooling…
Apr 11 2018, 7:42 AM
malcolm.parsons closed D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
Apr 11 2018, 7:42 AM

Apr 10 2018

malcolm.parsons added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Ok, I understand the problem.
Previously, during the deduplication step, replacements per file where sorted and it is not the case anymore.
That means now, clang-apply-replacement is highly dependant of reading file order during error reporting.
I mainly see 2 options (I can miss others), rewrite the test (e.g merging yaml file together) or sort the replacements per file to fix the order of application.

Can I ask you what solution you prefer?

Apr 10 2018, 4:45 AM

Apr 9 2018

malcolm.parsons accepted D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'.

LGTM!

Apr 9 2018, 2:28 AM · Restricted Project
malcolm.parsons added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

I suspect some undefined order when applying replacements as directly dependent on which order OS reads file1.yaml, file2.yamland file3.yaml.

Apr 9 2018, 1:50 AM

Apr 7 2018

malcolm.parsons added a comment to D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'.

Please add to release notes.

Apr 7 2018, 2:29 PM · Restricted Project

Apr 5 2018

malcolm.parsons added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..

Can I help in some way to close this PR?

Apr 5 2018, 7:44 AM

Mar 28 2018

malcolm.parsons added a comment to D44948: Add diagnostic -Waggregate-ctors, "aggregate type has user-declared constructors".

If no real code triggers this diagnostic, ...

Mar 28 2018, 7:28 AM · Restricted Project

Mar 22 2018

malcolm.parsons added a comment to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.

Please add a test where the parent class is in a differently named namespace.

Mar 22 2018, 1:08 PM · Restricted Project

Mar 13 2018

malcolm.parsons added a comment to D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check..

Do you know why the CSA checker is still in alpha?

Mar 13 2018, 7:54 AM

Mar 12 2018

malcolm.parsons added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 12 2018, 2:30 AM · Restricted Project

Mar 10 2018

malcolm.parsons added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 10 2018, 6:22 AM · Restricted Project

Mar 9 2018

malcolm.parsons added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 9 2018, 10:56 AM · Restricted Project
malcolm.parsons added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 9 2018, 9:24 AM · Restricted Project

Feb 20 2018

malcolm.parsons added a comment to D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon..

Is there a way to make clang-apply-replacements smarter rather than forcing every check to jump through hoops? I'm worried that if we have to fix individual checks we'll just run into the same bug later.

Feb 20 2018, 12:12 PM · Restricted Project

Jan 30 2018

malcolm.parsons added a comment to D42682: [clang-tidy] Add io-functions-misused checker.

Why only the wide versions?
Even narrow versions return an int so that you can check for EOF.

Jan 30 2018, 3:30 AM · Restricted Project

Jan 24 2018

malcolm.parsons committed rL323318: Fix typos of occurred and occurrence.
Fix typos of occurred and occurrence
Jan 24 2018, 2:37 AM
malcolm.parsons committed rC323316: Fix typos of occurred and occurrence.
Fix typos of occurred and occurrence
Jan 24 2018, 2:28 AM
malcolm.parsons committed rL323316: Fix typos of occurred and occurrence.
Fix typos of occurred and occurrence
Jan 24 2018, 2:28 AM

Jan 23 2018

malcolm.parsons committed rL323227: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if….
[clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if…
Jan 23 2018, 9:17 AM
malcolm.parsons committed rCTE323227: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if….
[clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if…
Jan 23 2018, 9:17 AM
malcolm.parsons closed D42426: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if using C++2a.
Jan 23 2018, 9:17 AM
malcolm.parsons created D42426: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if using C++2a.
Jan 23 2018, 8:44 AM
malcolm.parsons committed rCTE323208: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using….
[clang-tidy] Handle bitfields in modernize-use-default-member-init if using…
Jan 23 2018, 7:36 AM
malcolm.parsons committed rL323208: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using….
[clang-tidy] Handle bitfields in modernize-use-default-member-init if using…
Jan 23 2018, 7:36 AM
malcolm.parsons closed D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a.
Jan 23 2018, 7:36 AM
malcolm.parsons added inline comments to D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a.
Jan 23 2018, 7:25 AM
malcolm.parsons updated the diff for D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a.

Use ternary operator.

Jan 23 2018, 7:25 AM
malcolm.parsons created D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a.
Jan 23 2018, 3:40 AM

Dec 21 2017

malcolm.parsons added a comment to D41456: [clang-tidy] readability-else-after-return: also diagnose noreturn function calls..

This check could also handle else after goto.

Dec 21 2017, 1:09 AM · Restricted Project

Dec 11 2017

malcolm.parsons committed rC320396: [Sema] Fix crash in unused-lambda-capture warning for VLAs.
[Sema] Fix crash in unused-lambda-capture warning for VLAs
Dec 11 2017, 10:01 AM
malcolm.parsons committed rL320396: [Sema] Fix crash in unused-lambda-capture warning for VLAs.
[Sema] Fix crash in unused-lambda-capture warning for VLAs
Dec 11 2017, 10:01 AM
malcolm.parsons closed D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs by committing rL320396: [Sema] Fix crash in unused-lambda-capture warning for VLAs.
Dec 11 2017, 10:01 AM
malcolm.parsons added inline comments to D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs.
Dec 11 2017, 10:00 AM
malcolm.parsons updated the diff for D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs.

Add assert.

Dec 11 2017, 9:59 AM

Dec 8 2017

malcolm.parsons created D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs.
Dec 8 2017, 8:55 AM

Dec 5 2017

malcolm.parsons added a comment to D36672: [clang-tidy] readability-non-const-parameter: fixit on all function declarations.

Fixed by rL319021?

Dec 5 2017, 1:48 AM · Restricted Project

Nov 28 2017

malcolm.parsons committed rL319174: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw.
[clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw
Nov 28 2017, 6:58 AM
malcolm.parsons committed rCTE319174: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw.
[clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw
Nov 28 2017, 6:58 AM
malcolm.parsons closed D40505: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw by committing rCTE319174: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw.
Nov 28 2017, 6:58 AM
malcolm.parsons updated the diff for D40505: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw.

clang-format

Nov 28 2017, 6:56 AM

Nov 27 2017

malcolm.parsons added a comment to D40505: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw.

How about also matching on call to functions with no-return attribute?

Nov 27 2017, 10:15 AM
malcolm.parsons created D40505: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw.
Nov 27 2017, 9:43 AM

Nov 26 2017

malcolm.parsons added a comment to D38171: [clang-tidy] Implement clang-tidy check aliases.

The only place I can think of, where -checks=* is useful is in combination with -list-checks, where the presence of clang-diagnostic- entries would be desired anyway.

Nov 26 2017, 12:14 PM

Nov 24 2017

malcolm.parsons added a comment to D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.

I have 1000s of warnings from this check.

Nov 24 2017, 2:48 PM
malcolm.parsons added a comment to D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.

I'd like an AllowDeletedCopyFunctions option that allows move and destructor functions to be missing when copying is disabled.

struct A {
  A(const A&) = delete;
  A& operator=(const A&) = delete;
}

Doesn't AllowMissingMoveFunctions do almost that? If not, it should -- that code produces a class that does not declare a move constructor or move assignment operator per [class.copy]p8 and [class.copy.assign]p4, so that would be a "missing move function". Granted, that doesn't handle the dtor case, but I think an AllowMissingDestructor option might be overkill -- the destructor isn't missing, it's implicitly declared as defaulted in that case, but if the C++ Core Guidelines folks want it spelled out explicitly then, it might be worth the option. Have they weighed in on your exception?

Nov 24 2017, 9:35 AM
malcolm.parsons added a comment to D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check.

I'd like an AllowDeletedCopyFunctions option that allows move and destructor functions to be missing when copying is disabled.

Nov 24 2017, 5:38 AM

Nov 22 2017

malcolm.parsons committed rL318827: [Docs] Update list of languages clang-format can format.
[Docs] Update list of languages clang-format can format
Nov 22 2017, 2:48 AM

Oct 19 2017

malcolm.parsons added a reviewer for D39105: Patch bug 27628 (clang-tidy should exit with a failure code when there are errors): alexfh.
Oct 19 2017, 2:02 PM

Oct 4 2017

malcolm.parsons added inline comments to D38399: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise.
Oct 4 2017, 8:42 AM

Sep 27 2017

malcolm.parsons updated subscribers of D38284: [clang-tidy] Fix google-readability-namespace-comments handling of C++17 nested namespaces.
Sep 27 2017, 1:11 AM · Restricted Project

Sep 26 2017

malcolm.parsons added inline comments to D38179: [clang-tidy] Handle unions in modernize-use-equals-default check.
Sep 26 2017, 3:30 PM

Sep 22 2017

malcolm.parsons created D38179: [clang-tidy] Handle unions in modernize-use-equals-default check.
Sep 22 2017, 8:48 AM

Sep 21 2017

malcolm.parsons updated the summary of D38123: [driver] [cl] Add/fix c++17/c++latest.
Sep 21 2017, 3:04 AM

Aug 3 2017

malcolm.parsons added inline comments to D36016: [clang-tidy] Support initializer-list constructor cases in modernize-make-unique..
Aug 3 2017, 8:01 AM

Aug 1 2017

malcolm.parsons committed rL309668: [clang-tidy] Handle anonymous structs/unions in member init checks..
[clang-tidy] Handle anonymous structs/unions in member init checks.
Aug 1 2017, 2:55 AM
malcolm.parsons committed rL309667: [ASTMatchers] Allow forField to match indirect fields..
[ASTMatchers] Allow forField to match indirect fields.
Aug 1 2017, 2:55 AM

Jun 26 2017

malcolm.parsons updated subscribers of D34624: extra test modifications for D34158.
Jun 26 2017, 8:18 AM · Restricted Project

Jun 20 2017

malcolm.parsons updated subscribers of D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output.
Jun 20 2017, 1:35 PM · Restricted Project
malcolm.parsons updated subscribers of D34415: Allow passing a regex for headers to exclude from clang-tidy.
Jun 20 2017, 1:34 PM

Jun 15 2017

malcolm.parsons added a comment to D33722: [clang-tidy] Add checker for undelegated copy of base classes.

This check is similar to misc-move-constructor-init; could it have a similar name please.

Jun 15 2017, 7:48 AM · Restricted Project
malcolm.parsons added a comment to D34238: clang-format: Do not binpack initialization lists.

Some people write

auto x = std::map<int, std::string>{
    { 0, "foo fjakfjaklf kljj" },
    { 1, "bar fjakfjaklf kljj" },
    { 2, "stuff fjakfjaklf kljj" },
};
Jun 15 2017, 7:33 AM

Jun 14 2017

malcolm.parsons accepted D34202: [clang-tidy] readability-function-size: fix nesting level calculation.
Jun 14 2017, 9:37 AM · Restricted Project