Page MenuHomePhabricator
People malcolm.parsons

malcolm.parsons (Malcolm Parsons)
User

Projects

User does not belong to any projects.

User Details

User Since
May 2 2013, 1:42 AM (517 w, 2 d)

Recent Activity
View All

Dec 9 2021

malcolm.parsons added a comment to D114995: clang-tidy: improve the 'modernize-use-default-member-init'.
In D114995#3180475, @aaron.ballman wrote:

was there a reason we didn't cover that case originally or was it an oversight/left for future work?

Dec 9 2021, 9:51 AM · Restricted Project

May 12 2021

malcolm.parsons committed rG5389a05836e7: [docs] Fix documentation for bugprone-dangling-handle (authored by malcolm.parsons).
[docs] Fix documentation for bugprone-dangling-handle
May 12 2021, 9:20 AM
malcolm.parsons closed D102313: [docs] Fix documentation for bugprone-dangling-handle.
May 12 2021, 9:20 AM · Restricted Project

May 11 2021

malcolm.parsons requested review of D102313: [docs] Fix documentation for bugprone-dangling-handle.
May 11 2021, 11:59 PM · Restricted Project

Dec 20 2020

malcolm.parsons committed rG35f2c3a8b41f: [clang-tidy] cppcoreguidelines-pro-type-member-init: suppress warning for… (authored by cwarner-8702).
[clang-tidy] cppcoreguidelines-pro-type-member-init: suppress warning for…
Dec 20 2020, 3:25 AM
malcolm.parsons closed D93333: [clang-tidy] ppcoreguidelines-pro-type-member-init: suppress warning for default member funcs.
Dec 20 2020, 3:24 AM · Restricted Project, Restricted Project

Dec 17 2020

malcolm.parsons accepted D93333: [clang-tidy] ppcoreguidelines-pro-type-member-init: suppress warning for default member funcs.

LGTM

Dec 17 2020, 2:25 PM · Restricted Project, Restricted Project

Feb 19 2020

malcolm.parsons accepted D74800: [clang-tidy] fix readability-redundant-member-init auto-fix of Function-try-block.

LGTM with some nits.

Feb 19 2020, 2:13 AM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2020

malcolm.parsons added a comment to D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init.
In D72630#1823525, @hans wrote:

It seems that while this commit got pushed to GitHub, it's not actually part of master or any other branches.

Jan 24 2020, 9:00 AM · Restricted Project

Jan 14 2020

malcolm.parsons committed rG9738c757bd9b: [clang-tidy] Match InitListExpr in modernize-use-default-member-init (authored by malcolm.parsons).
[clang-tidy] Match InitListExpr in modernize-use-default-member-init
Jan 14 2020, 7:34 AM
malcolm.parsons closed D72691: [clang-tidy] Match InitListExpr in modernize-use-default-member-init.
Jan 14 2020, 7:34 AM · Restricted Project
malcolm.parsons created D72691: [clang-tidy] Match InitListExpr in modernize-use-default-member-init.
Jan 14 2020, 4:00 AM · Restricted Project
malcolm.parsons committed rG45924eb46716: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init (authored by malcolm.parsons).
[clang-tidy] Ignore implicit casts in modernize-use-default-member-init
Jan 14 2020, 2:13 AM
malcolm.parsons closed D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init.
Jan 14 2020, 2:13 AM · Restricted Project

Jan 13 2020

malcolm.parsons added inline comments to D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init.
Jan 13 2020, 2:02 PM · Restricted Project
malcolm.parsons updated the summary of D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init.
Jan 13 2020, 2:02 PM · Restricted Project
malcolm.parsons resigned from D64585: [OpenMP] With nested parallelism, threadprivate variables become shared on outer parallel when appearing in inner parallel copyin clause.
Jan 13 2020, 9:19 AM · Restricted Project, Restricted Project
malcolm.parsons resigned from D50763: [Parser] Refactor and fix bugs in late-parsing.
Jan 13 2020, 9:19 AM · Restricted Project
malcolm.parsons created D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init.
Jan 13 2020, 9:18 AM · Restricted Project

Dec 31 2019

malcolm.parsons added inline comments to D36051: Move from a long list of checkers to tables.
Dec 31 2019, 1:50 AM · Restricted Project

Dec 24 2019

malcolm.parsons added a comment to D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364.

Does Clang support C++20's range-based for statements with initializer?

Dec 24 2019, 12:35 AM · Restricted Project, Restricted Project

Nov 14 2019

malcolm.parsons added a reviewer for D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons: alexfh.

Should clang::format::cleanupAroundReplacements() handle this instead?

Nov 14 2019, 5:20 AM · Restricted Project

Oct 29 2019

malcolm.parsons added a comment to D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra.

I like that this check warns about copy constructors that don't copy.
The warning can be suppressed with a NOLINT comment if not copying is intentional.

Oct 29 2019, 4:14 AM · Restricted Project, Restricted Project

Sep 3 2019

malcolm.parsons committed rL370797: Request commit access for malcolm.parsons.
Request commit access for malcolm.parsons
Sep 3 2019, 10:53 AM

Feb 17 2019

malcolm.parsons added a comment to D57087: [clang-tidy] add OverrideMacro to modernize-use-override check.

Some Clang warnings use PP.getLastMacroWithSpelling() to determine the user's macro automatically.

Feb 17 2019, 7:11 AM · Restricted Project, Restricted Project

Feb 8 2019

malcolm.parsons committed rG297b6a2b6ea6: [clang-tidy] Don't use assignment for value-initialized enums (authored by malcolm.parsons).
[clang-tidy] Don't use assignment for value-initialized enums
Feb 8 2019, 11:45 AM
malcolm.parsons committed rL353554: [clang-tidy] Don't use assignment for value-initialized enums.
[clang-tidy] Don't use assignment for value-initialized enums
Feb 8 2019, 11:44 AM
malcolm.parsons committed rCTE353554: [clang-tidy] Don't use assignment for value-initialized enums.
[clang-tidy] Don't use assignment for value-initialized enums
Feb 8 2019, 11:44 AM
malcolm.parsons closed D57852: [clang-tidy] Don't use assignment for value-initialized enums.
Feb 8 2019, 11:44 AM · Restricted Project

Feb 7 2019

malcolm.parsons added a comment to D57852: [clang-tidy] Don't use assignment for value-initialized enums.
In D57852#1388526, @JonasToth wrote:

How are the semantics for enum class in this case?

Feb 7 2019, 6:48 AM · Restricted Project

Feb 6 2019

malcolm.parsons created D57852: [clang-tidy] Don't use assignment for value-initialized enums.
Feb 6 2019, 3:00 PM · Restricted Project

Feb 4 2019

malcolm.parsons committed rGa7c957fd8149: [clang-tidy] Handle unions with existing default-member-init (authored by malcolm.parsons).
[clang-tidy] Handle unions with existing default-member-init
Feb 4 2019, 1:11 PM
malcolm.parsons committed rL353092: [clang-tidy] Handle unions with existing default-member-init.
[clang-tidy] Handle unions with existing default-member-init
Feb 4 2019, 1:09 PM
malcolm.parsons committed rCTE353092: [clang-tidy] Handle unions with existing default-member-init.
[clang-tidy] Handle unions with existing default-member-init
Feb 4 2019, 1:09 PM
malcolm.parsons closed D57665: [clang-tidy] Handle unions with existing default-member-init.
Feb 4 2019, 1:09 PM · Restricted Project, Restricted Project

Feb 3 2019

malcolm.parsons created D57665: [clang-tidy] Handle unions with existing default-member-init.
Feb 3 2019, 1:47 PM · Restricted Project, Restricted Project

Nov 27 2018

malcolm.parsons committed rCTE347671: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability….
[clang-tidy] Ignore bool -> single bit bitfield conversion in readability…
Nov 27 2018, 8:26 AM
malcolm.parsons committed rL347671: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability….
[clang-tidy] Ignore bool -> single bit bitfield conversion in readability…
Nov 27 2018, 8:26 AM
malcolm.parsons closed D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion.
Nov 27 2018, 8:26 AM
malcolm.parsons added inline comments to D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion.
Nov 27 2018, 6:44 AM
malcolm.parsons created D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion.
Nov 27 2018, 2:53 AM

Oct 17 2018

malcolm.parsons accepted D53377: [clang-tidy] Ignore a case where the fix of make_unique check introduces side effect..

LGTM.

Oct 17 2018, 11:25 AM

Oct 12 2018

malcolm.parsons resigned from D53206: Allow padding checker to traverse simple class hierarchies.
Oct 12 2018, 2:02 PM · Restricted Project

Sep 10 2018

malcolm.parsons retitled D51297: [docs] Provide pointers to known editor plugins and extensions from [docs] Create a guide for Vim users on how to setup Clangd to [docs] Create a guide for Vim users on how to set up Clangd.
Sep 10 2018, 7:31 AM · Restricted Project

May 23 2018

malcolm.parsons added inline comments to D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type.
May 23 2018, 12:51 PM · Restricted Project

May 22 2018

malcolm.parsons added inline comments to D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type.
May 22 2018, 11:17 AM · Restricted Project

May 2 2018

malcolm.parsons committed rL331361: [analyzer] Fix filename in cross-file HTML report.
[analyzer] Fix filename in cross-file HTML report
May 2 2018, 7:30 AM
malcolm.parsons committed rC331361: [analyzer] Fix filename in cross-file HTML report.
[analyzer] Fix filename in cross-file HTML report
May 2 2018, 7:29 AM
malcolm.parsons closed D45611: [analyzer] Fix filename in cross-file HTML report.
May 2 2018, 7:29 AM

May 1 2018

malcolm.parsons updated the diff for D45611: [analyzer] Fix filename in cross-file HTML report.

Add test

May 1 2018, 9:45 AM

Apr 22 2018

malcolm.parsons added a comment to D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types.

I think spaces that will be removed should be counted - long long is 9.

Apr 22 2018, 12:11 AM · Restricted Project

Apr 16 2018

malcolm.parsons committed rL330112: Clean carriage returns from lib/ and include/. NFC..
Clean carriage returns from lib/ and include/. NFC.
Apr 16 2018, 1:34 AM
malcolm.parsons committed rC330112: Clean carriage returns from lib/ and include/. NFC..
Clean carriage returns from lib/ and include/. NFC.
Apr 16 2018, 1:34 AM
malcolm.parsons closed D45591: Clean carriage returns from lib/ and include/. NFC..
Apr 16 2018, 1:34 AM

Apr 13 2018

malcolm.parsons accepted D45591: Clean carriage returns from lib/ and include/. NFC..

LGTM. Can't commit right now - using phone.

Apr 13 2018, 11:18 AM
malcolm.parsons created D45611: [analyzer] Fix filename in cross-file HTML report.
Apr 13 2018, 1:41 AM

Apr 12 2018

malcolm.parsons committed rL329914: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency.
Diagnose cases of "return x" that should be "return std::move(x)" for efficiency
Apr 12 2018, 7:52 AM
malcolm.parsons committed rC329914: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency.
Diagnose cases of "return x" that should be "return std::move(x)" for efficiency
Apr 12 2018, 7:51 AM
malcolm.parsons closed D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency.
Apr 12 2018, 7:51 AM · Restricted Project
malcolm.parsons added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
In D43764#1065345, @lebedev.ri wrote:

Third commit introducing linking errors.
Did no buildbot catch those?

Apr 12 2018, 4:34 AM

Apr 11 2018

malcolm.parsons committed rCTE329813: [clang-apply-replacements] Convert tooling::Replacements to tooling….
[clang-apply-replacements] Convert tooling::Replacements to tooling…
Apr 11 2018, 7:42 AM
malcolm.parsons committed rL329813: [clang-apply-replacements] Convert tooling::Replacements to tooling….
[clang-apply-replacements] Convert tooling::Replacements to tooling…
Apr 11 2018, 7:42 AM
malcolm.parsons closed D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
Apr 11 2018, 7:42 AM

Apr 10 2018

malcolm.parsons added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
In D43764#1062748, @jdemeule wrote:

Ok, I understand the problem.
Previously, during the deduplication step, replacements per file where sorted and it is not the case anymore.
That means now, clang-apply-replacement is highly dependant of reading file order during error reporting.
I mainly see 2 options (I can miss others), rewrite the test (e.g merging yaml file together) or sort the replacements per file to fix the order of application.

Can I ask you what solution you prefer?

Apr 10 2018, 4:45 AM

Apr 9 2018

malcolm.parsons accepted D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'.

LGTM!

Apr 9 2018, 2:28 AM · Restricted Project
malcolm.parsons added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
In D43764#1061042, @jdemeule wrote:

I suspect some undefined order when applying replacements as directly dependent on which order OS reads file1.yaml, file2.yamland file3.yaml.

Apr 9 2018, 1:50 AM

Apr 7 2018

malcolm.parsons added a comment to D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'.

Please add to release notes.

Apr 7 2018, 2:29 PM · Restricted Project

Apr 5 2018

malcolm.parsons added a comment to D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting..
In D43764#1058120, @jdemeule wrote:

Can I help in some way to close this PR?

Apr 5 2018, 7:44 AM

Mar 28 2018

malcolm.parsons added a comment to D44948: Add diagnostic -Waggregate-ctors, "aggregate type has user-declared constructors".

If no real code triggers this diagnostic, ...

Mar 28 2018, 7:28 AM · Restricted Project

Mar 22 2018

malcolm.parsons added a comment to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.

Please add a test where the parent class is in a differently named namespace.

Mar 22 2018, 1:08 PM · Restricted Project

Mar 13 2018

malcolm.parsons added a comment to D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check..
In D16008#1035789, @aaron.ballman wrote:

Do you know why the CSA checker is still in alpha?

Mar 13 2018, 7:54 AM

Mar 12 2018

malcolm.parsons added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 12 2018, 2:30 AM · Restricted Project

Mar 10 2018

malcolm.parsons added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 10 2018, 6:22 AM · Restricted Project

Mar 9 2018

malcolm.parsons added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 9 2018, 10:56 AM · Restricted Project
malcolm.parsons added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 9 2018, 9:24 AM · Restricted Project

Feb 20 2018

malcolm.parsons added a comment to D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon..
In D43500#1013497, @aaron.ballman wrote:

Is there a way to make clang-apply-replacements smarter rather than forcing every check to jump through hoops? I'm worried that if we have to fix individual checks we'll just run into the same bug later.

Feb 20 2018, 12:12 PM · Restricted Project

Jan 30 2018

malcolm.parsons added a comment to D42682: [clang-tidy] Add io-functions-misused checker.

Why only the wide versions?
Even narrow versions return an int so that you can check for EOF.

Jan 30 2018, 3:30 AM · Restricted Project

Jan 24 2018

malcolm.parsons committed rL323318: Fix typos of occurred and occurrence.
Fix typos of occurred and occurrence
Jan 24 2018, 2:37 AM
malcolm.parsons committed rC323316: Fix typos of occurred and occurrence.
Fix typos of occurred and occurrence
Jan 24 2018, 2:28 AM
malcolm.parsons committed rL323316: Fix typos of occurred and occurrence.
Fix typos of occurred and occurrence
Jan 24 2018, 2:28 AM

Jan 23 2018

malcolm.parsons committed rL323227: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if….
[clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if…
Jan 23 2018, 9:17 AM
malcolm.parsons committed rCTE323227: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if….
[clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if…
Jan 23 2018, 9:17 AM
malcolm.parsons closed D42426: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if using C++2a.
Jan 23 2018, 9:17 AM
malcolm.parsons created D42426: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init if using C++2a.
Jan 23 2018, 8:44 AM
malcolm.parsons committed rCTE323208: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using….
[clang-tidy] Handle bitfields in modernize-use-default-member-init if using…
Jan 23 2018, 7:36 AM
malcolm.parsons committed rL323208: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using….
[clang-tidy] Handle bitfields in modernize-use-default-member-init if using…
Jan 23 2018, 7:36 AM
malcolm.parsons closed D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a.
Jan 23 2018, 7:36 AM
malcolm.parsons added inline comments to D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a.
Jan 23 2018, 7:25 AM
malcolm.parsons updated the diff for D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a.

Use ternary operator.

Jan 23 2018, 7:25 AM
malcolm.parsons created D42413: [clang-tidy] Handle bitfields in modernize-use-default-member-init if using C++2a.
Jan 23 2018, 3:40 AM

Dec 21 2017

malcolm.parsons added a comment to D41456: [clang-tidy] readability-else-after-return: also diagnose noreturn function calls..

This check could also handle else after goto.

Dec 21 2017, 1:09 AM · Restricted Project, Restricted Project

Dec 11 2017

malcolm.parsons committed rC320396: [Sema] Fix crash in unused-lambda-capture warning for VLAs.
[Sema] Fix crash in unused-lambda-capture warning for VLAs
Dec 11 2017, 10:01 AM
malcolm.parsons committed rL320396: [Sema] Fix crash in unused-lambda-capture warning for VLAs.
[Sema] Fix crash in unused-lambda-capture warning for VLAs
Dec 11 2017, 10:01 AM
malcolm.parsons closed D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs by committing rL320396: [Sema] Fix crash in unused-lambda-capture warning for VLAs.
Dec 11 2017, 10:01 AM
malcolm.parsons added inline comments to D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs.
Dec 11 2017, 10:00 AM
malcolm.parsons updated the diff for D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs.

Add assert.

Dec 11 2017, 9:59 AM

Dec 8 2017

malcolm.parsons created D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs.
Dec 8 2017, 8:55 AM

Dec 5 2017

malcolm.parsons added a comment to D36672: [clang-tidy] readability-non-const-parameter: fixit on all function declarations.

Fixed by rL319021?

Dec 5 2017, 1:48 AM · Restricted Project

Nov 28 2017

malcolm.parsons committed rL319174: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw.
[clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw
Nov 28 2017, 6:58 AM
malcolm.parsons committed rCTE319174: [clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw.
[clang-tidy] Ignore ExprWithCleanups when looking for else-after-throw
Nov 28 2017, 6:58 AM