This is an archive of the discontinued LLVM Phabricator instance.

Differential D52986

[analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__
ClosedPublic

Authored by Szelethus on Oct 8 2018, 7:57 AM.

Details

Reviewers
george.karpenkov
xazax.hun
NoQ
rnkovacs
baloghadamsoftware
whisperity
Commits
rG8de606201089: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__
rL347888: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__
rC347888: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__
Summary

Thanks to @donat.nagy for spotting this!

Diff Detail

Event Timeline

Szelethus created this revision.Oct 8 2018, 7:57 AM
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin and 2 others. · View Herald TranscriptOct 8 2018, 7:57 AM
Szelethus added a parent revision: D52795: [analyzer][PlistMacroExpansion] Part 3.: Macro arguments are expanded.Oct 8 2018, 7:58 AM
Szelethus added a child revision: D52988: [analyzer][PlistMacroExpansion] Part 5.: Support for # and ##.Oct 8 2018, 1:15 PM
Szelethus updated this revision to Diff 169869.Oct 16 2018, 11:31 AM

Rebased to part 3.

Herald added a subscriber: dkrupp. · View Herald TranscriptOct 16 2018, 11:31 AM
whisperity accepted this revision.Oct 16 2018, 11:04 PM
This revision is now accepted and ready to land.Oct 16 2018, 11:04 PM
NoQ accepted this revision.Nov 1 2018, 7:27 PM

haha!

:D

xazax.hun accepted this revision.Nov 2 2018, 5:01 AM

One question otherwise looks good.

lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
884

Is it possible to undef __VA_ARGS__? If so, can this cause problems? Should we use findDirectiveAtLoc instead?

Szelethus updated this revision to Diff 175718.EditedNov 28 2018, 10:08 AM
  • Fixed a crash where no arguments (not empty arguments) were supplied to __VA_ARGS__.
  • Rebased to master.
Herald added a subscriber: gamesh411. · View Herald TranscriptNov 28 2018, 10:08 AM
Szelethus marked 2 inline comments as done.Nov 28 2018, 10:16 AM
Szelethus added inline comments.
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
884

Luckily, no :)

But, even if you could, we're not looking for a MacroInfo (through MacroDirective), but rather an IdentifierInfo, and those won't disappear even if you undef a macro.

Szelethus marked 2 inline comments as done.Nov 28 2018, 10:42 AM
Szelethus added inline comments.
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
884

Hmmm, simply acquiring the range of tokens __VA_ARGS__ is defined to in the expansion context would be neat, but it doesn't seem to be possible. It seems like __VA_ARGS__ just doesn't have a MacroDirective.

In fact, if you CTRL+F "variadic" on Preprocessor's doxygen page, you get basically nothing (if you look for __VA_ARGS__, you get literally nothing). Sooooo working with the most primitive tools available is the best I can do here, I'm afraid :/

Closed by commit rC347888: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__ (authored by Szelethus). · Explain WhyNov 29 2018, 9:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
StaticAnalyzer/
Core/
15 lines
test/
Analysis/
Inputs/
expected-plists/
70 lines
3 lines

Diff 169869

lib/StaticAnalyzer/Core/PlistDiagnostics.cpp

Show First 20 Lines • Show All 867 Lines • ▼ Show 20 Linesstatic MacroNameAndArgs getMacroNameAndArgs(SourceLocation ExpanLoc,
MacroArgMap Args; MacroArgMap Args;
// When the macro's argument is a function call, like // When the macro's argument is a function call, like
// CALL_FN(someFunctionName(param1, param2)) // CALL_FN(someFunctionName(param1, param2))
// we will find tok::l_paren, tok::r_paren, and tok::comma that do not divide // we will find tok::l_paren, tok::r_paren, and tok::comma that do not divide
// actual macro arguments, or do not represent the macro argument's closing // actual macro arguments, or do not represent the macro argument's closing
// parantheses, so we'll count how many parantheses aren't closed yet. // parantheses, so we'll count how many parantheses aren't closed yet.
// If ParanthesesDepth
// * = 0, then there are no more arguments to lex.
// * = 1, then if we find a tok::comma, we can start lexing the next arg.
// * > 1, then tok::comma is a part of the current arg.
int ParanthesesDepth = 1; int ParanthesesDepth = 1;
// If we encounter __VA_ARGS__, we will lex until the closing tok::r_paren,
// even if we lex a tok::comma and ParanthesesDepth == 1.
const IdentifierInfo *__VA_ARGS__II = PP.getIdentifierInfo("__VA_ARGS__");
xazax.hunUnsubmitted
Done
ReplyInline Actions

Is it possible to undef __VA_ARGS__? If so, can this cause problems? Should we use findDirectiveAtLoc instead?

xazax.hun: Is it possible to undef `__VA_ARGS__`? If so, can this cause problems? Should we use…
SzelethusAuthorUnsubmitted
Done
ReplyInline Actions

Luckily, no :)

But, even if you could, we're not looking for a MacroInfo (through MacroDirective), but rather an IdentifierInfo, and those won't disappear even if you undef a macro.

Szelethus: Luckily, no :) But, even if you could, we're not looking for a `MacroInfo` (through…
SzelethusAuthorUnsubmitted
Done
ReplyInline Actions

Hmmm, simply acquiring the range of tokens __VA_ARGS__ is defined to in the expansion context would be neat, but it doesn't seem to be possible. It seems like __VA_ARGS__ just doesn't have a MacroDirective.

In fact, if you CTRL+F "variadic" on Preprocessor's doxygen page, you get basically nothing (if you look for __VA_ARGS__, you get literally nothing). Sooooo working with the most primitive tools available is the best I can do here, I'm afraid :/

Szelethus: Hmmm, simply acquiring the range of tokens `__VA_ARGS__` is defined to in the expansion context…
for (const IdentifierInfo *UnexpArgII : MacroArgs) { for (const IdentifierInfo *UnexpArgII : MacroArgs) {
MacroArgMap::mapped_type ExpandedArgTokens; MacroArgMap::mapped_type ExpandedArgTokens;
// Lex the first token of the next macro parameter. // Lex the first token of the next macro parameter.
RawLexer.LexFromRawLexer(TheTok); RawLexer.LexFromRawLexer(TheTok);
while (TheTok.isNot(tok::comma) || ParanthesesDepth != 1) { while (!(ParanthesesDepth == 1 &&
(UnexpArgII == __VA_ARGS__II ? false : TheTok.is(tok::comma)))) {
assert(TheTok.isNot(tok::eof) && assert(TheTok.isNot(tok::eof) &&
"EOF encountered while looking for expanded macro args!"); "EOF encountered while looking for expanded macro args!");
if (TheTok.is(tok::l_paren)) if (TheTok.is(tok::l_paren))
++ParanthesesDepth; ++ParanthesesDepth;
if (TheTok.is(tok::r_paren)) if (TheTok.is(tok::r_paren))
--ParanthesesDepth; --ParanthesesDepth;
if (ParanthesesDepth == 0) if (ParanthesesDepth == 0)
break; break;
if (TheTok.is(tok::raw_identifier)) if (TheTok.is(tok::raw_identifier))
PP.LookUpIdentifierInfo(TheTok); PP.LookUpIdentifierInfo(TheTok);
ExpandedArgTokens.push_back(TheTok); ExpandedArgTokens.push_back(TheTok);
RawLexer.LexFromRawLexer(TheTok); RawLexer.LexFromRawLexer(TheTok);
} }
Args.emplace(UnexpArgII, std::move(ExpandedArgTokens)); Args.emplace(UnexpArgII, std::move(ExpandedArgTokens));
} }
// TODO: The condition really should be TheTok.is(tok::r_paren), but variadic assert(TheTok.is(tok::r_paren) &&
// macro arguments are not handled yet.
assert(TheTok.isOneOf(tok::r_paren, tok::comma) &&
"Expanded macro argument acquisition failed! After the end of the loop" "Expanded macro argument acquisition failed! After the end of the loop"
" this token should be ')'!"); " this token should be ')'!");
return { MacroName, MI, Args }; return { MacroName, MI, Args };
} }
static MacroInfo::tokens_iterator getMatchingRParen( static MacroInfo::tokens_iterator getMatchingRParen(
MacroInfo::tokens_iterator It, MacroInfo::tokens_iterator It,
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines

test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist

Show First 20 Lines • Show All 3,582 Lines • ▼ Show 20 Lines <array>
<key>kind</key><string>macro_expansion</string> <key>kind</key><string>macro_expansion</string>
<key>location</key> <key>location</key>
<dict> <dict>
<key>line</key><integer>260</integer> <key>line</key><integer>260</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<key>name</key><string>VARIADIC_SET_TO_NULL</string> <key>name</key><string>VARIADIC_SET_TO_NULL</string>
<key>expansion</key><string>ptr = nullptr; variadicFunc( 1)</string> <key>expansion</key><string>ptr = nullptr; variadicFunc( 1, 5, &quot;haha!&quot;)</string>
</dict> </dict>
<dict> <dict>
<key>kind</key><string>event</string> <key>kind</key><string>event</string>
<key>location</key> <key>location</key>
<dict> <dict>
<key>line</key><integer>260</integer> <key>line</key><integer>260</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
▲ Show 20 Lines • Show All 115 Lines • ▼ Show 20 Lines <array>
<dict> <dict>
<key>kind</key><string>control</string> <key>kind</key><string>control</string>
<key>edges</key> <key>edges</key>
<array> <array>
<dict> <dict>
<key>start</key> <key>start</key>
<array> <array>
<dict> <dict>
<key>line</key><integer>277</integer> <key>line</key><integer>276</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>277</integer> <key>line</key><integer>276</integer>
<key>col</key><integer>5</integer> <key>col</key><integer>5</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
<key>end</key> <key>end</key>
<array> <array>
<dict> <dict>
<key>line</key><integer>278</integer> <key>line</key><integer>277</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>278</integer> <key>line</key><integer>277</integer>
<key>col</key><integer>30</integer> <key>col</key><integer>30</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
</dict> </dict>
</array> </array>
</dict> </dict>
<dict> <dict>
<key>kind</key><string>macro_expansion</string> <key>kind</key><string>macro_expansion</string>
<key>location</key> <key>location</key>
<dict> <dict>
<key>line</key><integer>278</integer> <key>line</key><integer>277</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<key>name</key><string>DECLARE_FUNC_AND_SET_TO_NULL</string> <key>name</key><string>DECLARE_FUNC_AND_SET_TO_NULL</string>
<key>expansion</key><string>void generated_##whatever(); ptr = nullptr;</string> <key>expansion</key><string>void generated_##whatever(); ptr = nullptr;</string>
</dict> </dict>
<dict> <dict>
<key>kind</key><string>event</string> <key>kind</key><string>event</string>
<key>location</key> <key>location</key>
<dict> <dict>
<key>line</key><integer>278</integer> <key>line</key><integer>277</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<key>ranges</key> <key>ranges</key>
<array> <array>
<array> <array>
<dict> <dict>
<key>line</key><integer>278</integer> <key>line</key><integer>277</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>278</integer> <key>line</key><integer>277</integer>
<key>col</key><integer>45</integer> <key>col</key><integer>45</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
</array> </array>
<key>depth</key><integer>0</integer> <key>depth</key><integer>0</integer>
<key>extended_message</key> <key>extended_message</key>
<string>Null pointer value stored to &apos;ptr&apos;</string> <string>Null pointer value stored to &apos;ptr&apos;</string>
<key>message</key> <key>message</key>
<string>Null pointer value stored to &apos;ptr&apos;</string> <string>Null pointer value stored to &apos;ptr&apos;</string>
</dict> </dict>
<dict> <dict>
<key>kind</key><string>control</string> <key>kind</key><string>control</string>
<key>edges</key> <key>edges</key>
<array> <array>
<dict> <dict>
<key>start</key> <key>start</key>
<array> <array>
<dict> <dict>
<key>line</key><integer>279</integer> <key>line</key><integer>278</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>279</integer> <key>line</key><integer>278</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
<key>end</key> <key>end</key>
<array> <array>
<dict> <dict>
<key>line</key><integer>279</integer> <key>line</key><integer>278</integer>
<key>col</key><integer>8</integer> <key>col</key><integer>8</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>279</integer> <key>line</key><integer>278</integer>
<key>col</key><integer>8</integer> <key>col</key><integer>8</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
</dict> </dict>
</array> </array>
</dict> </dict>
<dict> <dict>
<key>kind</key><string>event</string> <key>kind</key><string>event</string>
<key>location</key> <key>location</key>
<dict> <dict>
<key>line</key><integer>279</integer> <key>line</key><integer>278</integer>
<key>col</key><integer>8</integer> <key>col</key><integer>8</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<key>ranges</key> <key>ranges</key>
<array> <array>
<array> <array>
<dict> <dict>
<key>line</key><integer>279</integer> <key>line</key><integer>278</integer>
<key>col</key><integer>4</integer> <key>col</key><integer>4</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>279</integer> <key>line</key><integer>278</integer>
<key>col</key><integer>6</integer> <key>col</key><integer>6</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
</array> </array>
<key>depth</key><integer>0</integer> <key>depth</key><integer>0</integer>
<key>extended_message</key> <key>extended_message</key>
<string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string> <string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string>
<key>message</key> <key>message</key>
<string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string> <string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string>
</dict> </dict>
</array> </array>
<key>description</key><string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string> <key>description</key><string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string>
<key>category</key><string>Logic error</string> <key>category</key><string>Logic error</string>
<key>type</key><string>Dereference of null pointer</string> <key>type</key><string>Dereference of null pointer</string>
<key>check_name</key><string>core.NullDereference</string> <key>check_name</key><string>core.NullDereference</string>
<!-- This hash is experimental and going to change! --> <!-- This hash is experimental and going to change! -->
<key>issue_hash_content_of_line_in_context</key><string>453ed8096f5394e74e16f965886e5623</string> <key>issue_hash_content_of_line_in_context</key><string>453ed8096f5394e74e16f965886e5623</string>
<key>issue_context_kind</key><string>function</string> <key>issue_context_kind</key><string>function</string>
<key>issue_context</key><string>hashHashOperatorTest</string> <key>issue_context</key><string>hashHashOperatorTest</string>
<key>issue_hash_function_offset</key><string>3</string> <key>issue_hash_function_offset</key><string>3</string>
<key>location</key> <key>location</key>
<dict> <dict>
<key>line</key><integer>279</integer> <key>line</key><integer>278</integer>
<key>col</key><integer>8</integer> <key>col</key><integer>8</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<key>ExecutedLines</key> <key>ExecutedLines</key>
<dict> <dict>
<key>0</key> <key>0</key>
<array> <array>
<integer>275</integer>
<integer>276</integer> <integer>276</integer>
<integer>277</integer> <integer>277</integer>
<integer>278</integer> <integer>278</integer>
<integer>279</integer>
</array> </array>
</dict> </dict>
</dict> </dict>
<dict> <dict>
<key>path</key> <key>path</key>
<array> <array>
<dict> <dict>
<key>kind</key><string>control</string> <key>kind</key><string>control</string>
<key>edges</key> <key>edges</key>
<array> <array>
<dict> <dict>
<key>start</key> <key>start</key>
<array> <array>
<dict> <dict>
<key>line</key><integer>291</integer> <key>line</key><integer>290</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>291</integer> <key>line</key><integer>290</integer>
<key>col</key><integer>5</integer> <key>col</key><integer>5</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
<key>end</key> <key>end</key>
<array> <array>
<dict> <dict>
<key>line</key><integer>292</integer> <key>line</key><integer>291</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>292</integer> <key>line</key><integer>291</integer>
<key>col</key><integer>11</integer> <key>col</key><integer>11</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
</dict> </dict>
</array> </array>
</dict> </dict>
<dict> <dict>
<key>kind</key><string>macro_expansion</string> <key>kind</key><string>macro_expansion</string>
<key>location</key> <key>location</key>
<dict> <dict>
<key>line</key><integer>292</integer> <key>line</key><integer>291</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<key>name</key><string>PRINT_STR</string> <key>name</key><string>PRINT_STR</string>
<key>expansion</key><string>print(#Hello); ptr = nullptr</string> <key>expansion</key><string>print(#Hello); ptr = nullptr</string>
</dict> </dict>
<dict> <dict>
<key>kind</key><string>event</string> <key>kind</key><string>event</string>
<key>location</key> <key>location</key>
<dict> <dict>
<key>line</key><integer>292</integer> <key>line</key><integer>291</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<key>ranges</key> <key>ranges</key>
<array> <array>
<array> <array>
<dict> <dict>
<key>line</key><integer>292</integer> <key>line</key><integer>291</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>292</integer> <key>line</key><integer>291</integer>
<key>col</key><integer>23</integer> <key>col</key><integer>23</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
</array> </array>
<key>depth</key><integer>0</integer> <key>depth</key><integer>0</integer>
<key>extended_message</key> <key>extended_message</key>
<string>Null pointer value stored to &apos;ptr&apos;</string> <string>Null pointer value stored to &apos;ptr&apos;</string>
<key>message</key> <key>message</key>
<string>Null pointer value stored to &apos;ptr&apos;</string> <string>Null pointer value stored to &apos;ptr&apos;</string>
</dict> </dict>
<dict> <dict>
<key>kind</key><string>control</string> <key>kind</key><string>control</string>
<key>edges</key> <key>edges</key>
<array> <array>
<dict> <dict>
<key>start</key> <key>start</key>
<array> <array>
<dict> <dict>
<key>line</key><integer>293</integer> <key>line</key><integer>292</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>293</integer> <key>line</key><integer>292</integer>
<key>col</key><integer>3</integer> <key>col</key><integer>3</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
<key>end</key> <key>end</key>
<array> <array>
<dict> <dict>
<key>line</key><integer>293</integer> <key>line</key><integer>292</integer>
<key>col</key><integer>8</integer> <key>col</key><integer>8</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>293</integer> <key>line</key><integer>292</integer>
<key>col</key><integer>8</integer> <key>col</key><integer>8</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
</dict> </dict>
</array> </array>
</dict> </dict>
<dict> <dict>
<key>kind</key><string>event</string> <key>kind</key><string>event</string>
<key>location</key> <key>location</key>
<dict> <dict>
<key>line</key><integer>293</integer> <key>line</key><integer>292</integer>
<key>col</key><integer>8</integer> <key>col</key><integer>8</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<key>ranges</key> <key>ranges</key>
<array> <array>
<array> <array>
<dict> <dict>
<key>line</key><integer>293</integer> <key>line</key><integer>292</integer>
<key>col</key><integer>4</integer> <key>col</key><integer>4</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<dict> <dict>
<key>line</key><integer>293</integer> <key>line</key><integer>292</integer>
<key>col</key><integer>6</integer> <key>col</key><integer>6</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
</array> </array>
</array> </array>
<key>depth</key><integer>0</integer> <key>depth</key><integer>0</integer>
<key>extended_message</key> <key>extended_message</key>
<string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string> <string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string>
<key>message</key> <key>message</key>
<string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string> <string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string>
</dict> </dict>
</array> </array>
<key>description</key><string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string> <key>description</key><string>Dereference of null pointer (loaded from variable &apos;ptr&apos;)</string>
<key>category</key><string>Logic error</string> <key>category</key><string>Logic error</string>
<key>type</key><string>Dereference of null pointer</string> <key>type</key><string>Dereference of null pointer</string>
<key>check_name</key><string>core.NullDereference</string> <key>check_name</key><string>core.NullDereference</string>
<!-- This hash is experimental and going to change! --> <!-- This hash is experimental and going to change! -->
<key>issue_hash_content_of_line_in_context</key><string>e6947ee72df70243a3b4c9e9eaed0888</string> <key>issue_hash_content_of_line_in_context</key><string>e6947ee72df70243a3b4c9e9eaed0888</string>
<key>issue_context_kind</key><string>function</string> <key>issue_context_kind</key><string>function</string>
<key>issue_context</key><string>hashOperatorTest</string> <key>issue_context</key><string>hashOperatorTest</string>
<key>issue_hash_function_offset</key><string>3</string> <key>issue_hash_function_offset</key><string>3</string>
<key>location</key> <key>location</key>
<dict> <dict>
<key>line</key><integer>293</integer> <key>line</key><integer>292</integer>
<key>col</key><integer>8</integer> <key>col</key><integer>8</integer>
<key>file</key><integer>0</integer> <key>file</key><integer>0</integer>
</dict> </dict>
<key>ExecutedLines</key> <key>ExecutedLines</key>
<dict> <dict>
<key>0</key> <key>0</key>
<array> <array>
<integer>289</integer>
<integer>290</integer> <integer>290</integer>
<integer>291</integer> <integer>291</integer>
<integer>292</integer> <integer>292</integer>
<integer>293</integer>
</array> </array>
</dict> </dict>
</dict> </dict>
</array> </array>
<key>files</key> <key>files</key>
<array> <array>
<string>/home/eumakri/Documents/2codechecker_dev_env/llvm/tools/clang/test/Analysis/plist-macros-with-expansion.cpp</string> <string>/home/eumakri/Documents/2codechecker_dev_env/llvm/tools/clang/test/Analysis/plist-macros-with-expansion.cpp</string>
</array> </array>
</dict> </dict>
</plist> </plist>

test/Analysis/plist-macros-with-expansion.cpp

Show First 20 Lines • Show All 255 Lines • ▼ Show 20 Lines#define VARIADIC_SET_TO_NULL(ptr, ...) \
variadicFunc(__VA_ARGS__) variadicFunc(__VA_ARGS__)
void variadicMacroArgumentTest() { void variadicMacroArgumentTest() {
int *ptr; int *ptr;
VARIADIC_SET_TO_NULL(ptr, 1, 5, "haha!"); VARIADIC_SET_TO_NULL(ptr, 1, 5, "haha!");
*ptr = 5; // expected-warning{{Dereference of null pointer}} *ptr = 5; // expected-warning{{Dereference of null pointer}}
} }
// TODO: Should correctly display the rest of the parameters.
// CHECK: <key>name</key><string>VARIADIC_SET_TO_NULL</string> // CHECK: <key>name</key><string>VARIADIC_SET_TO_NULL</string>
// CHECK: <key>expansion</key><string>ptr = nullptr; variadicFunc( 1)</string> // CHECK: <key>expansion</key><string>ptr = nullptr; variadicFunc( 1, 5, &quot;haha!&quot;)</string>
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Tests for # and ##. // Tests for # and ##.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#define DECLARE_FUNC_AND_SET_TO_NULL(funcName, ptr) \ #define DECLARE_FUNC_AND_SET_TO_NULL(funcName, ptr) \
void generated_##funcName(); \ void generated_##funcName(); \
ptr = nullptr; ptr = nullptr;
Show All 24 Lines