[llvm-nm] Print an explicit "no symbols" message when an object file has no symbols

[rupprecht]

Summary

GNU nm (and other nm implementations, such as "go tool nm") prints an explicit "no symbols" message when an object file has no symbols. Currently llvm-nm just doesn't print anything. Adding an explicit "no symbols" message will allow llvm-nm to be used in place of nm: some scripts and build processes use nm <file> | grep "no symbols" as a test to see if a file has no symbols. It will also be more familiar to anyone used to nm.

That said, the format implemented here is slightly different, in that it doesn't print the tool name in the message (which IMHO is not useful to include).

Demo:

$ for nm in nm bin/llvm-nm ; do echo "nm implementation: $nm"; $nm /tmp/foo{1,2}.o; echo; done
nm implementation: nm

/tmp/foo1.o:
nm: /tmp/foo1.o: no symbols

/tmp/foo2.o:
0000000000000000 T foo2

nm implementation: bin/llvm-nm

/tmp/foo1.o:
no symbols

/tmp/foo2.o:
0000000000000000 T foo2

[MaskRay]

Looks good, GNU and some BSD nm use: nm: /bin/cat: no symbols but the repeated command name and filename do not seem useful.

In POSIX.1-2017 specification of nm, "If no symbolic information is available for a valid input file, the nm utility shall report that fact, but not consider it an error condition."

[rupprecht]

In D52810#1254103, @MaskRay wrote:

Looks good, GNU and some BSD nm use: nm: /bin/cat: no symbols but the repeated command name and filename do not seem useful.

In POSIX.1-2017 specification of nm, "If no symbolic information is available for a valid input file, the nm utility shall report that fact, but not consider it an error condition."

Thanks for that pointer!

[sbc100]

I it seems that the printing of this error message only occurs with GNU nm if the object doesn't have a symbols table at all. Have no symbols in the table does not print the error message.

$ touch foo.c
$ gcc -c foo.c
$ nm foo.o  <- no error output here.
$ strip foo.o
$ nm foo.o
nm: foo.o: no symbols

[MaskRay]

In D52810#1817883, @sbc100 wrote:

I it seems that the printing of this error message only occurs with GNU nm if the object doesn't have a symbols table at all. Have no symbols in the table does not print the error message.

$ touch foo.c
$ gcc -c foo.c
$ nm foo.o  <- no error output here.
$ strip foo.o
$ nm foo.o
nm: foo.o: no symbols

Interesting (subtle) behavior...

@rupprecht Do we know what projects parse "no symbols" from llvm-nm output?

[rupprecht]

In D52810#1818001, @MaskRay wrote:

In D52810#1817883, @sbc100 wrote:

I it seems that the printing of this error message only occurs with GNU nm if the object doesn't have a symbols table at all. Have no symbols in the table does not print the error message.

$ touch foo.c
$ gcc -c foo.c
$ nm foo.o  <- no error output here.
$ strip foo.o
$ nm foo.o
nm: foo.o: no symbols

Interesting (subtle) behavior...

@rupprecht Do we know what projects parse "no symbols" from llvm-nm output?

The one case I remember fixing was an integration test that ran something like strip <file>; nm <file> |& grep "no symbols" to make sure the strip step actually ran. So, the second case in the example above. There were a surprising number of other uses like this that I can't find anymore.

I think we should update it to not print "no symbols" if there is an empty symbol table, then. Nice find.

[sbc100]

In emscripten we don't parse "no symbols" but we do run "llvm-nm -print-armap" and out users are seeing noise when they have objects with no symbols (not because they are stripped but simply because there are no public symbols).

https://github.com/emscripten-core/emscripten/pull/10198 is my workaround.

I've got a fix llvm-nm that I will upload, but funnily enough it doesn't actually solve the wasm issue. The reason is that with ELF we always generate at least one local symbols (the STT_FILE symbols) so no unstripped object will ever report "no symbols". However compiling the empty file on wasm does generate file with a symbol table of size zero.. which mean the fix I'm proposing doesn't actually fix our issue.

[jhenderson]

In D52810#1818209, @sbc100 wrote:

I've got a fix llvm-nm that I will upload, but funnily enough it doesn't actually solve the wasm issue. The reason is that with ELF we always generate at least one local symbols (the STT_FILE symbols) so no unstripped object will ever report "no symbols". However compiling the empty file on wasm does generate file with a symbol table of size zero.. which mean the fix I'm proposing doesn't actually fix our issue.

FWIW, if you create an ELF object from an assembly file, the STT_FILE symbol will only be created if you have a .file directive.

An ELF symbol table with only the null symbol at index 0 present does result in GNU nm producing "no symbols" for me, so it's not a missing/size 0 symbol table that is exactly important, just an effectively empty table.

llvm/trunk/test/Object/nm-shared-object.test

 RUN: not llvm-nm -D %p/Inputs/weak-global-symbol.macho-i386 2>&1 \
 RUN:         | FileCheck %s -check-prefix ERROR
 
 RUN: not llvm-nm -D %p/Inputs/trivial-object-test.coff-i386 2>&1 \
 RUN:         | FileCheck %s -check-prefix ERROR
 
 ERROR: File format has no dynamic symbol table.
 
-RUN: llvm-nm -D %p/Inputs/trivial-object-test.elf-i386 | count 0
+RUN: llvm-nm -D %p/Inputs/trivial-object-test.elf-i386 | FileCheck %s -check-prefix=NO-SYMBOLS
+NO-SYMBOLS: no symbols

llvm/trunk/test/ThinLTO/X86/empty-module.ll

 ; RUN: opt -module-summary -o %t.bc %s
 
 ; RUN: rm -f %t2.0
 ; RUN: llvm-lto2 run  %t.bc -r %t.bc,foo,pl -o %t2 -thinlto-distributed-indexes
 ; RUN: llvm-readobj -h %t2.0 | FileCheck %s
-; RUN: llvm-nm %t2.0 | count 0
+; RUN: llvm-nm %t2.0 | FileCheck %s -check-prefix=NO-SYMBOLS
+; NO-SYMBOLS: no symbols
 
 ; CHECK: Format: ELF64-x86-64
 
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-unknown-linux-gnu"
 
 @foo = ifunc i32 (i32), i64 ()* @foo_ifunc
 
 define internal i64 @foo_ifunc() {
 entry:
   ret i64 0
 }

llvm/trunk/test/tools/gold/X86/bcsection.ll

 ; RUN: rm -rf %t && mkdir -p %t
 ; RUN: llvm-as -o %t/bcsection.bc %s
 
 ; RUN: llvm-mc -I=%t -filetype=obj -triple=x86_64-unknown-unknown -o %t/bcsection.bco %p/Inputs/bcsection.s
-; RUN: llvm-nm -no-llvm-bc %t/bcsection.bco | count 0
+; RUN: llvm-nm -no-llvm-bc %t/bcsection.bco | FileCheck %s -check-prefix=NO-SYMBOLS
+; NO-SYMBOLS: no symbols
+
 ; RUN: %gold -r -o %t/bcsection.o -m elf_x86_64 -plugin %llvmshlibdir/LLVMgold%shlibext %t/bcsection.bco
 ; RUN: llvm-nm -no-llvm-bc %t/bcsection.o | FileCheck %s
 
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-unknown-unknown"
 
 ; CHECK: main
 define i32 @main() {
   ret i32 0
 }

llvm/trunk/test/tools/gold/X86/thinlto.ll

 ; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext \
 ; RUN:    -m elf_x86_64 \
 ; RUN:    --plugin-opt=thinlto \
 ; RUN:    --plugin-opt=jobs=2 \
 ; RUN:    --plugin-opt=thinlto-index-only \
 ; RUN:    --plugin-opt=obj-path=%t5.o \
 ; RUN:    -shared %t.o %t2.o -o %t4
 ; RUN: llvm-readobj -h %t5.o | FileCheck %s --check-prefix=FORMAT
-; RUN: llvm-nm %t5.o | count 0
+; RUN: llvm-nm %t5.o | FileCheck %s -check-prefix=NO-SYMBOLS
+; NO-SYMBOLS: no symbols
 
 ; NM: T f
 ; NM2: T {{f|g}}
 ; FORMAT: Format: ELF64-x86-64
 
 ; The backend index for this module contains summaries from itself and
 ; Inputs/thinlto.ll, as it imports from the latter.
 ; BACKEND1: <MODULE_STRTAB_BLOCK

llvm/trunk/test/tools/llvm-nm/X86/nm-no-symbols.test

+# RUN: yaml2obj %s > %t.o
+# RUN: llvm-nm %t.o | FileCheck %s
+# RUN: llvm-nm --print-file-name %t.o | FileCheck %s --check-prefix=CHECK-PRINT-FILE-NAME
+
+!ELF
+FileHeader:
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  Type:            ET_REL
+  Machine:         EM_X86_64
+
+# CHECK: {{^}}no symbols{{$}}
+
+# CHECK-PRINT-FILE-NAME: nm-no-symbols.test{{.*}}.o: no symbols{{$}}

llvm/trunk/tools/llvm-nm/llvm-nm.cpp

if (isSymbolList64Bit(Obj)) {
     case Radix::x:
       printFormat = OutputFormat == posix ? "%" PRIx64 : "%08" PRIx64;
       break;
     default:
       printFormat = OutputFormat == posix ? "%" PRId64 : "%08" PRId64;
     }
   }
 
+  auto writeFileName = [&]() {
+    if (!ArchitectureName.empty())
+      outs() << "(for architecture " << ArchitectureName << "):";
+    if (OutputFormat == posix && !ArchiveName.empty())
+      outs() << ArchiveName << "[" << CurrentFilename << "]: ";
+    else {
+      if (!ArchiveName.empty())
+        outs() << ArchiveName << ":";
+      outs() << CurrentFilename << ": ";
+    }
+  };
+
+  if (SymbolList.empty()) {
+    if (PrintFileName)
+      writeFileName();
+    outs() << "no symbols\n";
+  }
+
   for (SymbolListT::iterator I = SymbolList.begin(), E = SymbolList.end();
        I != E; ++I) {
     uint32_t SymFlags;
     std::string Name = I->Name.str();
     MachOObjectFile *MachO = dyn_cast<MachOObjectFile>(&Obj);
     if (Demangle) {
       if (Optional<std::string> Opt = demangle(I->Name, MachO))
         Name = *Opt;
     }
     if (I->Sym.getRawDataRefImpl().p)
       SymFlags = I->Sym.getFlags();
     else
       SymFlags = I->SymFlags;
 
     bool Undefined = SymFlags & SymbolRef::SF_Undefined;
     bool Global = SymFlags & SymbolRef::SF_Global;
     bool Weak = SymFlags & SymbolRef::SF_Weak;
     if ((!Undefined && UndefinedOnly) || (Undefined && DefinedOnly) ||
         (!Global && ExternalOnly) || (SizeSort && !PrintAddress) ||
         (Weak && NoWeakSymbols))
       continue;
-    if (PrintFileName) {
-      if (!ArchitectureName.empty())
-        outs() << "(for architecture " << ArchitectureName << "):";
-      if (OutputFormat == posix && !ArchiveName.empty())
-        outs() << ArchiveName << "[" << CurrentFilename << "]: ";
-      else {
-        if (!ArchiveName.empty())
-          outs() << ArchiveName << ":";
-        outs() << CurrentFilename << ": ";
-      }
-    }
+    if (PrintFileName)
+      writeFileName();
     if ((JustSymbolName ||
          (UndefinedOnly && MachO && OutputFormat != darwin)) &&
         OutputFormat != posix) {
       outs() << Name << "\n";
       continue;
     }
 
     char SymbolAddrStr[18] = "";