This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Extend single-operand FP insns to match Arm ARM (NFCI)
ClosedPublic

Authored by olista01 on Sep 25 2018, 7:16 AM.

Details

Summary

The Armv8.3-A reference manual defines floating-point data-processing
instructions with one source operand to have an opcode of 6 bits
[20:15]. The current class in tablegen, BaseSingleOperandFPData, only
allows [18:15]. This was ok because [20:19] could only be '00', with
other encodings unallocated. Armv8.5-A brings in the FRINT group of
instructions which use other values for these bits.

This patch refactors the existing class a bit to allow using the full 6
bits of the opcode, as defined in the Arm ARM.

Patch by Pablo Barrio!

Diff Detail

Event Timeline

olista01 created this revision.Sep 25 2018, 7:16 AM
t.p.northover accepted this revision.Sep 26 2018, 7:49 AM

Looks fine to me.

This revision is now accepted and ready to land.Sep 26 2018, 7:49 AM
This revision was automatically updated to reflect the committed changes.