This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly][NFC] Move SIMD encoding tests to dedicated file
ClosedPublic

Authored by tlively on Sep 12 2018, 4:04 PM.

Details

Summary

This change makes the tests more focused and avoids problematic
interactions between the testing modes and instruction encoding. This
change also allows the other tests to use less verbose output and
stricter checks.

Diff Detail

Repository
rL LLVM

Event Timeline

tlively created this revision.Sep 12 2018, 4:04 PM

Nit: Can we move the file name changing part to a separate CL?

Nit: Can we move the file name changing part to a separate CL?

Done in D52110.

Thanks! Could you please update diff for this CL then so it does not contain D52110?

tlively updated this revision to Diff 165589.Sep 14 2018, 2:02 PM
  • Update diff after landing D52110
aheejin accepted this revision.Sep 14 2018, 2:07 PM
This revision is now accepted and ready to land.Sep 14 2018, 2:07 PM
This revision was automatically updated to reflect the committed changes.