TableGen/CodeGenDAGPatterns: addPredicateFn only once
ClosedPublic

Authored by nhaehnle on Sep 12 2018, 9:52 AM.

Details

Summary

The predicate function is added in InlinePatternFragments, no need to
do it here. As a result, all uses of addPredicateFn are located in
InlinePatternFragments.

Test confirmed that there are no changes to generated files when
building all (non-experimental) targets.

Change-Id: I720e42e045ca596eb0aa339fb61adf6fe71034d5

Diff Detail

Repository
rL LLVM
nhaehnle created this revision.Sep 12 2018, 9:52 AM

Any perf numbers? For instance, on x86 -gen-dag-isel

Any perf numbers? For instance, on x86 -gen-dag-isel

No, and I don't see why we'd care. The motivation was purely code cleanup, and I don't see how the performance could get worse.

Any perf numbers? For instance, on x86 -gen-dag-isel

No, and I don't see why we'd care. The motivation was purely code cleanup, and I don't see how the performance could get worse.

Curiosity - I've been trying very hard to reduce tablegen build times over the past few months.

hfinkel accepted this revision.Sep 21 2018, 9:50 AM

Any perf numbers? For instance, on x86 -gen-dag-isel

No, and I don't see why we'd care. The motivation was purely code cleanup, and I don't see how the performance could get worse.

Curiosity - I've been trying very hard to reduce tablegen build times over the past few months.

Sounds great. In the mean time, however, I see no reason not to approve this patch. Seems like the performance would only get better.

This revision is now accepted and ready to land.Sep 21 2018, 9:50 AM
This revision was automatically updated to reflect the committed changes.